[INFO] updating cached repository jonirrings/conway_s_game_of_life [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jonirrings/conway_s_game_of_life [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jonirrings/conway_s_game_of_life" "work/ex/clippy-test-run/sources/stable/gh/jonirrings/conway_s_game_of_life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jonirrings/conway_s_game_of_life'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jonirrings/conway_s_game_of_life" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonirrings/conway_s_game_of_life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonirrings/conway_s_game_of_life'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c04a51342c5c93a9b4bbb8c53ba286d0cb47f9a8 [INFO] sha for GitHub repo jonirrings/conway_s_game_of_life: c04a51342c5c93a9b4bbb8c53ba286d0cb47f9a8 [INFO] validating manifest of jonirrings/conway_s_game_of_life on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jonirrings/conway_s_game_of_life on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jonirrings/conway_s_game_of_life [INFO] finished frobbing jonirrings/conway_s_game_of_life [INFO] frobbed toml for jonirrings/conway_s_game_of_life written to work/ex/clippy-test-run/sources/stable/gh/jonirrings/conway_s_game_of_life/Cargo.toml [INFO] started frobbing jonirrings/conway_s_game_of_life [INFO] finished frobbing jonirrings/conway_s_game_of_life [INFO] frobbed toml for jonirrings/conway_s_game_of_life written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonirrings/conway_s_game_of_life/Cargo.toml [INFO] crate jonirrings/conway_s_game_of_life has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jonirrings/conway_s_game_of_life against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jonirrings/conway_s_game_of_life:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 96acacbcf8df472a356607819686b5065e753f15bb2b40260f8930a0e6468681 [INFO] running `"docker" "start" "-a" "96acacbcf8df472a356607819686b5065e753f15bb2b40260f8930a0e6468681"` [INFO] [stderr] warning: `panic` setting is ignored for `test` profile [INFO] [stderr] warning: `panic` setting is ignored for `bench` profile [INFO] [stderr] Compiling num-traits v0.2.4 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking libc v0.2.42 [INFO] [stderr] Compiling matrixmultiply v0.1.14 [INFO] [stderr] Checking ucd-util v0.1.1 [INFO] [stderr] Checking either v1.5.0 [INFO] [stderr] Checking rawpointer v0.1.0 [INFO] [stderr] Compiling ndarray v0.11.2 [INFO] [stderr] Compiling regex v1.0.0 [INFO] [stderr] Checking lazy_static v1.0.1 [INFO] [stderr] Checking utf8-ranges v1.0.0 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking itertools v0.7.8 [INFO] [stderr] Checking regex-syntax v0.6.0 [INFO] [stderr] Checking thread_local v0.3.5 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking conway_s_game_of_life v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:28:33 [INFO] [stderr] | [INFO] [stderr] 28 | expanded_grid.slice_mut(s![1..-1,1..-1]).assign(&grid); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:37:51 [INFO] [stderr] | [INFO] [stderr] 37 | neighbor_view += &expanded_grid.slice(s![0..-2, 0..-2]); // north west [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | neighbor_view += &expanded_grid.slice(s![0..-2, 1..-1]); // west [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:39:51 [INFO] [stderr] | [INFO] [stderr] 39 | neighbor_view += &expanded_grid.slice(s![0..-2, 2.. ]); // south west [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:41:51 [INFO] [stderr] | [INFO] [stderr] 41 | neighbor_view += &expanded_grid.slice(s![1..-1, 0..-2]); // north [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:42:51 [INFO] [stderr] | [INFO] [stderr] 42 | neighbor_view += &expanded_grid.slice(s![1..-1, 2.. ]); // south [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:44:51 [INFO] [stderr] | [INFO] [stderr] 44 | neighbor_view += &expanded_grid.slice(s![2.., 0..-2]); // north east [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:45:51 [INFO] [stderr] | [INFO] [stderr] 45 | neighbor_view += &expanded_grid.slice(s![2.., 1..-1]); // east [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:46:51 [INFO] [stderr] | [INFO] [stderr] 46 | neighbor_view += &expanded_grid.slice(s![2.., 2.. ]); // south east [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/config_loader.rs:9:26 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn load_config(path: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/config_loader.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | caps.get(1).map(|mat| { [INFO] [stderr] | _________________________^ [INFO] [stderr] | |_________________________| [INFO] [stderr] | || [INFO] [stderr] 32 | || gen = usize::from_str(mat.as_str()).unwrap_or(0); [INFO] [stderr] 33 | || }); [INFO] [stderr] | ||__________________________^- help: try this: `if let Some(mat) = caps.get(1) { gen = usize::from_str(mat.as_str()).unwrap_or(0); }` [INFO] [stderr] | |___________________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/config_loader.rs:43:25 [INFO] [stderr] | [INFO] [stderr] 43 | caps.get(1).map(|mat| { [INFO] [stderr] | _________________________^ [INFO] [stderr] | |_________________________| [INFO] [stderr] | || [INFO] [stderr] 44 | || rows = usize::from_str(mat.as_str()).unwrap_or(0); [INFO] [stderr] 45 | || }); [INFO] [stderr] | ||__________________________^- help: try this: `if let Some(mat) = caps.get(1) { rows = usize::from_str(mat.as_str()).unwrap_or(0); }` [INFO] [stderr] | |___________________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/config_loader.rs:46:25 [INFO] [stderr] | [INFO] [stderr] 46 | caps.get(2).map(|mat| { [INFO] [stderr] | _________________________^ [INFO] [stderr] | |_________________________| [INFO] [stderr] | || [INFO] [stderr] 47 | || cols = usize::from_str(mat.as_str()).unwrap_or(0); [INFO] [stderr] 48 | || }); [INFO] [stderr] | ||__________________________^- help: try this: `if let Some(mat) = caps.get(2) { cols = usize::from_str(mat.as_str()).unwrap_or(0); }` [INFO] [stderr] | |___________________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config_loader.rs:65:46 [INFO] [stderr] | [INFO] [stderr] 65 | if rows == 0 || cols == 0 || gen == 0 || cells.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cells.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/board.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | let ref grid = self.grid; [INFO] [stderr] | ----^^^^^^^^------------- help: try: `let grid = &self.grid;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/board.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | let ref grid = self.grid; [INFO] [stderr] | ----^^^^^^^^------------- help: try: `let grid = &self.grid;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:28:33 [INFO] [stderr] | [INFO] [stderr] 28 | expanded_grid.slice_mut(s![1..-1,1..-1]).assign(&grid); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:37:51 [INFO] [stderr] | [INFO] [stderr] 37 | neighbor_view += &expanded_grid.slice(s![0..-2, 0..-2]); // north west [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | neighbor_view += &expanded_grid.slice(s![0..-2, 1..-1]); // west [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:39:51 [INFO] [stderr] | [INFO] [stderr] 39 | neighbor_view += &expanded_grid.slice(s![0..-2, 2.. ]); // south west [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:41:51 [INFO] [stderr] | [INFO] [stderr] 41 | neighbor_view += &expanded_grid.slice(s![1..-1, 0..-2]); // north [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:42:51 [INFO] [stderr] | [INFO] [stderr] 42 | neighbor_view += &expanded_grid.slice(s![1..-1, 2.. ]); // south [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:44:51 [INFO] [stderr] | [INFO] [stderr] 44 | neighbor_view += &expanded_grid.slice(s![2.., 0..-2]); // north east [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:45:51 [INFO] [stderr] | [INFO] [stderr] 45 | neighbor_view += &expanded_grid.slice(s![2.., 1..-1]); // east [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:46:51 [INFO] [stderr] | [INFO] [stderr] 46 | neighbor_view += &expanded_grid.slice(s![2.., 2.. ]); // south east [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/config_loader.rs:9:26 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn load_config(path: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/config_loader.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | caps.get(1).map(|mat| { [INFO] [stderr] | _________________________^ [INFO] [stderr] | |_________________________| [INFO] [stderr] | || [INFO] [stderr] 32 | || gen = usize::from_str(mat.as_str()).unwrap_or(0); [INFO] [stderr] 33 | || }); [INFO] [stderr] | ||__________________________^- help: try this: `if let Some(mat) = caps.get(1) { gen = usize::from_str(mat.as_str()).unwrap_or(0); }` [INFO] [stderr] | |___________________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/config_loader.rs:43:25 [INFO] [stderr] | [INFO] [stderr] 43 | caps.get(1).map(|mat| { [INFO] [stderr] | _________________________^ [INFO] [stderr] | |_________________________| [INFO] [stderr] | || [INFO] [stderr] 44 | || rows = usize::from_str(mat.as_str()).unwrap_or(0); [INFO] [stderr] 45 | || }); [INFO] [stderr] | ||__________________________^- help: try this: `if let Some(mat) = caps.get(1) { rows = usize::from_str(mat.as_str()).unwrap_or(0); }` [INFO] [stderr] | |___________________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/config_loader.rs:46:25 [INFO] [stderr] | [INFO] [stderr] 46 | caps.get(2).map(|mat| { [INFO] [stderr] | _________________________^ [INFO] [stderr] | |_________________________| [INFO] [stderr] | || [INFO] [stderr] 47 | || cols = usize::from_str(mat.as_str()).unwrap_or(0); [INFO] [stderr] 48 | || }); [INFO] [stderr] | ||__________________________^- help: try this: `if let Some(mat) = caps.get(2) { cols = usize::from_str(mat.as_str()).unwrap_or(0); }` [INFO] [stderr] | |___________________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config_loader.rs:65:46 [INFO] [stderr] | [INFO] [stderr] 65 | if rows == 0 || cols == 0 || gen == 0 || cells.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cells.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/board.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | let ref grid = self.grid; [INFO] [stderr] | ----^^^^^^^^------------- help: try: `let grid = &self.grid;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/board.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | let ref grid = self.grid; [INFO] [stderr] | ----^^^^^^^^------------- help: try: `let grid = &self.grid;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:28:33 [INFO] [stderr] | [INFO] [stderr] 28 | expanded_grid.slice_mut(s![1..-1,1..-1]).assign(&grid); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:37:51 [INFO] [stderr] | [INFO] [stderr] 37 | neighbor_view += &expanded_grid.slice(s![0..-2, 0..-2]); // north west [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | neighbor_view += &expanded_grid.slice(s![0..-2, 1..-1]); // west [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:39:51 [INFO] [stderr] | [INFO] [stderr] 39 | neighbor_view += &expanded_grid.slice(s![0..-2, 2.. ]); // south west [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:41:51 [INFO] [stderr] | [INFO] [stderr] 41 | neighbor_view += &expanded_grid.slice(s![1..-1, 0..-2]); // north [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:42:51 [INFO] [stderr] | [INFO] [stderr] 42 | neighbor_view += &expanded_grid.slice(s![1..-1, 2.. ]); // south [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:44:51 [INFO] [stderr] | [INFO] [stderr] 44 | neighbor_view += &expanded_grid.slice(s![2.., 0..-2]); // north east [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:45:51 [INFO] [stderr] | [INFO] [stderr] 45 | neighbor_view += &expanded_grid.slice(s![2.., 1..-1]); // east [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/board.rs:46:51 [INFO] [stderr] | [INFO] [stderr] 46 | neighbor_view += &expanded_grid.slice(s![2.., 2.. ]); // south east [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/config_loader.rs:9:26 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn load_config(path: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/config_loader.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | caps.get(1).map(|mat| { [INFO] [stderr] | _________________________^ [INFO] [stderr] | |_________________________| [INFO] [stderr] | || [INFO] [stderr] 32 | || gen = usize::from_str(mat.as_str()).unwrap_or(0); [INFO] [stderr] 33 | || }); [INFO] [stderr] | ||__________________________^- help: try this: `if let Some(mat) = caps.get(1) { gen = usize::from_str(mat.as_str()).unwrap_or(0); }` [INFO] [stderr] | |___________________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/config_loader.rs:43:25 [INFO] [stderr] | [INFO] [stderr] 43 | caps.get(1).map(|mat| { [INFO] [stderr] | _________________________^ [INFO] [stderr] | |_________________________| [INFO] [stderr] | || [INFO] [stderr] 44 | || rows = usize::from_str(mat.as_str()).unwrap_or(0); [INFO] [stderr] 45 | || }); [INFO] [stderr] | ||__________________________^- help: try this: `if let Some(mat) = caps.get(1) { rows = usize::from_str(mat.as_str()).unwrap_or(0); }` [INFO] [stderr] | |___________________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/config_loader.rs:46:25 [INFO] [stderr] | [INFO] [stderr] 46 | caps.get(2).map(|mat| { [INFO] [stderr] | _________________________^ [INFO] [stderr] | |_________________________| [INFO] [stderr] | || [INFO] [stderr] 47 | || cols = usize::from_str(mat.as_str()).unwrap_or(0); [INFO] [stderr] 48 | || }); [INFO] [stderr] | ||__________________________^- help: try this: `if let Some(mat) = caps.get(2) { cols = usize::from_str(mat.as_str()).unwrap_or(0); }` [INFO] [stderr] | |___________________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config_loader.rs:65:46 [INFO] [stderr] | [INFO] [stderr] 65 | if rows == 0 || cols == 0 || gen == 0 || cells.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cells.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/board.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | let ref grid = self.grid; [INFO] [stderr] | ----^^^^^^^^------------- help: try: `let grid = &self.grid;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/board.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | let ref grid = self.grid; [INFO] [stderr] | ----^^^^^^^^------------- help: try: `let grid = &self.grid;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 46.46s [INFO] running `"docker" "inspect" "96acacbcf8df472a356607819686b5065e753f15bb2b40260f8930a0e6468681"` [INFO] running `"docker" "rm" "-f" "96acacbcf8df472a356607819686b5065e753f15bb2b40260f8930a0e6468681"` [INFO] [stdout] 96acacbcf8df472a356607819686b5065e753f15bb2b40260f8930a0e6468681