[INFO] updating cached repository jonhoo/su-extract [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jonhoo/su-extract [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jonhoo/su-extract" "work/ex/clippy-test-run/sources/stable/gh/jonhoo/su-extract"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jonhoo/su-extract'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jonhoo/su-extract" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonhoo/su-extract"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonhoo/su-extract'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 36a2eb8f2792ce90f10b8a88c0f456af6aaa48c0 [INFO] sha for GitHub repo jonhoo/su-extract: 36a2eb8f2792ce90f10b8a88c0f456af6aaa48c0 [INFO] validating manifest of jonhoo/su-extract on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jonhoo/su-extract on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jonhoo/su-extract [INFO] finished frobbing jonhoo/su-extract [INFO] frobbed toml for jonhoo/su-extract written to work/ex/clippy-test-run/sources/stable/gh/jonhoo/su-extract/Cargo.toml [INFO] started frobbing jonhoo/su-extract [INFO] finished frobbing jonhoo/su-extract [INFO] frobbed toml for jonhoo/su-extract written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonhoo/su-extract/Cargo.toml [INFO] crate jonhoo/su-extract has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jonhoo/su-extract against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jonhoo/su-extract:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4749b4b8ea941f14f550712719dd1fc0d38ad1e2ae510d5db24fc122f80781e3 [INFO] running `"docker" "start" "-a" "4749b4b8ea941f14f550712719dd1fc0d38ad1e2ae510d5db24fc122f80781e3"` [INFO] [stderr] Compiling serde v1.0.63 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Compiling openssl-sys v0.9.31 [INFO] [stderr] Checking clicolors-control v0.2.0 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking tokio-threadpool v0.1.3 [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking tokio-fs v0.1.0 [INFO] [stderr] Checking console v0.6.1 [INFO] [stderr] Checking tokio v0.1.6 [INFO] [stderr] Checking indicatif v0.9.0 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking serde_json v1.0.18 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Checking csv v1.0.0 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Checking su-extract v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:110:25 [INFO] [stderr] | [INFO] [stderr] 110 | let mut bar = indicatif::ProgressBar::new(total); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | / match (liked.get("title"), liked.get("url")) { [INFO] [stderr] 143 | | ( [INFO] [stderr] 144 | | Some(&serde_json::Value::String(ref title)), [INFO] [stderr] 145 | | Some(&serde_json::Value::String(ref url)), [INFO] [stderr] ... | [INFO] [stderr] 152 | | _ => {} [INFO] [stderr] 153 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 142 | if let ( [INFO] [stderr] 143 | Some(&serde_json::Value::String(ref title)), [INFO] [stderr] 144 | Some(&serde_json::Value::String(ref url)), [INFO] [stderr] 145 | ) = (liked.get("title"), liked.get("url")) { [INFO] [stderr] 146 | use std::iter; [INFO] [stderr] 147 | w.write_record(iter::once(title).chain(iter::once(url))) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:110:25 [INFO] [stderr] | [INFO] [stderr] 110 | let mut bar = indicatif::ProgressBar::new(total); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | / match (liked.get("title"), liked.get("url")) { [INFO] [stderr] 143 | | ( [INFO] [stderr] 144 | | Some(&serde_json::Value::String(ref title)), [INFO] [stderr] 145 | | Some(&serde_json::Value::String(ref url)), [INFO] [stderr] ... | [INFO] [stderr] 152 | | _ => {} [INFO] [stderr] 153 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 142 | if let ( [INFO] [stderr] 143 | Some(&serde_json::Value::String(ref title)), [INFO] [stderr] 144 | Some(&serde_json::Value::String(ref url)), [INFO] [stderr] 145 | ) = (liked.get("title"), liked.get("url")) { [INFO] [stderr] 146 | use std::iter; [INFO] [stderr] 147 | w.write_record(iter::once(title).chain(iter::once(url))) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 49.57s [INFO] running `"docker" "inspect" "4749b4b8ea941f14f550712719dd1fc0d38ad1e2ae510d5db24fc122f80781e3"` [INFO] running `"docker" "rm" "-f" "4749b4b8ea941f14f550712719dd1fc0d38ad1e2ae510d5db24fc122f80781e3"` [INFO] [stdout] 4749b4b8ea941f14f550712719dd1fc0d38ad1e2ae510d5db24fc122f80781e3