[INFO] updating cached repository jonhoo/proximity-sort [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jonhoo/proximity-sort [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jonhoo/proximity-sort" "work/ex/clippy-test-run/sources/stable/gh/jonhoo/proximity-sort"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jonhoo/proximity-sort'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jonhoo/proximity-sort" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonhoo/proximity-sort"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonhoo/proximity-sort'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3827df25ea002a3d759b09b7c151fc008b6837ef [INFO] sha for GitHub repo jonhoo/proximity-sort: 3827df25ea002a3d759b09b7c151fc008b6837ef [INFO] validating manifest of jonhoo/proximity-sort on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jonhoo/proximity-sort on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jonhoo/proximity-sort [INFO] finished frobbing jonhoo/proximity-sort [INFO] frobbed toml for jonhoo/proximity-sort written to work/ex/clippy-test-run/sources/stable/gh/jonhoo/proximity-sort/Cargo.toml [INFO] started frobbing jonhoo/proximity-sort [INFO] finished frobbing jonhoo/proximity-sort [INFO] frobbed toml for jonhoo/proximity-sort written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonhoo/proximity-sort/Cargo.toml [INFO] crate jonhoo/proximity-sort has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jonhoo/proximity-sort against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jonhoo/proximity-sort:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e0e9eb8012ef1db5839d12d103a0f97ff6221596215fdc2dd121bb712de41d16 [INFO] running `"docker" "start" "-a" "e0e9eb8012ef1db5839d12d103a0f97ff6221596215fdc2dd121bb712de41d16"` [INFO] [stderr] Checking proximity-sort v1.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"test.txt"` [INFO] [stderr] ... [INFO] [stderr] 166 | bts!("test.txt"), [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"bar/test.txt"` [INFO] [stderr] ... [INFO] [stderr] 167 | bts!("bar/test.txt"), [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"bar/main.txt"` [INFO] [stderr] ... [INFO] [stderr] 168 | bts!("bar/main.txt"), [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"misc/test.txt"` [INFO] [stderr] ... [INFO] [stderr] 169 | bts!("misc/test.txt"), [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"bar/main.txt"` [INFO] [stderr] ... [INFO] [stderr] 175 | vec![bts!("bar/main.txt"), bts!("bar/test.txt"),] [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"bar/test.txt"` [INFO] [stderr] ... [INFO] [stderr] 175 | vec![bts!("bar/main.txt"), bts!("bar/test.txt"),] [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"baz/controller/admin.rb"` [INFO] [stderr] ... [INFO] [stderr] 181 | bts!("baz/controller/admin.rb"), [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"foobar/controller/user.rb"` [INFO] [stderr] ... [INFO] [stderr] 182 | bts!("foobar/controller/user.rb"), [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"baz/views/admin.rb"` [INFO] [stderr] ... [INFO] [stderr] 183 | bts!("baz/views/admin.rb"), [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"foobar/controller/admin.rb"` [INFO] [stderr] ... [INFO] [stderr] 184 | bts!("foobar/controller/admin.rb"), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"foobar/views/admin.rb"` [INFO] [stderr] ... [INFO] [stderr] 185 | bts!("foobar/views/admin.rb"), [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"foobar/controller/admin.rb"` [INFO] [stderr] ... [INFO] [stderr] 192 | bts!("foobar/controller/admin.rb"), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"foobar/controller/user.rb"` [INFO] [stderr] ... [INFO] [stderr] 193 | bts!("foobar/controller/user.rb"), [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"foobar/views/admin.rb"` [INFO] [stderr] ... [INFO] [stderr] 194 | bts!("foobar/views/admin.rb"), [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"a/foo.txt"` [INFO] [stderr] ... [INFO] [stderr] 203 | vec![bts!("a/foo.txt"), bts!("b/foo.txt"), bts!("foo.txt"),], [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"b/foo.txt"` [INFO] [stderr] ... [INFO] [stderr] 203 | vec![bts!("a/foo.txt"), bts!("b/foo.txt"), bts!("foo.txt"),], [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"foo.txt"` [INFO] [stderr] ... [INFO] [stderr] 203 | vec![bts!("a/foo.txt"), bts!("b/foo.txt"), bts!("foo.txt"),], [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"a/foo.txt"` [INFO] [stderr] ... [INFO] [stderr] 207 | vec![bts!("a/foo.txt"), bts!("foo.txt"), bts!("b/foo.txt"),] [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"foo.txt"` [INFO] [stderr] ... [INFO] [stderr] 207 | vec![bts!("a/foo.txt"), bts!("foo.txt"), bts!("b/foo.txt"),] [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"b/foo.txt"` [INFO] [stderr] ... [INFO] [stderr] 207 | vec![bts!("a/foo.txt"), bts!("foo.txt"), bts!("b/foo.txt"),] [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"first.txt"` [INFO] [stderr] ... [INFO] [stderr] 215 | vec![bts!("first.txt"), bts!("second.txt"), bts!("third.txt"),], [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"second.txt"` [INFO] [stderr] ... [INFO] [stderr] 215 | vec![bts!("first.txt"), bts!("second.txt"), bts!("third.txt"),], [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"third.txt"` [INFO] [stderr] ... [INFO] [stderr] 215 | vec![bts!("first.txt"), bts!("second.txt"), bts!("third.txt"),], [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"first.txt"` [INFO] [stderr] ... [INFO] [stderr] 219 | vec![bts!("first.txt"), bts!("second.txt"), bts!("third.txt"),] [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"second.txt"` [INFO] [stderr] ... [INFO] [stderr] 219 | vec![bts!("first.txt"), bts!("second.txt"), bts!("third.txt"),] [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | Vec::from($bts.as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"third.txt"` [INFO] [stderr] ... [INFO] [stderr] 219 | vec![bts!("first.txt"), bts!("second.txt"), bts!("third.txt"),] [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.72s [INFO] running `"docker" "inspect" "e0e9eb8012ef1db5839d12d103a0f97ff6221596215fdc2dd121bb712de41d16"` [INFO] running `"docker" "rm" "-f" "e0e9eb8012ef1db5839d12d103a0f97ff6221596215fdc2dd121bb712de41d16"` [INFO] [stdout] e0e9eb8012ef1db5839d12d103a0f97ff6221596215fdc2dd121bb712de41d16