[INFO] updating cached repository jondot/rawsort [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jondot/rawsort [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jondot/rawsort" "work/ex/clippy-test-run/sources/stable/gh/jondot/rawsort"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jondot/rawsort'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jondot/rawsort" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jondot/rawsort"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jondot/rawsort'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ae8550b6ce09222bce03ee7095defb6afa522466 [INFO] sha for GitHub repo jondot/rawsort: ae8550b6ce09222bce03ee7095defb6afa522466 [INFO] validating manifest of jondot/rawsort on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jondot/rawsort on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jondot/rawsort [INFO] finished frobbing jondot/rawsort [INFO] frobbed toml for jondot/rawsort written to work/ex/clippy-test-run/sources/stable/gh/jondot/rawsort/Cargo.toml [INFO] started frobbing jondot/rawsort [INFO] finished frobbing jondot/rawsort [INFO] frobbed toml for jondot/rawsort written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jondot/rawsort/Cargo.toml [INFO] crate jondot/rawsort has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jondot/rawsort against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jondot/rawsort:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 948355b4f54e0846c881c657ca3507644ea39410f2d002e807b2f14cf072c27a [INFO] running `"docker" "start" "-a" "948355b4f54e0846c881c657ca3507644ea39410f2d002e807b2f14cf072c27a"` [INFO] [stderr] Checking slog v2.3.3 [INFO] [stderr] Checking kamadak-exif v0.3.1 [INFO] [stderr] Checking inotify-sys v0.1.3 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking isatty v0.1.9 [INFO] [stderr] Checking filetime v0.2.1 [INFO] [stderr] Checking bytes v0.4.9 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking parking_lot v0.6.3 [INFO] [stderr] Checking slog-json v2.2.0 [INFO] [stderr] Checking slog-term v2.4.0 [INFO] [stderr] Checking mio v0.6.15 [INFO] [stderr] Checking console v0.6.1 [INFO] [stderr] Checking tokio-io v0.1.8 [INFO] [stderr] Checking dialoguer v0.1.0 [INFO] [stderr] Checking tokio-reactor v0.1.5 [INFO] [stderr] Checking mio-extras v2.0.5 [INFO] [stderr] Checking inotify v0.6.1 [INFO] [stderr] Checking notify v4.0.6 [INFO] [stderr] Checking rawsort v0.3.1-alpha.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executor.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | Executor { registry: registry } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `registry` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exif.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | utc: utc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `utc` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executor.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | Executor { registry: registry } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `registry` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exif.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | utc: utc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `utc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/executor.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | / return ExecutionPlan { [INFO] [stderr] 56 | | dirs_to_create: missing_dirs, [INFO] [stderr] 57 | | moves: mapped, [INFO] [stderr] 58 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 55 | ExecutionPlan { [INFO] [stderr] 56 | dirs_to_create: missing_dirs, [INFO] [stderr] 57 | moves: mapped, [INFO] [stderr] 58 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/executor.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | return p.parent().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `p.parent().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/executor.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | return Err(format!("Source and target file counts aren't equal: {} file(s) for source, {} file(s) for target.", sources.len(), targets.len())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Source and target file counts aren't equal: {} file(s) for source, {} file(s) for target.", sources.len(), targets.len()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/exif.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return file_time; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `file_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/registry.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / return self [INFO] [stderr] 23 | | .map [INFO] [stderr] 24 | | .keys() [INFO] [stderr] 25 | | .map(|k| { [INFO] [stderr] ... | [INFO] [stderr] 28 | | }) [INFO] [stderr] 29 | | .collect(); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 22 | self [INFO] [stderr] 23 | .map [INFO] [stderr] 24 | .keys() [INFO] [stderr] 25 | .map(|k| { [INFO] [stderr] 26 | let (desc, _) = self.map.get(k).unwrap(); [INFO] [stderr] 27 | (k, desc) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/executor.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | / return ExecutionPlan { [INFO] [stderr] 56 | | dirs_to_create: missing_dirs, [INFO] [stderr] 57 | | moves: mapped, [INFO] [stderr] 58 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 55 | ExecutionPlan { [INFO] [stderr] 56 | dirs_to_create: missing_dirs, [INFO] [stderr] 57 | moves: mapped, [INFO] [stderr] 58 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/executor.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | return p.parent().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `p.parent().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/executor.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | return Err(format!("Source and target file counts aren't equal: {} file(s) for source, {} file(s) for target.", sources.len(), targets.len())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Source and target file counts aren't equal: {} file(s) for source, {} file(s) for target.", sources.len(), targets.len()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/exif.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return file_time; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `file_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/registry.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / return self [INFO] [stderr] 23 | | .map [INFO] [stderr] 24 | | .keys() [INFO] [stderr] 25 | | .map(|k| { [INFO] [stderr] ... | [INFO] [stderr] 28 | | }) [INFO] [stderr] 29 | | .collect(); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 22 | self [INFO] [stderr] 23 | .map [INFO] [stderr] 24 | .keys() [INFO] [stderr] 25 | .map(|k| { [INFO] [stderr] 26 | let (desc, _) = self.map.get(k).unwrap(); [INFO] [stderr] 27 | (k, desc) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/executor.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | .map(|p| path::PathBuf::from(p)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `path::PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/executor.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | if targets.iter().find(|t| t.to_str().unwrap() == "").is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|t| t.to_str().unwrap() == "").is_some()` with `any(|t| t.to_str().unwrap() == "")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/registry.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | map: HashMap String>)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `registry::Registry` [INFO] [stderr] --> src/registry.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Registry { [INFO] [stderr] 11 | | Registry { [INFO] [stderr] 12 | | map: HashMap::new(), [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/registry.rs:26:33 [INFO] [stderr] | [INFO] [stderr] 26 | let (desc, _) = self.map.get(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.map[k]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/registry.rs:37:33 [INFO] [stderr] | [INFO] [stderr] 37 | let (_, val) = &self.map.get(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.map[k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/executor.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | .map(|p| path::PathBuf::from(p)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `path::PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/executor.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | if targets.iter().find(|t| t.to_str().unwrap() == "").is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|t| t.to_str().unwrap() == "").is_some()` with `any(|t| t.to_str().unwrap() == "")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/registry.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | map: HashMap String>)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `registry::Registry` [INFO] [stderr] --> src/registry.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Registry { [INFO] [stderr] 11 | | Registry { [INFO] [stderr] 12 | | map: HashMap::new(), [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/registry.rs:26:33 [INFO] [stderr] | [INFO] [stderr] 26 | let (desc, _) = self.map.get(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.map[k]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/registry.rs:37:33 [INFO] [stderr] | [INFO] [stderr] 37 | let (_, val) = &self.map.get(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.map[k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/integration_test.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | / return ent [INFO] [stderr] 46 | | .path() [INFO] [stderr] 47 | | .extension() [INFO] [stderr] 48 | | .unwrap() [INFO] [stderr] 49 | | .to_str() [INFO] [stderr] 50 | | .unwrap() [INFO] [stderr] 51 | | .to_string(); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 45 | ent [INFO] [stderr] 46 | .path() [INFO] [stderr] 47 | .extension() [INFO] [stderr] 48 | .unwrap() [INFO] [stderr] 49 | .to_str() [INFO] [stderr] 50 | .unwrap() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/integration_test.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | / return ent [INFO] [stderr] 59 | | .path() [INFO] [stderr] 60 | | .file_name() [INFO] [stderr] 61 | | .unwrap() [INFO] [stderr] 62 | | .to_str() [INFO] [stderr] 63 | | .unwrap() [INFO] [stderr] 64 | | .to_string(); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 58 | ent [INFO] [stderr] 59 | .path() [INFO] [stderr] 60 | .file_name() [INFO] [stderr] 61 | .unwrap() [INFO] [stderr] 62 | .to_str() [INFO] [stderr] 63 | .unwrap() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/integration_test.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | return (plan, exec); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(plan, exec)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `exec` [INFO] [stderr] --> tests/integration_test.rs:119:16 [INFO] [stderr] | [INFO] [stderr] 119 | let (plan, exec) = make_plan("simple", "[year]"); [INFO] [stderr] | ^^^^ help: consider using `_exec` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `exec` [INFO] [stderr] --> tests/integration_test.rs:138:16 [INFO] [stderr] | [INFO] [stderr] 138 | let (plan, exec) = make_plan( [INFO] [stderr] | ^^^^ help: consider using `_exec` instead [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/integration_test.rs:87:30 [INFO] [stderr] | [INFO] [stderr] 87 | strs.to_vec().iter().map(|s| PathBuf::from(s)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | / return ent [INFO] [stderr] 65 | | .path() [INFO] [stderr] 66 | | .extension() [INFO] [stderr] 67 | | .unwrap() [INFO] [stderr] 68 | | .to_str() [INFO] [stderr] 69 | | .unwrap() [INFO] [stderr] 70 | | .to_string(); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 64 | ent [INFO] [stderr] 65 | .path() [INFO] [stderr] 66 | .extension() [INFO] [stderr] 67 | .unwrap() [INFO] [stderr] 68 | .to_str() [INFO] [stderr] 69 | .unwrap() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | / return ent [INFO] [stderr] 78 | | .path() [INFO] [stderr] 79 | | .file_name() [INFO] [stderr] 80 | | .unwrap() [INFO] [stderr] 81 | | .to_str() [INFO] [stderr] 82 | | .unwrap() [INFO] [stderr] 83 | | .to_string(); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 77 | ent [INFO] [stderr] 78 | .path() [INFO] [stderr] 79 | .file_name() [INFO] [stderr] 80 | .unwrap() [INFO] [stderr] 81 | .to_str() [INFO] [stderr] 82 | .unwrap() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | / return ent [INFO] [stderr] 65 | | .path() [INFO] [stderr] 66 | | .extension() [INFO] [stderr] 67 | | .unwrap() [INFO] [stderr] 68 | | .to_str() [INFO] [stderr] 69 | | .unwrap() [INFO] [stderr] 70 | | .to_string(); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 64 | ent [INFO] [stderr] 65 | .path() [INFO] [stderr] 66 | .extension() [INFO] [stderr] 67 | .unwrap() [INFO] [stderr] 68 | .to_str() [INFO] [stderr] 69 | .unwrap() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | / return ent [INFO] [stderr] 78 | | .path() [INFO] [stderr] 79 | | .file_name() [INFO] [stderr] 80 | | .unwrap() [INFO] [stderr] 81 | | .to_str() [INFO] [stderr] 82 | | .unwrap() [INFO] [stderr] 83 | | .to_string(); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 77 | ent [INFO] [stderr] 78 | .path() [INFO] [stderr] 79 | .file_name() [INFO] [stderr] 80 | .unwrap() [INFO] [stderr] 81 | .to_str() [INFO] [stderr] 82 | .unwrap() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | / match res { [INFO] [stderr] 173 | | Err(s) => { [INFO] [stderr] 174 | | error!(log, "Execution is not valid, aborting. Did you check your formatting rules?"; "error" => s); [INFO] [stderr] 175 | | return; [INFO] [stderr] 176 | | } [INFO] [stderr] 177 | | Ok(_) => {} [INFO] [stderr] 178 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 172 | if let Err(s) = res { [INFO] [stderr] 173 | error!(log, "Execution is not valid, aborting. Did you check your formatting rules?"; "error" => s); [INFO] [stderr] 174 | return; [INFO] [stderr] 175 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | / match res { [INFO] [stderr] 173 | | Err(s) => { [INFO] [stderr] 174 | | error!(log, "Execution is not valid, aborting. Did you check your formatting rules?"; "error" => s); [INFO] [stderr] 175 | | return; [INFO] [stderr] 176 | | } [INFO] [stderr] 177 | | Ok(_) => {} [INFO] [stderr] 178 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 172 | if let Err(s) = res { [INFO] [stderr] 173 | error!(log, "Execution is not valid, aborting. Did you check your formatting rules?"; "error" => s); [INFO] [stderr] 174 | return; [INFO] [stderr] 175 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.74s [INFO] running `"docker" "inspect" "948355b4f54e0846c881c657ca3507644ea39410f2d002e807b2f14cf072c27a"` [INFO] running `"docker" "rm" "-f" "948355b4f54e0846c881c657ca3507644ea39410f2d002e807b2f14cf072c27a"` [INFO] [stdout] 948355b4f54e0846c881c657ca3507644ea39410f2d002e807b2f14cf072c27a