[INFO] updating cached repository jonas-schievink/smith [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jonas-schievink/smith [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jonas-schievink/smith" "work/ex/clippy-test-run/sources/stable/gh/jonas-schievink/smith"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jonas-schievink/smith'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jonas-schievink/smith" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonas-schievink/smith"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonas-schievink/smith'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 984bf62fff7853bd95f216027a616a4f35de0600 [INFO] sha for GitHub repo jonas-schievink/smith: 984bf62fff7853bd95f216027a616a4f35de0600 [INFO] validating manifest of jonas-schievink/smith on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jonas-schievink/smith on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jonas-schievink/smith [INFO] finished frobbing jonas-schievink/smith [INFO] frobbed toml for jonas-schievink/smith written to work/ex/clippy-test-run/sources/stable/gh/jonas-schievink/smith/Cargo.toml [INFO] started frobbing jonas-schievink/smith [INFO] finished frobbing jonas-schievink/smith [INFO] frobbed toml for jonas-schievink/smith written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonas-schievink/smith/Cargo.toml [INFO] crate jonas-schievink/smith has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jonas-schievink/smith against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jonas-schievink/smith:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 637e4fa116b4a31bcddd83ce34dca7858da0e738348fbc65bd3cd6efbdc55184 [INFO] running `"docker" "start" "-a" "637e4fa116b4a31bcddd83ce34dca7858da0e738348fbc65bd3cd6efbdc55184"` [INFO] [stderr] Compiling openssl v0.10.10 [INFO] [stderr] Checking smith v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prompt.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | key_name: key_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `key_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prompt.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | key_name: key_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `key_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prompt.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prompt.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `agent::Agent` [INFO] [stderr] --> src/agent.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> Self { [INFO] [stderr] 28 | | Self { [INFO] [stderr] 29 | | keys: Vec::new(), [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/pubkey.rs:75:42 [INFO] [stderr] | [INFO] [stderr] 75 | let data_encoded = splitn.next().ok_or(io::Error::new(io::ErrorKind::InvalidData, [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 76 | | "no pubkey data blob found"))?; [INFO] [stderr] | |___________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 75 | let data_encoded = splitn.next().ok_or_else(|| io::Error::new(io::ErrorKind::InvalidData, [INFO] [stderr] 76 | "no pubkey data blob found"))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pubkey.rs:139:44 [INFO] [stderr] | [INFO] [stderr] 139 | pub fn sign(&self, data: &[u8], flags: &SignFlags) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `SignFlags` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/pubkey.rs:143:47 [INFO] [stderr] | [INFO] [stderr] 143 | return Err(KeyError::IllegalFlags(format!("sign flags contain incompatible bits (flags = 0x{:X})", flags).into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("sign flags contain incompatible bits (flags = 0x{:X})", flags)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `agent::Agent` [INFO] [stderr] --> src/agent.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> Self { [INFO] [stderr] 28 | | Self { [INFO] [stderr] 29 | | keys: Vec::new(), [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/pubkey.rs:75:42 [INFO] [stderr] | [INFO] [stderr] 75 | let data_encoded = splitn.next().ok_or(io::Error::new(io::ErrorKind::InvalidData, [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 76 | | "no pubkey data blob found"))?; [INFO] [stderr] | |___________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 75 | let data_encoded = splitn.next().ok_or_else(|| io::Error::new(io::ErrorKind::InvalidData, [INFO] [stderr] 76 | "no pubkey data blob found"))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pubkey.rs:139:44 [INFO] [stderr] | [INFO] [stderr] 139 | pub fn sign(&self, data: &[u8], flags: &SignFlags) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `SignFlags` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/pubkey.rs:143:47 [INFO] [stderr] | [INFO] [stderr] 143 | return Err(KeyError::IllegalFlags(format!("sign flags contain incompatible bits (flags = 0x{:X})", flags).into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("sign flags contain incompatible bits (flags = 0x{:X})", flags)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:47:28 [INFO] [stderr] | [INFO] [stderr] 47 | if let Some(mut dir) = env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:42:50 [INFO] [stderr] | [INFO] [stderr] 42 | let path = args.value_of("bind_address").map(|s| PathBuf::from(s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:47:28 [INFO] [stderr] | [INFO] [stderr] 47 | if let Some(mut dir) = env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:42:50 [INFO] [stderr] | [INFO] [stderr] 42 | let path = args.value_of("bind_address").map(|s| PathBuf::from(s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.92s [INFO] running `"docker" "inspect" "637e4fa116b4a31bcddd83ce34dca7858da0e738348fbc65bd3cd6efbdc55184"` [INFO] running `"docker" "rm" "-f" "637e4fa116b4a31bcddd83ce34dca7858da0e738348fbc65bd3cd6efbdc55184"` [INFO] [stdout] 637e4fa116b4a31bcddd83ce34dca7858da0e738348fbc65bd3cd6efbdc55184