[INFO] updating cached repository jonas-schievink/chip-8 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jonas-schievink/chip-8 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jonas-schievink/chip-8" "work/ex/clippy-test-run/sources/stable/gh/jonas-schievink/chip-8"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jonas-schievink/chip-8'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jonas-schievink/chip-8" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonas-schievink/chip-8"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonas-schievink/chip-8'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 71410220ef5cce507677bce8f3c1cc2f2bba0b9c [INFO] sha for GitHub repo jonas-schievink/chip-8: 71410220ef5cce507677bce8f3c1cc2f2bba0b9c [INFO] validating manifest of jonas-schievink/chip-8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jonas-schievink/chip-8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jonas-schievink/chip-8 [INFO] finished frobbing jonas-schievink/chip-8 [INFO] frobbed toml for jonas-schievink/chip-8 written to work/ex/clippy-test-run/sources/stable/gh/jonas-schievink/chip-8/Cargo.toml [INFO] started frobbing jonas-schievink/chip-8 [INFO] finished frobbing jonas-schievink/chip-8 [INFO] frobbed toml for jonas-schievink/chip-8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonas-schievink/chip-8/Cargo.toml [INFO] crate jonas-schievink/chip-8 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jonas-schievink/chip-8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jonas-schievink/chip-8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] df679519eabd254042ffcd4e4869e17eff472ab52ba5c3c595b953981750d3e9 [INFO] running `"docker" "start" "-a" "df679519eabd254042ffcd4e4869e17eff472ab52ba5c3c595b953981750d3e9"` [INFO] [stderr] Checking winapi v0.2.7 [INFO] [stderr] Checking libc v0.2.12 [INFO] [stderr] Compiling gcc v0.3.28 [INFO] [stderr] Checking regex-syntax v0.3.3 [INFO] [stderr] Checking ansi_term v0.7.2 [INFO] [stderr] Checking enum-set v0.0.6 [INFO] [stderr] Checking kernel32-sys v0.2.2 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking dylib v0.0.1 [INFO] [stderr] Checking clap v2.6.0 [INFO] [stderr] Checking rand v0.3.14 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking time v0.1.35 [INFO] [stderr] Checking aho-corasick v0.5.2 [INFO] [stderr] Checking x11-dl v2.2.1 [INFO] [stderr] Checking thread_local v0.2.6 [INFO] [stderr] Compiling minifb v0.7.1 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking regex v0.1.71 [INFO] [stderr] Checking env_logger v0.3.3 [INFO] [stderr] Checking chip-8 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chip8.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | mem: mem, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mem` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jit.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | pc: pc, [INFO] [stderr] | ^^^^^^ help: replace it with: `pc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jit.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | state_rc: state_rc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `state_rc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chip8.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | mem: mem, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mem` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jit.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | pc: pc, [INFO] [stderr] | ^^^^^^ help: replace it with: `pc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jit.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | state_rc: state_rc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `state_rc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip8.rs:140:33 [INFO] [stderr] | [INFO] [stderr] 140 | screen_buf[i] = 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip8.rs:140:33 [INFO] [stderr] | [INFO] [stderr] 140 | screen_buf[i] = 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting function pointer `*self` to `u64` [INFO] [stderr] --> src/calls.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | fn get_addr(&self) -> u64 { *self as u64 } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `*self as usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::fn_to_numeric_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#fn_to_numeric_cast [INFO] [stderr] [INFO] [stderr] warning: casting function pointer `*self` to `u64` [INFO] [stderr] --> src/calls.rs:20:34 [INFO] [stderr] | [INFO] [stderr] 20 | fn get_addr(&self) -> u64 { *self as u64 } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `*self as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#fn_to_numeric_cast [INFO] [stderr] [INFO] [stderr] warning: casting function pointer `*self` to `u64` [INFO] [stderr] --> src/calls.rs:25:34 [INFO] [stderr] | [INFO] [stderr] 25 | fn get_addr(&self) -> u64 { *self as u64 } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `*self as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#fn_to_numeric_cast [INFO] [stderr] [INFO] [stderr] warning: casting function pointer `*self` to `u64` [INFO] [stderr] --> src/calls.rs:30:33 [INFO] [stderr] | [INFO] [stderr] 30 | fn get_addr(&self) -> u64 { *self as u64 } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `*self as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#fn_to_numeric_cast [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/chip8.rs:177:29 [INFO] [stderr] | [INFO] [stderr] 177 | self.ops += block.len as i32 / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(block.len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8.rs:186:60 [INFO] [stderr] | [INFO] [stderr] 186 | self.cache.invalidate_range(inv_start, *inv_len as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(*inv_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ext.rs:80:16 [INFO] [stderr] | [INFO] [stderr] 80 | for idx in 0..x+1 { [INFO] [stderr] | ^^^^^^ help: use: `0..=x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ext.rs:85:25 [INFO] [stderr] | [INFO] [stderr] 85 | state.i = state.i + x as u16 + 1; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ext.rs:96:16 [INFO] [stderr] | [INFO] [stderr] 96 | for idx in 0..x+1 { [INFO] [stderr] | ^^^^^^ help: use: `0..=x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ext.rs:104:25 [INFO] [stderr] | [INFO] [stderr] 104 | state.i = state.i + x as u16 + 1; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ext.rs:131:16 [INFO] [stderr] | [INFO] [stderr] 131 | state.i = (value as u16 & 0xff) * 5; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 38 [INFO] [stderr] --> src/jit.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | / fn compile_instr(&mut self, instr: u16) -> bool { [INFO] [stderr] 161 | | // FIXME Maybe replace the `bool` with something more type safe? [INFO] [stderr] 162 | | debug!("compile_instr ${:04X}", instr); [INFO] [stderr] 163 | | [INFO] [stderr] ... | [INFO] [stderr] 576 | | } [INFO] [stderr] 577 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting function pointer `*self` to `u64` [INFO] [stderr] --> src/calls.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | fn get_addr(&self) -> u64 { *self as u64 } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `*self as usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::fn_to_numeric_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#fn_to_numeric_cast [INFO] [stderr] [INFO] [stderr] warning: casting function pointer `*self` to `u64` [INFO] [stderr] --> src/calls.rs:20:34 [INFO] [stderr] | [INFO] [stderr] 20 | fn get_addr(&self) -> u64 { *self as u64 } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `*self as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#fn_to_numeric_cast [INFO] [stderr] [INFO] [stderr] warning: casting function pointer `*self` to `u64` [INFO] [stderr] --> src/calls.rs:25:34 [INFO] [stderr] | [INFO] [stderr] 25 | fn get_addr(&self) -> u64 { *self as u64 } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `*self as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#fn_to_numeric_cast [INFO] [stderr] [INFO] [stderr] warning: casting function pointer `*self` to `u64` [INFO] [stderr] --> src/calls.rs:30:33 [INFO] [stderr] | [INFO] [stderr] 30 | fn get_addr(&self) -> u64 { *self as u64 } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `*self as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#fn_to_numeric_cast [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/chip8.rs:177:29 [INFO] [stderr] | [INFO] [stderr] 177 | self.ops += block.len as i32 / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(block.len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8.rs:186:60 [INFO] [stderr] | [INFO] [stderr] 186 | self.cache.invalidate_range(inv_start, *inv_len as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(*inv_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/jit.rs:424:54 [INFO] [stderr] | [INFO] [stderr] 424 | self.emit_call(fptr, &[state as u64, x as u64, k as u64]); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/jit.rs:424:64 [INFO] [stderr] | [INFO] [stderr] 424 | self.emit_call(fptr, &[state as u64, x as u64, k as u64]); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/jit.rs:433:54 [INFO] [stderr] | [INFO] [stderr] 433 | self.emit_call(fptr, &[state as u64, x as u64, y as u64, n as u64]); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/jit.rs:433:64 [INFO] [stderr] | [INFO] [stderr] 433 | self.emit_call(fptr, &[state as u64, x as u64, y as u64, n as u64]); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/jit.rs:433:74 [INFO] [stderr] | [INFO] [stderr] 433 | self.emit_call(fptr, &[state as u64, x as u64, y as u64, n as u64]); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/jit.rs:442:54 [INFO] [stderr] | [INFO] [stderr] 442 | self.emit_call(fptr, &[state as u64, x as u64]); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/jit.rs:455:54 [INFO] [stderr] | [INFO] [stderr] 455 | self.emit_call(fptr, &[state as u64, x as u64]); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/jit.rs:476:54 [INFO] [stderr] | [INFO] [stderr] 476 | self.emit_call(fptr, &[state as u64, x as u64]); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ext.rs:80:16 [INFO] [stderr] | [INFO] [stderr] 80 | for idx in 0..x+1 { [INFO] [stderr] | ^^^^^^ help: use: `0..=x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ext.rs:85:25 [INFO] [stderr] | [INFO] [stderr] 85 | state.i = state.i + x as u16 + 1; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/jit.rs:521:54 [INFO] [stderr] | [INFO] [stderr] 521 | self.emit_call(fptr, &[state as u64, x as u64]); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ext.rs:96:16 [INFO] [stderr] | [INFO] [stderr] 96 | for idx in 0..x+1 { [INFO] [stderr] | ^^^^^^ help: use: `0..=x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ext.rs:104:25 [INFO] [stderr] | [INFO] [stderr] 104 | state.i = state.i + x as u16 + 1; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/jit.rs:531:54 [INFO] [stderr] | [INFO] [stderr] 531 | self.emit_call(fptr, &[state as u64, x as u64]); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ext.rs:131:16 [INFO] [stderr] | [INFO] [stderr] 131 | state.i = (value as u16 & 0xff) * 5; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(value)` [INFO] [stderr] | [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/jit.rs:552:54 [INFO] [stderr] | [INFO] [stderr] 552 | self.emit_call(fptr, &[state as u64, x as u64]); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/jit.rs:569:54 [INFO] [stderr] | [INFO] [stderr] 569 | self.emit_call(fptr, &[state as u64, x as u64]); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 38 [INFO] [stderr] --> src/jit.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | / fn compile_instr(&mut self, instr: u16) -> bool { [INFO] [stderr] 161 | | // FIXME Maybe replace the `bool` with something more type safe? [INFO] [stderr] 162 | | debug!("compile_instr ${:04X}", instr); [INFO] [stderr] 163 | | [INFO] [stderr] ... | [INFO] [stderr] 576 | | } [INFO] [stderr] 577 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reg.rs:30:27 [INFO] [stderr] | [INFO] [stderr] 30 | let variant = self.0 as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/reg.rs:46:31 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn as_reg_field_value(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/reg.rs:61:25 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn as_r32_value(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/reg.rs:71:23 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn other_half(&self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/reg.rs:91:28 [INFO] [stderr] | [INFO] [stderr] 91 | pub fn is_callee_saved(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/reg.rs:98:80 [INFO] [stderr] | [INFO] [stderr] 98 | } else if cfg!(all(target_family = "windows", target_arch = "x86_64")) { [INFO] [stderr] | ________________________________________________________________________________^ [INFO] [stderr] 99 | | // "The registers RBX, RBP, RDI, RSI, RSP, R12, R13, R14, and R15 are considered [INFO] [stderr] 100 | | // nonvolatile and must be saved and restored by a function that uses them." [INFO] [stderr] 101 | | match *self { [INFO] [stderr] ... | [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/reg.rs:92:70 [INFO] [stderr] | [INFO] [stderr] 92 | if cfg!(all(target_family = "unix", target_arch = "x86_64")) { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 93 | | // In the System V x64 ABI, `rbx`, `rbp` and `r12-r15` are callee-saved. [INFO] [stderr] 94 | | match *self { [INFO] [stderr] 95 | | X86Register::BH | X86Register::BL => true, [INFO] [stderr] 96 | | _ => false, [INFO] [stderr] 97 | | } [INFO] [stderr] 98 | | } else if cfg!(all(target_family = "windows", target_arch = "x86_64")) { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `chip-8`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/jit.rs:424:54 [INFO] [stderr] | [INFO] [stderr] 424 | self.emit_call(fptr, &[state as u64, x as u64, k as u64]); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/jit.rs:424:64 [INFO] [stderr] | [INFO] [stderr] 424 | self.emit_call(fptr, &[state as u64, x as u64, k as u64]); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/jit.rs:433:54 [INFO] [stderr] | [INFO] [stderr] 433 | self.emit_call(fptr, &[state as u64, x as u64, y as u64, n as u64]); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/jit.rs:433:64 [INFO] [stderr] | [INFO] [stderr] 433 | self.emit_call(fptr, &[state as u64, x as u64, y as u64, n as u64]); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/jit.rs:433:74 [INFO] [stderr] | [INFO] [stderr] 433 | self.emit_call(fptr, &[state as u64, x as u64, y as u64, n as u64]); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/jit.rs:442:54 [INFO] [stderr] | [INFO] [stderr] 442 | self.emit_call(fptr, &[state as u64, x as u64]); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/jit.rs:455:54 [INFO] [stderr] | [INFO] [stderr] 455 | self.emit_call(fptr, &[state as u64, x as u64]); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/jit.rs:476:54 [INFO] [stderr] | [INFO] [stderr] 476 | self.emit_call(fptr, &[state as u64, x as u64]); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/jit.rs:521:54 [INFO] [stderr] | [INFO] [stderr] 521 | self.emit_call(fptr, &[state as u64, x as u64]); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/jit.rs:531:54 [INFO] [stderr] | [INFO] [stderr] 531 | self.emit_call(fptr, &[state as u64, x as u64]); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/jit.rs:552:54 [INFO] [stderr] | [INFO] [stderr] 552 | self.emit_call(fptr, &[state as u64, x as u64]); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/jit.rs:569:54 [INFO] [stderr] | [INFO] [stderr] 569 | self.emit_call(fptr, &[state as u64, x as u64]); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reg.rs:30:27 [INFO] [stderr] | [INFO] [stderr] 30 | let variant = self.0 as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/reg.rs:46:31 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn as_reg_field_value(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/reg.rs:61:25 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn as_r32_value(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/reg.rs:71:23 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn other_half(&self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/reg.rs:91:28 [INFO] [stderr] | [INFO] [stderr] 91 | pub fn is_callee_saved(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/reg.rs:98:80 [INFO] [stderr] | [INFO] [stderr] 98 | } else if cfg!(all(target_family = "windows", target_arch = "x86_64")) { [INFO] [stderr] | ________________________________________________________________________________^ [INFO] [stderr] 99 | | // "The registers RBX, RBP, RDI, RSI, RSP, R12, R13, R14, and R15 are considered [INFO] [stderr] 100 | | // nonvolatile and must be saved and restored by a function that uses them." [INFO] [stderr] 101 | | match *self { [INFO] [stderr] ... | [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/reg.rs:92:70 [INFO] [stderr] | [INFO] [stderr] 92 | if cfg!(all(target_family = "unix", target_arch = "x86_64")) { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 93 | | // In the System V x64 ABI, `rbx`, `rbp` and `r12-r15` are callee-saved. [INFO] [stderr] 94 | | match *self { [INFO] [stderr] 95 | | X86Register::BH | X86Register::BL => true, [INFO] [stderr] 96 | | _ => false, [INFO] [stderr] 97 | | } [INFO] [stderr] 98 | | } else if cfg!(all(target_family = "windows", target_arch = "x86_64")) { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `chip-8`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "df679519eabd254042ffcd4e4869e17eff472ab52ba5c3c595b953981750d3e9"` [INFO] running `"docker" "rm" "-f" "df679519eabd254042ffcd4e4869e17eff472ab52ba5c3c595b953981750d3e9"` [INFO] [stdout] df679519eabd254042ffcd4e4869e17eff472ab52ba5c3c595b953981750d3e9