[INFO] updating cached repository jonas-schievink/cargo-tidy
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jonas-schievink/cargo-tidy
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jonas-schievink/cargo-tidy" "work/ex/clippy-test-run/sources/stable/gh/jonas-schievink/cargo-tidy"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jonas-schievink/cargo-tidy'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jonas-schievink/cargo-tidy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonas-schievink/cargo-tidy"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonas-schievink/cargo-tidy'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 87bc899d9c87f7da5c7ee9dbdf0fd938278d1e72
[INFO] sha for GitHub repo jonas-schievink/cargo-tidy: 87bc899d9c87f7da5c7ee9dbdf0fd938278d1e72
[INFO] validating manifest of jonas-schievink/cargo-tidy on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jonas-schievink/cargo-tidy on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jonas-schievink/cargo-tidy
[INFO] finished frobbing jonas-schievink/cargo-tidy
[INFO] frobbed toml for jonas-schievink/cargo-tidy written to work/ex/clippy-test-run/sources/stable/gh/jonas-schievink/cargo-tidy/Cargo.toml
[INFO] started frobbing jonas-schievink/cargo-tidy
[INFO] finished frobbing jonas-schievink/cargo-tidy
[INFO] frobbed toml for jonas-schievink/cargo-tidy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonas-schievink/cargo-tidy/Cargo.toml
[INFO] crate jonas-schievink/cargo-tidy has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jonas-schievink/cargo-tidy against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jonas-schievink/cargo-tidy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 39a81df0eea1a8a3205903065c0ce4b3ad30356ae5e4ba54077f879dabf3a94c
[INFO] running `"docker" "start" "-a" "39a81df0eea1a8a3205903065c0ce4b3ad30356ae5e4ba54077f879dabf3a94c"`
[INFO] [stderr]    Compiling quote v0.3.13
[INFO] [stderr]    Compiling synom v0.11.0
[INFO] [stderr]     Checking term_size v0.2.2
[INFO] [stderr]     Checking toml v0.3.0
[INFO] [stderr]     Checking thread_local v0.3.3
[INFO] [stderr]     Checking env_logger v0.3.5
[INFO] [stderr]     Checking clap v2.20.5
[INFO] [stderr]     Checking regex v0.2.1
[INFO] [stderr]    Compiling syn v0.11.6
[INFO] [stderr]    Compiling serde_codegen_internals v0.13.0
[INFO] [stderr]    Compiling serde_derive v0.9.7
[INFO] [stderr]     Checking cargo-tidy v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/check/mod.rs:72:13
[INFO] [stderr]    |
[INFO] [stderr] 72 |             msg: msg,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `msg`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/check/mod.rs:94:9
[INFO] [stderr]    |
[INFO] [stderr] 94 |         config: config,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: replace it with: `config`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/check/mod.rs:72:13
[INFO] [stderr]    |
[INFO] [stderr] 72 |             msg: msg,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `msg`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/check/mod.rs:94:9
[INFO] [stderr]    |
[INFO] [stderr] 94 |         config: config,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: replace it with: `config`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/check/indentation_style.rs:121:21
[INFO] [stderr]     |
[INFO] [stderr] 121 | /                     if *indent_kind != style.indent_kind {
[INFO] [stderr] 122 | |                         if indent_ch == indent_kind.as_char() {
[INFO] [stderr] 123 | |                             cx.error((lineno, 0),
[INFO] [stderr] 124 | |                                 format!("line is indented with {}, expected {}",
[INFO] [stderr] ...   |
[INFO] [stderr] 128 | |                         }
[INFO] [stderr] 129 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 121 |                     if *indent_kind != style.indent_kind && indent_ch == indent_kind.as_char() {
[INFO] [stderr] 122 |     cx.error((lineno, 0),
[INFO] [stderr] 123 |         format!("line is indented with {}, expected {}",
[INFO] [stderr] 124 |             indent_kind.name(),
[INFO] [stderr] 125 |             style.indent_kind.name()));
[INFO] [stderr] 126 |     break 'indent_char_loop;
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:26:24
[INFO] [stderr]    |
[INFO] [stderr] 26 | const DEFAULT_CONFIG: &'static str = ".cargo-tidy.toml";
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/check/indentation_style.rs:121:21
[INFO] [stderr]     |
[INFO] [stderr] 121 | /                     if *indent_kind != style.indent_kind {
[INFO] [stderr] 122 | |                         if indent_ch == indent_kind.as_char() {
[INFO] [stderr] 123 | |                             cx.error((lineno, 0),
[INFO] [stderr] 124 | |                                 format!("line is indented with {}, expected {}",
[INFO] [stderr] ...   |
[INFO] [stderr] 128 | |                         }
[INFO] [stderr] 129 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 121 |                     if *indent_kind != style.indent_kind && indent_ch == indent_kind.as_char() {
[INFO] [stderr] 122 |     cx.error((lineno, 0),
[INFO] [stderr] 123 |         format!("line is indented with {}, expected {}",
[INFO] [stderr] 124 |             indent_kind.name(),
[INFO] [stderr] 125 |             style.indent_kind.name()));
[INFO] [stderr] 126 |     break 'indent_char_loop;
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:26:24
[INFO] [stderr]    |
[INFO] [stderr] 26 | const DEFAULT_CONFIG: &'static str = ".cargo-tidy.toml";
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/check/mod.rs:89:42
[INFO] [stderr]    |
[INFO] [stderr] 89 |         lines_with_endings.push(&content[last_idx..idx+1]);
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^ help: use: `last_idx..=idx`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/config.rs:55:13
[INFO] [stderr]    |
[INFO] [stderr] 55 |         raw.unwrap_or(vec!["**/*.rs".to_string()])
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec!["**/*.rs".to_string()])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/config.rs:64:13
[INFO] [stderr]    |
[INFO] [stderr] 64 |         raw.unwrap_or(vec![])
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/config.rs:91:27
[INFO] [stderr]    |
[INFO] [stderr] 91 |         let regexes = raw.unwrap_or(vec![]);
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/check/mod.rs:89:42
[INFO] [stderr]    |
[INFO] [stderr] 89 |         lines_with_endings.push(&content[last_idx..idx+1]);
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^ help: use: `last_idx..=idx`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/config.rs:55:13
[INFO] [stderr]    |
[INFO] [stderr] 55 |         raw.unwrap_or(vec!["**/*.rs".to_string()])
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec!["**/*.rs".to_string()])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/config.rs:64:13
[INFO] [stderr]    |
[INFO] [stderr] 64 |         raw.unwrap_or(vec![])
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/config.rs:91:27
[INFO] [stderr]    |
[INFO] [stderr] 91 |         let regexes = raw.unwrap_or(vec![]);
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 20.34s
[INFO] running `"docker" "inspect" "39a81df0eea1a8a3205903065c0ce4b3ad30356ae5e4ba54077f879dabf3a94c"`
[INFO] running `"docker" "rm" "-f" "39a81df0eea1a8a3205903065c0ce4b3ad30356ae5e4ba54077f879dabf3a94c"`
[INFO] [stdout] 39a81df0eea1a8a3205903065c0ce4b3ad30356ae5e4ba54077f879dabf3a94c