[INFO] updating cached repository johnmcdnl/http_load [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/johnmcdnl/http_load [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/johnmcdnl/http_load" "work/ex/clippy-test-run/sources/stable/gh/johnmcdnl/http_load"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/johnmcdnl/http_load'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/johnmcdnl/http_load" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnmcdnl/http_load"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnmcdnl/http_load'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e64a5cea3d72424523015a90955d1534fe3f6902 [INFO] sha for GitHub repo johnmcdnl/http_load: e64a5cea3d72424523015a90955d1534fe3f6902 [INFO] validating manifest of johnmcdnl/http_load on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of johnmcdnl/http_load on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing johnmcdnl/http_load [INFO] finished frobbing johnmcdnl/http_load [INFO] frobbed toml for johnmcdnl/http_load written to work/ex/clippy-test-run/sources/stable/gh/johnmcdnl/http_load/Cargo.toml [INFO] started frobbing johnmcdnl/http_load [INFO] finished frobbing johnmcdnl/http_load [INFO] frobbed toml for johnmcdnl/http_load written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnmcdnl/http_load/Cargo.toml [INFO] crate johnmcdnl/http_load has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting johnmcdnl/http_load against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/johnmcdnl/http_load:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 020bbc644f951a70e206afab5d3b22722900c12f772b2b2035a60d01612decad [INFO] running `"docker" "start" "-a" "020bbc644f951a70e206afab5d3b22722900c12f772b2b2035a60d01612decad"` [INFO] [stderr] Checking http_load v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/hdr_histogram/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod hdr_histogram; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hdr_histogram/hdr_histogram.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return self.start_time; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.start_time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hdr_histogram/hdr_histogram.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | return self.end_time; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.end_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/hdr_histogram/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod hdr_histogram; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hdr_histogram/hdr_histogram.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return self.start_time; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.start_time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hdr_histogram/hdr_histogram.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | return self.end_time; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.end_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/hdr_histogram/hdr_histogram.rs:121:24 [INFO] [stderr] | [INFO] [stderr] 121 | let diff = if mean > *value { mean - value } else { value - mean } as u128; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(if mean > *value { mean - value } else { value - mean })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/hdr_histogram/hdr_histogram.rs:121:24 [INFO] [stderr] | [INFO] [stderr] 121 | let diff = if mean > *value { mean - value } else { value - mean } as u128; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(if mean > *value { mean - value } else { value - mean })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.90s [INFO] running `"docker" "inspect" "020bbc644f951a70e206afab5d3b22722900c12f772b2b2035a60d01612decad"` [INFO] running `"docker" "rm" "-f" "020bbc644f951a70e206afab5d3b22722900c12f772b2b2035a60d01612decad"` [INFO] [stdout] 020bbc644f951a70e206afab5d3b22722900c12f772b2b2035a60d01612decad