[INFO] updating cached repository johnkoehn/econ-sim [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/johnkoehn/econ-sim [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/johnkoehn/econ-sim" "work/ex/clippy-test-run/sources/stable/gh/johnkoehn/econ-sim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/johnkoehn/econ-sim'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/johnkoehn/econ-sim" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnkoehn/econ-sim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnkoehn/econ-sim'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6867684f2d04c483c108cc34c837d9ad2bc140bd [INFO] sha for GitHub repo johnkoehn/econ-sim: 6867684f2d04c483c108cc34c837d9ad2bc140bd [INFO] validating manifest of johnkoehn/econ-sim on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of johnkoehn/econ-sim on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing johnkoehn/econ-sim [INFO] finished frobbing johnkoehn/econ-sim [INFO] frobbed toml for johnkoehn/econ-sim written to work/ex/clippy-test-run/sources/stable/gh/johnkoehn/econ-sim/Cargo.toml [INFO] started frobbing johnkoehn/econ-sim [INFO] finished frobbing johnkoehn/econ-sim [INFO] frobbed toml for johnkoehn/econ-sim written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnkoehn/econ-sim/Cargo.toml [INFO] crate johnkoehn/econ-sim has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting johnkoehn/econ-sim against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/johnkoehn/econ-sim:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7792e7774006f0fdc866ccdc603deb3a9f88a3f9dbc9c9a6db93ece8f1053ca7 [INFO] running `"docker" "start" "-a" "7792e7774006f0fdc866ccdc603deb3a9f88a3f9dbc9c9a6db93ece8f1053ca7"` [INFO] [stderr] Checking econ-sim v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village/resource.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | resource_type: resource_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resource_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village/resource.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | resource_id: resource_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resource_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village/resource.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | collect_resource: collect_resource, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `collect_resource` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village/worker.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | worker_id: worker_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `worker_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village/worker.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | power: power, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `power` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village/mod.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | check_for_worker_death: check_for_worker_death, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `check_for_worker_death` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village/mod.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | resource_type: resource_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resource_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village/mod.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | collect_resource: collect_resource, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `collect_resource` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village_mind/trade_request.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | trade_type: trade_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `trade_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village_mind/trade_request.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | resource_type: resource_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resource_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village_mind/mod.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | village: village, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `village` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village/resource.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | resource_type: resource_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resource_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village/resource.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | resource_id: resource_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resource_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village/resource.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | collect_resource: collect_resource, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `collect_resource` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village/worker.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | worker_id: worker_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `worker_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village/worker.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | power: power, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `power` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village/mod.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | check_for_worker_death: check_for_worker_death, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `check_for_worker_death` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village/mod.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | resource_type: resource_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resource_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village/mod.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | collect_resource: collect_resource, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `collect_resource` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village_mind/trade_request.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | trade_type: trade_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `trade_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village_mind/trade_request.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | resource_type: resource_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resource_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/village_mind/mod.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | village: village, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `village` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `village_mind::*` [INFO] [stderr] --> src/simulation/mod.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | use village_mind::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `village::resource::*` [INFO] [stderr] --> src/simulation/mod.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | use village::resource::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `village_mind::trade_request::*` [INFO] [stderr] --> src/simulation/mod.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | use village_mind::trade_request::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `village::worker::*` [INFO] [stderr] --> src/village/mod.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | use village::worker::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `VillageManager` [INFO] [stderr] --> src/simulation/village_manager.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub struct VillageManager { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Upward` [INFO] [stderr] --> src/simulation/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Upward, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Downward` [INFO] [stderr] --> src/simulation/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | Downward, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Equilibrium` [INFO] [stderr] --> src/simulation/mod.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | Equilibrium, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Simulation` [INFO] [stderr] --> src/simulation/mod.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | pub struct Simulation { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/simulation/mod.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn new() -> Simulation { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add_village` [INFO] [stderr] --> src/simulation/mod.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn add_village(&mut self, village: Village) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `village_managers` [INFO] [stderr] --> src/simulation/mod.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn village_managers(&self) -> &Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `simulate` [INFO] [stderr] --> src/simulation/mod.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn simulate(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `handle_trades` [INFO] [stderr] --> src/simulation/mod.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn handle_trades(&mut self, trade_requests: &mut Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Gold` [INFO] [stderr] --> src/village/resource.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | Gold, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Food` [INFO] [stderr] --> src/village/resource.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | Food, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Wood` [INFO] [stderr] --> src/village/resource.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | Wood, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Stone` [INFO] [stderr] --> src/village/resource.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | Stone, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `iterator` [INFO] [stderr] --> src/village/resource.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn iterator() -> Iter<'static, ResourceType> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `RESOURCE_TYPES` [INFO] [stderr] --> src/village/resource.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | static RESOURCE_TYPES: [ResourceType; 4] = [Gold, Food, Wood, Stone]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `ResourceId` [INFO] [stderr] --> src/village/resource.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | pub type ResourceId = u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `CollectResource` [INFO] [stderr] --> src/village/resource.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | pub type CollectResource = fn(worker_power : u32) -> f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Resource` [INFO] [stderr] --> src/village/resource.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | pub struct Resource { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/village/resource.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn new(resource_type : ResourceType, resource_id : ResourceId, collect_resource : CollectResource) -> Resource { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `WorkerId` [INFO] [stderr] --> src/village/worker.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub type WorkerId = u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Worker` [INFO] [stderr] --> src/village/worker.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub struct Worker { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/village/worker.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn new(worker_id: WorkerId, power: u32) -> Worker { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `VillageRef` [INFO] [stderr] --> src/village/mod.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub type VillageRef = Rc>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `CheckForWorkerDeath` [INFO] [stderr] --> src/village/mod.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | pub type CheckForWorkerDeath = fn(&Worker) -> bool; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Village` [INFO] [stderr] --> src/village/mod.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | pub struct Village { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/village/mod.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn new(check_for_worker_death: CheckForWorkerDeath) -> Village { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `create_worker` [INFO] [stderr] --> src/village/mod.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn create_worker(&mut self, power: u32) -> WorkerId { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `create_resource` [INFO] [stderr] --> src/village/mod.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn create_resource(&mut self, resource_type: ResourceType, collect_resource: CollectResource) -> ResourceId { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `assign_worker` [INFO] [stderr] --> src/village/mod.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn assign_worker(&mut self, worker_id: WorkerId, resource_id: ResourceId) -> Result<(), &'static str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `resource` [INFO] [stderr] --> src/village/mod.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn resource(&self, resource_id: ResourceId) -> Option<&Resource> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `resources_of_type` [INFO] [stderr] --> src/village/mod.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | pub fn resources_of_type(&self, resource_type: ResourceType) -> Vec<&Resource> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `resources` [INFO] [stderr] --> src/village/mod.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn resources(&self) -> &Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `idle_worker_count` [INFO] [stderr] --> src/village/mod.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | pub fn idle_worker_count(&self) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `worker` [INFO] [stderr] --> src/village/mod.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | pub fn worker(&self, worker_id: WorkerId) -> Option<&Worker> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `workers_on_resource` [INFO] [stderr] --> src/village/mod.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | pub fn workers_on_resource(&self, resource_id: u32) -> Vec<&Worker> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `power_on_resource` [INFO] [stderr] --> src/village/mod.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | pub fn power_on_resource(&self, resource_id: u32) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `simulate` [INFO] [stderr] --> src/village/mod.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn simulate(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Buy` [INFO] [stderr] --> src/village_mind/trade_request.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | Buy, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Sell` [INFO] [stderr] --> src/village_mind/trade_request.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | Sell, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `TradeRequest` [INFO] [stderr] --> src/village_mind/trade_request.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | pub struct TradeRequest { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/village_mind/trade_request.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn new(trade_type: TradeType, amount: u32, resource_type: ResourceType) -> TradeRequest{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `VillageMind` [INFO] [stderr] --> src/village_mind/mod.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub struct VillageMind { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/village_mind/mod.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn new(village: VillageRef) -> VillageMind { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `trade` [INFO] [stderr] --> src/village_mind/mod.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn trade(&mut self) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `manage_village` [INFO] [stderr] --> src/village_mind/mod.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn manage_village(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `villageRC` should have a snake case name such as `village_rc` [INFO] [stderr] --> src/simulation/mod.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | let villageRC = Rc::new(RefCell::new(village)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/simulation/mod.rs:76:16 [INFO] [stderr] | [INFO] [stderr] 76 | if trade_requests.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `trade_requests.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:110:40 [INFO] [stderr] | [INFO] [stderr] 110 | let price_direction = *self.price_directions.get(resource_type).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.price_directions[resource_type]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/simulation/mod.rs:134:32 [INFO] [stderr] | [INFO] [stderr] 134 | if sells <= 0 { break; } [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using sells == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:143:40 [INFO] [stderr] | [INFO] [stderr] 143 | let price_direction = *self.price_directions.get(resource_type).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.price_directions[resource_type]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/simulation/mod.rs:167:32 [INFO] [stderr] | [INFO] [stderr] 167 | if buys <= 0 {break;} [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using buys == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/village/resource.rs:15:24 [INFO] [stderr] | [INFO] [stderr] 15 | RESOURCE_TYPES.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/village/mod.rs:38:54 [INFO] [stderr] | [INFO] [stderr] 38 | village.stockpile.insert(*resource_type, 0 as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `econ-sim`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `w` [INFO] [stderr] --> src/simulation/mod.rs:187:23 [INFO] [stderr] | [INFO] [stderr] 187 | Village::new(|w: &worker::Worker| false) [INFO] [stderr] | ^ help: consider using `_w` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `w` [INFO] [stderr] --> src/village/mod.rs:143:23 [INFO] [stderr] | [INFO] [stderr] 143 | Village::new(|w: &Worker| false) [INFO] [stderr] | ^ help: consider using `_w` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `w` [INFO] [stderr] --> src/village_mind/mod.rs:38:44 [INFO] [stderr] | [INFO] [stderr] 38 | Rc::new(RefCell::new(Village::new(|w: &Worker| false))) [INFO] [stderr] | ^ help: consider using `_w` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/village/mod.rs:278:57 [INFO] [stderr] | [INFO] [stderr] 278 | let r1 = v.create_resource(ResourceType::Wood, |x| 2 as f64); [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r1` [INFO] [stderr] --> src/village/mod.rs:278:13 [INFO] [stderr] | [INFO] [stderr] 278 | let r1 = v.create_resource(ResourceType::Wood, |x| 2 as f64); [INFO] [stderr] | ^^ help: consider using `_r1` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/simulation/mod.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | let mut simulation = Simulation::new(); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/simulation/mod.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | let mut simulation = Simulation::new(); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `simulate` [INFO] [stderr] --> src/simulation/mod.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn simulate(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/village/resource.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn new(resource_type : ResourceType, resource_id : ResourceId, collect_resource : CollectResource) -> Resource { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `resource` [INFO] [stderr] --> src/village/mod.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn resource(&self, resource_id: ResourceId) -> Option<&Resource> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `village` [INFO] [stderr] --> src/village_mind/mod.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | village: VillageRef, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `manage_village` [INFO] [stderr] --> src/village_mind/mod.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn manage_village(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `villageRC` should have a snake case name such as `village_rc` [INFO] [stderr] --> src/simulation/mod.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | let villageRC = Rc::new(RefCell::new(village)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/simulation/mod.rs:76:16 [INFO] [stderr] | [INFO] [stderr] 76 | if trade_requests.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `trade_requests.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:110:40 [INFO] [stderr] | [INFO] [stderr] 110 | let price_direction = *self.price_directions.get(resource_type).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.price_directions[resource_type]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/simulation/mod.rs:134:32 [INFO] [stderr] | [INFO] [stderr] 134 | if sells <= 0 { break; } [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using sells == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:143:40 [INFO] [stderr] | [INFO] [stderr] 143 | let price_direction = *self.price_directions.get(resource_type).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.price_directions[resource_type]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/simulation/mod.rs:167:32 [INFO] [stderr] | [INFO] [stderr] 167 | if buys <= 0 {break;} [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using buys == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:202:24 [INFO] [stderr] | [INFO] [stderr] 202 | assert_eq!(5, *simulation.prices.get(&ResourceType::Food).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&simulation.prices[&ResourceType::Food]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:209:50 [INFO] [stderr] | [INFO] [stderr] 209 | assert_eq!(PriceDirection::Equilibrium, *simulation.price_directions.get(&ResourceType::Food).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&simulation.price_directions[&ResourceType::Food]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:220:23 [INFO] [stderr] | [INFO] [stderr] 220 | assert_eq!(1, trade_requests.get(0).unwrap().fulfilled_amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&trade_requests[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:221:23 [INFO] [stderr] | [INFO] [stderr] 221 | assert_eq!(1, trade_requests.get(1).unwrap().fulfilled_amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&trade_requests[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:222:50 [INFO] [stderr] | [INFO] [stderr] 222 | assert_eq!(PriceDirection::Equilibrium, *simulation.price_directions.get(&ResourceType::Food).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&simulation.price_directions[&ResourceType::Food]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:232:23 [INFO] [stderr] | [INFO] [stderr] 232 | assert_eq!(0, trade_requests.get(0).unwrap().fulfilled_amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&trade_requests[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:233:45 [INFO] [stderr] | [INFO] [stderr] 233 | assert_eq!(PriceDirection::Upward, *simulation.price_directions.get(&ResourceType::Food).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&simulation.price_directions[&ResourceType::Food]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:234:24 [INFO] [stderr] | [INFO] [stderr] 234 | assert_eq!(6, *simulation.prices.get(&ResourceType::Food).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&simulation.prices[&ResourceType::Food]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:244:23 [INFO] [stderr] | [INFO] [stderr] 244 | assert_eq!(0, trade_requests.get(0).unwrap().fulfilled_amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&trade_requests[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:245:47 [INFO] [stderr] | [INFO] [stderr] 245 | assert_eq!(PriceDirection::Downward, *simulation.price_directions.get(&ResourceType::Food).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&simulation.price_directions[&ResourceType::Food]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:246:24 [INFO] [stderr] | [INFO] [stderr] 246 | assert_eq!(4, *simulation.prices.get(&ResourceType::Food).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&simulation.prices[&ResourceType::Food]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:261:23 [INFO] [stderr] | [INFO] [stderr] 261 | assert_eq!(1, trade_requests.get(0).unwrap().fulfilled_amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&trade_requests[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:262:23 [INFO] [stderr] | [INFO] [stderr] 262 | assert_eq!(1, trade_requests.get(1).unwrap().fulfilled_amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&trade_requests[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:263:50 [INFO] [stderr] | [INFO] [stderr] 263 | assert_eq!(PriceDirection::Equilibrium, *simulation.price_directions.get(&ResourceType::Food).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&simulation.price_directions[&ResourceType::Food]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:264:24 [INFO] [stderr] | [INFO] [stderr] 264 | assert_eq!(2, *simulation.prices.get(&ResourceType::Food).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&simulation.prices[&ResourceType::Food]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:279:23 [INFO] [stderr] | [INFO] [stderr] 279 | assert_eq!(1, trade_requests.get(0).unwrap().fulfilled_amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&trade_requests[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:280:23 [INFO] [stderr] | [INFO] [stderr] 280 | assert_eq!(1, trade_requests.get(1).unwrap().fulfilled_amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&trade_requests[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:281:50 [INFO] [stderr] | [INFO] [stderr] 281 | assert_eq!(PriceDirection::Equilibrium, *simulation.price_directions.get(&ResourceType::Food).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&simulation.price_directions[&ResourceType::Food]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:282:24 [INFO] [stderr] | [INFO] [stderr] 282 | assert_eq!(8, *simulation.prices.get(&ResourceType::Food).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&simulation.prices[&ResourceType::Food]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:298:23 [INFO] [stderr] | [INFO] [stderr] 298 | assert_eq!(1, trade_requests.get(0).unwrap().fulfilled_amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&trade_requests[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:299:23 [INFO] [stderr] | [INFO] [stderr] 299 | assert_eq!(1, trade_requests.get(1).unwrap().fulfilled_amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&trade_requests[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:300:50 [INFO] [stderr] | [INFO] [stderr] 300 | assert_eq!(PriceDirection::Equilibrium, *simulation.price_directions.get(&ResourceType::Food).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&simulation.price_directions[&ResourceType::Food]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:301:24 [INFO] [stderr] | [INFO] [stderr] 301 | assert_eq!(1, *simulation.prices.get(&ResourceType::Food).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&simulation.prices[&ResourceType::Food]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/simulation/mod.rs:314:50 [INFO] [stderr] | [INFO] [stderr] 314 | assert_eq!(PriceDirection::Equilibrium, *simulation.price_directions.get(&ResourceType::Food).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&simulation.price_directions[&ResourceType::Food]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/village/resource.rs:15:24 [INFO] [stderr] | [INFO] [stderr] 15 | RESOURCE_TYPES.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/village/mod.rs:38:54 [INFO] [stderr] | [INFO] [stderr] 38 | village.stockpile.insert(*resource_type, 0 as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/village/mod.rs:151:18 [INFO] [stderr] | [INFO] [stderr] 151 | move |x| x as f64 [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/village/mod.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | v.assign_worker(w1, r1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/village/mod.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | v.assign_worker(w1, r1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/village/mod.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | v.assign_worker(w1, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/village/mod.rs:220:9 [INFO] [stderr] | [INFO] [stderr] 220 | v.assign_worker(w1, r1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/village/mod.rs:221:9 [INFO] [stderr] | [INFO] [stderr] 221 | v.assign_worker(w2, r1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/village/mod.rs:224:24 [INFO] [stderr] | [INFO] [stderr] 224 | assert_eq!(2, *v.stockpile.get(&ResourceType::Wood).unwrap() as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&v.stockpile[&ResourceType::Wood]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/village/mod.rs:278:60 [INFO] [stderr] | [INFO] [stderr] 278 | let r1 = v.create_resource(ResourceType::Wood, |x| 2 as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/village/mod.rs:281:24 [INFO] [stderr] | [INFO] [stderr] 281 | assert_eq!(2, *v.stockpile.get(&ResourceType::Wood).unwrap() as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&v.stockpile[&ResourceType::Wood]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `econ-sim`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7792e7774006f0fdc866ccdc603deb3a9f88a3f9dbc9c9a6db93ece8f1053ca7"` [INFO] running `"docker" "rm" "-f" "7792e7774006f0fdc866ccdc603deb3a9f88a3f9dbc9c9a6db93ece8f1053ca7"` [INFO] [stdout] 7792e7774006f0fdc866ccdc603deb3a9f88a3f9dbc9c9a6db93ece8f1053ca7