[INFO] updating cached repository johnf9896/onyx
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/johnf9896/onyx
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/johnf9896/onyx" "work/ex/clippy-test-run/sources/stable/gh/johnf9896/onyx"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/johnf9896/onyx'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/johnf9896/onyx" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnf9896/onyx"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnf9896/onyx'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 1581060c1900728d8e3703319ddd0b0d9e5d6d4c
[INFO] sha for GitHub repo johnf9896/onyx: 1581060c1900728d8e3703319ddd0b0d9e5d6d4c
[INFO] validating manifest of johnf9896/onyx on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of johnf9896/onyx on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing johnf9896/onyx
[INFO] finished frobbing johnf9896/onyx
[INFO] frobbed toml for johnf9896/onyx written to work/ex/clippy-test-run/sources/stable/gh/johnf9896/onyx/Cargo.toml
[INFO] started frobbing johnf9896/onyx
[INFO] finished frobbing johnf9896/onyx
[INFO] frobbed toml for johnf9896/onyx written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnf9896/onyx/Cargo.toml
[INFO] crate johnf9896/onyx has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting johnf9896/onyx against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/johnf9896/onyx:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d933c72499b7e2ab3a5df322a70cb23158339bb39ec1fe7200ddfe276f7d3d0b
[INFO] running `"docker" "start" "-a" "d933c72499b7e2ab3a5df322a70cb23158339bb39ec1fe7200ddfe276f7d3d0b"`
[INFO] [stderr]     Checking clicolors-control v0.3.0
[INFO] [stderr]     Checking termios v0.3.1
[INFO] [stderr]     Checking nix v0.5.1
[INFO] [stderr]     Checking serde_yaml v0.8.7
[INFO] [stderr]    Compiling structopt-derive v0.2.13
[INFO] [stderr]     Checking regex v0.2.11
[INFO] [stderr]     Checking env_logger v0.5.13
[INFO] [stderr]     Checking console v0.7.0
[INFO] [stderr]     Checking indicatif v0.9.0
[INFO] [stderr]     Checking structopt v0.2.13
[INFO] [stderr]     Checking clap-verbosity-flag v0.1.0
[INFO] [stderr]     Checking rustyline v1.0.0
[INFO] [stderr]     Checking promptly v0.1.5
[INFO] [stderr]     Checking quicli v0.3.1
[INFO] [stderr]     Checking onyx v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/project.rs:132:22
[INFO] [stderr]     |
[INFO] [stderr] 132 |     pub fn new(name: &String) -> Self {
[INFO] [stderr]     |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]    --> src/project.rs:396:17
[INFO] [stderr]     |
[INFO] [stderr] 396 | /                 self.valid
[INFO] [stderr] 397 | |                     .iter()
[INFO] [stderr] 398 | |                     .find(|RunnerEntry { long, short }| def.long == *long || def.short == *short)
[INFO] [stderr] 399 | |                     .is_some(),
[INFO] [stderr]     | |______________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::search_is_some)] on by default
[INFO] [stderr]     = note: replace `find(|RunnerEntry { long, short }| def.long == *long || def.short == *short).is_some()` with `any(|RunnerEntry { long, short }| def.long == *long || def.short == *short)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/project.rs:477:35
[INFO] [stderr]     |
[INFO] [stderr] 477 |                 let short = short.unwrap_or(long.clone());
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| long.clone())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/project.rs:582:5
[INFO] [stderr]     |
[INFO] [stderr] 582 |     output.write(serialized.as_bytes())?;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/project.rs:586:8
[INFO] [stderr]     |
[INFO] [stderr] 586 |     if project.include.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!project.include.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/project.rs:606:13
[INFO] [stderr]     |
[INFO] [stderr] 606 |             output.write(serialized.as_bytes())?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `onyx`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/project.rs:132:22
[INFO] [stderr]     |
[INFO] [stderr] 132 |     pub fn new(name: &String) -> Self {
[INFO] [stderr]     |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]    --> src/project.rs:396:17
[INFO] [stderr]     |
[INFO] [stderr] 396 | /                 self.valid
[INFO] [stderr] 397 | |                     .iter()
[INFO] [stderr] 398 | |                     .find(|RunnerEntry { long, short }| def.long == *long || def.short == *short)
[INFO] [stderr] 399 | |                     .is_some(),
[INFO] [stderr]     | |______________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::search_is_some)] on by default
[INFO] [stderr]     = note: replace `find(|RunnerEntry { long, short }| def.long == *long || def.short == *short).is_some()` with `any(|RunnerEntry { long, short }| def.long == *long || def.short == *short)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/project.rs:477:35
[INFO] [stderr]     |
[INFO] [stderr] 477 |                 let short = short.unwrap_or(long.clone());
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| long.clone())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/project.rs:582:5
[INFO] [stderr]     |
[INFO] [stderr] 582 |     output.write(serialized.as_bytes())?;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/project.rs:586:8
[INFO] [stderr]     |
[INFO] [stderr] 586 |     if project.include.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!project.include.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/project.rs:606:13
[INFO] [stderr]     |
[INFO] [stderr] 606 |             output.write(serialized.as_bytes())?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `onyx`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "d933c72499b7e2ab3a5df322a70cb23158339bb39ec1fe7200ddfe276f7d3d0b"`
[INFO] running `"docker" "rm" "-f" "d933c72499b7e2ab3a5df322a70cb23158339bb39ec1fe7200ddfe276f7d3d0b"`
[INFO] [stdout] d933c72499b7e2ab3a5df322a70cb23158339bb39ec1fe7200ddfe276f7d3d0b