[INFO] updating cached repository johnedmonds/entity-diff [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/johnedmonds/entity-diff [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/johnedmonds/entity-diff" "work/ex/clippy-test-run/sources/stable/gh/johnedmonds/entity-diff"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/johnedmonds/entity-diff'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/johnedmonds/entity-diff" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnedmonds/entity-diff"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnedmonds/entity-diff'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6ddeb9ab72ac174ddae32036d237700f142af2fc [INFO] sha for GitHub repo johnedmonds/entity-diff: 6ddeb9ab72ac174ddae32036d237700f142af2fc [INFO] validating manifest of johnedmonds/entity-diff on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of johnedmonds/entity-diff on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing johnedmonds/entity-diff [INFO] finished frobbing johnedmonds/entity-diff [INFO] frobbed toml for johnedmonds/entity-diff written to work/ex/clippy-test-run/sources/stable/gh/johnedmonds/entity-diff/Cargo.toml [INFO] started frobbing johnedmonds/entity-diff [INFO] finished frobbing johnedmonds/entity-diff [INFO] frobbed toml for johnedmonds/entity-diff written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnedmonds/entity-diff/Cargo.toml [INFO] crate johnedmonds/entity-diff has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting johnedmonds/entity-diff against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/johnedmonds/entity-diff:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] da7de5b86edc6163940e144e12805529184fefe4f7eb448e98aee8f703b4bc06 [INFO] running `"docker" "start" "-a" "da7de5b86edc6163940e144e12805529184fefe4f7eb448e98aee8f703b4bc06"` [INFO] [stderr] Checking entity-diff v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | return path; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | return grid[a.len()][b.len()].borrow().path(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `grid[a.len()][b.len()].borrow().path()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / return (0..b.len() + 1).map(|_b| { [INFO] [stderr] 54 | | return Rc::new(RefCell::new(GridSquare{ [INFO] [stderr] 55 | | cost: 0, [INFO] [stderr] 56 | | from: None, [INFO] [stderr] 57 | | edit: Edit::Keep [INFO] [stderr] 58 | | })); [INFO] [stderr] 59 | | }).collect::>>>>(); [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 53 | (0..b.len() + 1).map(|_b| { [INFO] [stderr] 54 | return Rc::new(RefCell::new(GridSquare{ [INFO] [stderr] 55 | cost: 0, [INFO] [stderr] 56 | from: None, [INFO] [stderr] 57 | edit: Edit::Keep [INFO] [stderr] 58 | })); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | / return Rc::new(RefCell::new(GridSquare{ [INFO] [stderr] 55 | | cost: 0, [INFO] [stderr] 56 | | from: None, [INFO] [stderr] 57 | | edit: Edit::Keep [INFO] [stderr] 58 | | })); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 54 | Rc::new(RefCell::new(GridSquare{ [INFO] [stderr] 55 | cost: 0, [INFO] [stderr] 56 | from: None, [INFO] [stderr] 57 | edit: Edit::Keep [INFO] [stderr] 58 | })) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | return path; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | return grid[a.len()][b.len()].borrow().path(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `grid[a.len()][b.len()].borrow().path()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / return (0..b.len() + 1).map(|_b| { [INFO] [stderr] 54 | | return Rc::new(RefCell::new(GridSquare{ [INFO] [stderr] 55 | | cost: 0, [INFO] [stderr] 56 | | from: None, [INFO] [stderr] 57 | | edit: Edit::Keep [INFO] [stderr] 58 | | })); [INFO] [stderr] 59 | | }).collect::>>>>(); [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 53 | (0..b.len() + 1).map(|_b| { [INFO] [stderr] 54 | return Rc::new(RefCell::new(GridSquare{ [INFO] [stderr] 55 | cost: 0, [INFO] [stderr] 56 | from: None, [INFO] [stderr] 57 | edit: Edit::Keep [INFO] [stderr] 58 | })); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | / return Rc::new(RefCell::new(GridSquare{ [INFO] [stderr] 55 | | cost: 0, [INFO] [stderr] 56 | | from: None, [INFO] [stderr] 57 | | edit: Edit::Keep [INFO] [stderr] 58 | | })); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 54 | Rc::new(RefCell::new(GridSquare{ [INFO] [stderr] 55 | cost: 0, [INFO] [stderr] 56 | from: None, [INFO] [stderr] 57 | edit: Edit::Keep [INFO] [stderr] 58 | })) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / self.from.as_ref().map(|from| { [INFO] [stderr] 40 | | let rc = from.upgrade().unwrap(); [INFO] [stderr] 41 | | let mut path: Vec> = rc.borrow().path(); [INFO] [stderr] 42 | | path.push(self.edit.clone()); [INFO] [stderr] 43 | | return path; [INFO] [stderr] 44 | | }).unwrap_or(Vec::new()) [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 39 | self.from.as_ref().map(|from| { [INFO] [stderr] 40 | let rc = from.upgrade().unwrap(); [INFO] [stderr] 41 | let mut path: Vec> = rc.borrow().path(); [INFO] [stderr] 42 | path.push(self.edit.clone()); [INFO] [stderr] 43 | return path; [INFO] [stderr] 44 | }).unwrap_or_default() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:51:27 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn diff<'a, T: Eq>(a: &'a Vec, b: &'a Vec) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:51:42 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn diff<'a, T: Eq>(a: &'a Vec, b: &'a Vec) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:52:58 [INFO] [stderr] | [INFO] [stderr] 52 | let grid: Vec>>>> = (0..a.len() + 1).map(|_a| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(0..=a.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:53:16 [INFO] [stderr] | [INFO] [stderr] 53 | return (0..b.len() + 1).map(|_b| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(0..=b.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | for i in 1..a.len() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=a.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:69:14 [INFO] [stderr] | [INFO] [stderr] 69 | for j in 1..b.len() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=b.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:76:14 [INFO] [stderr] | [INFO] [stderr] 76 | for i in 1..a.len() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=a.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:77:18 [INFO] [stderr] | [INFO] [stderr] 77 | for j in 1..b.len() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=b.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / self.from.as_ref().map(|from| { [INFO] [stderr] 40 | | let rc = from.upgrade().unwrap(); [INFO] [stderr] 41 | | let mut path: Vec> = rc.borrow().path(); [INFO] [stderr] 42 | | path.push(self.edit.clone()); [INFO] [stderr] 43 | | return path; [INFO] [stderr] 44 | | }).unwrap_or(Vec::new()) [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 39 | self.from.as_ref().map(|from| { [INFO] [stderr] 40 | let rc = from.upgrade().unwrap(); [INFO] [stderr] 41 | let mut path: Vec> = rc.borrow().path(); [INFO] [stderr] 42 | path.push(self.edit.clone()); [INFO] [stderr] 43 | return path; [INFO] [stderr] 44 | }).unwrap_or_default() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:51:27 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn diff<'a, T: Eq>(a: &'a Vec, b: &'a Vec) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:51:42 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn diff<'a, T: Eq>(a: &'a Vec, b: &'a Vec) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:52:58 [INFO] [stderr] | [INFO] [stderr] 52 | let grid: Vec>>>> = (0..a.len() + 1).map(|_a| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(0..=a.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:53:16 [INFO] [stderr] | [INFO] [stderr] 53 | return (0..b.len() + 1).map(|_b| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(0..=b.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | for i in 1..a.len() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=a.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:69:14 [INFO] [stderr] | [INFO] [stderr] 69 | for j in 1..b.len() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=b.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:76:14 [INFO] [stderr] | [INFO] [stderr] 76 | for i in 1..a.len() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=a.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:77:18 [INFO] [stderr] | [INFO] [stderr] 77 | for j in 1..b.len() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=b.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.74s [INFO] running `"docker" "inspect" "da7de5b86edc6163940e144e12805529184fefe4f7eb448e98aee8f703b4bc06"` [INFO] running `"docker" "rm" "-f" "da7de5b86edc6163940e144e12805529184fefe4f7eb448e98aee8f703b4bc06"` [INFO] [stdout] da7de5b86edc6163940e144e12805529184fefe4f7eb448e98aee8f703b4bc06