[INFO] updating cached repository johnboy14/hack_vm_translator
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/johnboy14/hack_vm_translator
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/johnboy14/hack_vm_translator" "work/ex/clippy-test-run/sources/stable/gh/johnboy14/hack_vm_translator"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/johnboy14/hack_vm_translator'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/johnboy14/hack_vm_translator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnboy14/hack_vm_translator"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnboy14/hack_vm_translator'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 7b631ae0c09bd9a519e0463f6866fe1ea3f3dcfc
[INFO] sha for GitHub repo johnboy14/hack_vm_translator: 7b631ae0c09bd9a519e0463f6866fe1ea3f3dcfc
[INFO] validating manifest of johnboy14/hack_vm_translator on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of johnboy14/hack_vm_translator on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing johnboy14/hack_vm_translator
[INFO] finished frobbing johnboy14/hack_vm_translator
[INFO] frobbed toml for johnboy14/hack_vm_translator written to work/ex/clippy-test-run/sources/stable/gh/johnboy14/hack_vm_translator/Cargo.toml
[INFO] started frobbing johnboy14/hack_vm_translator
[INFO] finished frobbing johnboy14/hack_vm_translator
[INFO] frobbed toml for johnboy14/hack_vm_translator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnboy14/hack_vm_translator/Cargo.toml
[INFO] crate johnboy14/hack_vm_translator has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting johnboy14/hack_vm_translator against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/johnboy14/hack_vm_translator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7962b1dba8bdd1620ff83e5677e09814e5bb4a8220def78111062bddcf6c11cc
[INFO] running `"docker" "start" "-a" "7962b1dba8bdd1620ff83e5677e09814e5bb4a8220def78111062bddcf6c11cc"`
[INFO] [stderr]     Checking hack_vm_translator v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:70:22
[INFO] [stderr]    |
[INFO] [stderr] 70 |     return VMCommand{command_type: command_type, arg1: arg1, arg2: arg2};
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_type`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:70:50
[INFO] [stderr]    |
[INFO] [stderr] 70 |     return VMCommand{command_type: command_type, arg1: arg1, arg2: arg2};
[INFO] [stderr]    |                                                  ^^^^^^^^^^ help: replace it with: `arg1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:70:62
[INFO] [stderr]    |
[INFO] [stderr] 70 |     return VMCommand{command_type: command_type, arg1: arg1, arg2: arg2};
[INFO] [stderr]    |                                                              ^^^^^^^^^^ help: replace it with: `arg2`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:70:22
[INFO] [stderr]    |
[INFO] [stderr] 70 |     return VMCommand{command_type: command_type, arg1: arg1, arg2: arg2};
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_type`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:70:50
[INFO] [stderr]    |
[INFO] [stderr] 70 |     return VMCommand{command_type: command_type, arg1: arg1, arg2: arg2};
[INFO] [stderr]    |                                                  ^^^^^^^^^^ help: replace it with: `arg1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:70:62
[INFO] [stderr]    |
[INFO] [stderr] 70 |     return VMCommand{command_type: command_type, arg1: arg1, arg2: arg2};
[INFO] [stderr]    |                                                              ^^^^^^^^^^ help: replace it with: `arg2`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/file.rs:32:20
[INFO] [stderr]    |
[INFO] [stderr] 32 |               } else {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 33 | |                 if let Some(e) = ext_from_path(&path) {
[INFO] [stderr] 34 | |                     if ext_match(ext, &e) {
[INFO] [stderr] 35 | |                         push_fn(entry.path(), buf);
[INFO] [stderr] ...  |
[INFO] [stderr] 38 | |
[INFO] [stderr] 39 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 32 |             } else if let Some(e) = ext_from_path(&path) {
[INFO] [stderr] 33 |     if ext_match(ext, &e) {
[INFO] [stderr] 34 |         push_fn(entry.path(), buf);
[INFO] [stderr] 35 |     }
[INFO] [stderr] 36 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:70:5
[INFO] [stderr]    |
[INFO] [stderr] 70 |     return VMCommand{command_type: command_type, arg1: arg1, arg2: arg2};
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `VMCommand{command_type: command_type, arg1: arg1, arg2: arg2}`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/writer.rs:4:24
[INFO] [stderr]   |
[INFO] [stderr] 4 | const  STACK_POINTER: &'static str = "@SP";
[INFO] [stderr]   |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/file.rs:32:20
[INFO] [stderr]    |
[INFO] [stderr] 32 |               } else {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 33 | |                 if let Some(e) = ext_from_path(&path) {
[INFO] [stderr] 34 | |                     if ext_match(ext, &e) {
[INFO] [stderr] 35 | |                         push_fn(entry.path(), buf);
[INFO] [stderr] ...  |
[INFO] [stderr] 38 | |
[INFO] [stderr] 39 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 32 |             } else if let Some(e) = ext_from_path(&path) {
[INFO] [stderr] 33 |     if ext_match(ext, &e) {
[INFO] [stderr] 34 |         push_fn(entry.path(), buf);
[INFO] [stderr] 35 |     }
[INFO] [stderr] 36 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:70:5
[INFO] [stderr]    |
[INFO] [stderr] 70 |     return VMCommand{command_type: command_type, arg1: arg1, arg2: arg2};
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `VMCommand{command_type: command_type, arg1: arg1, arg2: arg2}`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/writer.rs:4:24
[INFO] [stderr]   |
[INFO] [stderr] 4 | const  STACK_POINTER: &'static str = "@SP";
[INFO] [stderr]   |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/parser.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 |     let mut file = try!(File::open(vm_file));
[INFO] [stderr]    |         ----^^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `C_LABEL`
[INFO] [stderr]   --> src/parser.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     C_LABEL,
[INFO] [stderr]    |     ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `C_GOTO`
[INFO] [stderr]   --> src/parser.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     C_GOTO,
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `C_IF`
[INFO] [stderr]   --> src/parser.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 |     C_IF,
[INFO] [stderr]    |     ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `C_FUNCTION`
[INFO] [stderr]   --> src/parser.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 |     C_FUNCTION,
[INFO] [stderr]    |     ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `C_RETURN`
[INFO] [stderr]   --> src/parser.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 |     C_RETURN,
[INFO] [stderr]    |     ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `C_CALL`
[INFO] [stderr]   --> src/parser.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 |     C_CALL
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/file.rs:6:1
[INFO] [stderr]    |
[INFO] [stderr] 6  | / fn ext_from_path<'a>(path: &'a Path) -> Option<&'a OsStr> {
[INFO] [stderr] 7  | |     match path.extension() {
[INFO] [stderr] 8  | |         Some(ext) => Some(ext),
[INFO] [stderr] 9  | |         None => None
[INFO] [stderr] 10 | |     }
[INFO] [stderr] 11 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: variant `C_ARITHMETIC` should have a camel case name such as `CArithmetic`
[INFO] [stderr]   --> src/parser.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     C_ARITHMETIC,
[INFO] [stderr]    |     ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_camel_case_types)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant `C_PUSH` should have a camel case name such as `CPush`
[INFO] [stderr]   --> src/parser.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 |     C_PUSH,
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant `C_POP` should have a camel case name such as `CPop`
[INFO] [stderr]   --> src/parser.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 |     C_POP,
[INFO] [stderr]    |     ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant `C_LABEL` should have a camel case name such as `CLabel`
[INFO] [stderr]   --> src/parser.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     C_LABEL,
[INFO] [stderr]    |     ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant `C_GOTO` should have a camel case name such as `CGoto`
[INFO] [stderr]   --> src/parser.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     C_GOTO,
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant `C_IF` should have a camel case name such as `CIf`
[INFO] [stderr]   --> src/parser.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 |     C_IF,
[INFO] [stderr]    |     ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant `C_FUNCTION` should have a camel case name such as `CFunction`
[INFO] [stderr]   --> src/parser.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 |     C_FUNCTION,
[INFO] [stderr]    |     ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant `C_RETURN` should have a camel case name such as `CReturn`
[INFO] [stderr]   --> src/parser.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 |     C_RETURN,
[INFO] [stderr]    |     ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant `C_CALL` should have a camel case name such as `CCall`
[INFO] [stderr]   --> src/parser.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 |     C_CALL
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/writer.rs:6:41
[INFO] [stderr]   |
[INFO] [stderr] 6 | pub fn vm_commands_to_hack(vm_commands: &Vec<parser::VMCommand>) -> Vec<String> {
[INFO] [stderr]   |                                         ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[parser::VMCommand]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/writer.rs:20:36
[INFO] [stderr]    |
[INFO] [stderr] 20 | fn arithmetic_instruction(command: &String) -> Vec<String> {
[INFO] [stderr]    |                                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/main.rs:25:9
[INFO] [stderr]    |
[INFO] [stderr] 25 |         parser::parse_file(&vm_file_path, &mut vm_commands);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/parser.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 |     let mut file = try!(File::open(vm_file));
[INFO] [stderr]    |         ----^^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `C_LABEL`
[INFO] [stderr]   --> src/parser.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     C_LABEL,
[INFO] [stderr]    |     ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `C_GOTO`
[INFO] [stderr]   --> src/parser.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     C_GOTO,
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `C_IF`
[INFO] [stderr]   --> src/parser.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 |     C_IF,
[INFO] [stderr]    |     ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `C_FUNCTION`
[INFO] [stderr]   --> src/parser.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 |     C_FUNCTION,
[INFO] [stderr]    |     ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `C_RETURN`
[INFO] [stderr]   --> src/parser.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 |     C_RETURN,
[INFO] [stderr]    |     ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `C_CALL`
[INFO] [stderr]   --> src/parser.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 |     C_CALL
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/file.rs:6:1
[INFO] [stderr]    |
[INFO] [stderr] 6  | / fn ext_from_path<'a>(path: &'a Path) -> Option<&'a OsStr> {
[INFO] [stderr] 7  | |     match path.extension() {
[INFO] [stderr] 8  | |         Some(ext) => Some(ext),
[INFO] [stderr] 9  | |         None => None
[INFO] [stderr] 10 | |     }
[INFO] [stderr] 11 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: variant `C_ARITHMETIC` should have a camel case name such as `CArithmetic`
[INFO] [stderr]   --> src/parser.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     C_ARITHMETIC,
[INFO] [stderr]    |     ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_camel_case_types)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant `C_PUSH` should have a camel case name such as `CPush`
[INFO] [stderr]   --> src/parser.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 |     C_PUSH,
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant `C_POP` should have a camel case name such as `CPop`
[INFO] [stderr]   --> src/parser.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 |     C_POP,
[INFO] [stderr]    |     ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant `C_LABEL` should have a camel case name such as `CLabel`
[INFO] [stderr]   --> src/parser.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     C_LABEL,
[INFO] [stderr]    |     ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant `C_GOTO` should have a camel case name such as `CGoto`
[INFO] [stderr]   --> src/parser.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     C_GOTO,
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant `C_IF` should have a camel case name such as `CIf`
[INFO] [stderr]   --> src/parser.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 |     C_IF,
[INFO] [stderr]    |     ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant `C_FUNCTION` should have a camel case name such as `CFunction`
[INFO] [stderr]   --> src/parser.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 |     C_FUNCTION,
[INFO] [stderr]    |     ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant `C_RETURN` should have a camel case name such as `CReturn`
[INFO] [stderr]   --> src/parser.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 |     C_RETURN,
[INFO] [stderr]    |     ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant `C_CALL` should have a camel case name such as `CCall`
[INFO] [stderr]   --> src/parser.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 |     C_CALL
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/writer.rs:6:41
[INFO] [stderr]   |
[INFO] [stderr] 6 | pub fn vm_commands_to_hack(vm_commands: &Vec<parser::VMCommand>) -> Vec<String> {
[INFO] [stderr]   |                                         ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[parser::VMCommand]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/writer.rs:20:36
[INFO] [stderr]    |
[INFO] [stderr] 20 | fn arithmetic_instruction(command: &String) -> Vec<String> {
[INFO] [stderr]    |                                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/main.rs:25:9
[INFO] [stderr]    |
[INFO] [stderr] 25 |         parser::parse_file(&vm_file_path, &mut vm_commands);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.67s
[INFO] running `"docker" "inspect" "7962b1dba8bdd1620ff83e5677e09814e5bb4a8220def78111062bddcf6c11cc"`
[INFO] running `"docker" "rm" "-f" "7962b1dba8bdd1620ff83e5677e09814e5bb4a8220def78111062bddcf6c11cc"`
[INFO] [stdout] 7962b1dba8bdd1620ff83e5677e09814e5bb4a8220def78111062bddcf6c11cc