[INFO] updating cached repository johannesvollmer/proto-templates
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/johannesvollmer/proto-templates
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/johannesvollmer/proto-templates" "work/ex/clippy-test-run/sources/stable/gh/johannesvollmer/proto-templates"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/johannesvollmer/proto-templates'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/johannesvollmer/proto-templates" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johannesvollmer/proto-templates"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johannesvollmer/proto-templates'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 08afd1ae2894bc03736fa1398baf7a42f1a85488
[INFO] sha for GitHub repo johannesvollmer/proto-templates: 08afd1ae2894bc03736fa1398baf7a42f1a85488
[INFO] validating manifest of johannesvollmer/proto-templates on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of johannesvollmer/proto-templates on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing johannesvollmer/proto-templates
[INFO] finished frobbing johannesvollmer/proto-templates
[INFO] frobbed toml for johannesvollmer/proto-templates written to work/ex/clippy-test-run/sources/stable/gh/johannesvollmer/proto-templates/Cargo.toml
[INFO] started frobbing johannesvollmer/proto-templates
[INFO] finished frobbing johannesvollmer/proto-templates
[INFO] frobbed toml for johannesvollmer/proto-templates written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johannesvollmer/proto-templates/Cargo.toml
[INFO] crate johannesvollmer/proto-templates has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting johannesvollmer/proto-templates against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/johannesvollmer/proto-templates:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a8afcbdce7063db6ee490e93e93116296d4563ece37c92992fa0e0b6d49a2e5b
[INFO] running `"docker" "start" "-a" "a8afcbdce7063db6ee490e93e93116296d4563ece37c92992fa0e0b6d49a2e5b"`
[INFO] [stderr]     Checking prototype_template_language v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/parse.rs:108:12
[INFO] [stderr]     |
[INFO] [stderr] 108 |       } else {
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 109 | |         if source.is_empty() {
[INFO] [stderr] 110 | |             Err(ParseError::UnexpectedEndOfInput { expected: Some(symbol) })
[INFO] [stderr] 111 | |         } else {
[INFO] [stderr] ...   |
[INFO] [stderr] 116 | |         }
[INFO] [stderr] 117 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 108 |     } else if source.is_empty() {
[INFO] [stderr] 109 |     Err(ParseError::UnexpectedEndOfInput { expected: Some(symbol) })
[INFO] [stderr] 110 | } else {
[INFO] [stderr] 111 |     Err(ParseError::UnexpectedSymbol {
[INFO] [stderr] 112 |         expected: Some(symbol),
[INFO] [stderr] 113 |         found: source,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/parse.rs:108:12
[INFO] [stderr]     |
[INFO] [stderr] 108 |       } else {
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 109 | |         if source.is_empty() {
[INFO] [stderr] 110 | |             Err(ParseError::UnexpectedEndOfInput { expected: Some(symbol) })
[INFO] [stderr] 111 | |         } else {
[INFO] [stderr] ...   |
[INFO] [stderr] 116 | |         }
[INFO] [stderr] 117 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 108 |     } else if source.is_empty() {
[INFO] [stderr] 109 |     Err(ParseError::UnexpectedEndOfInput { expected: Some(symbol) })
[INFO] [stderr] 110 | } else {
[INFO] [stderr] 111 |     Err(ParseError::UnexpectedSymbol {
[INFO] [stderr] 112 |         expected: Some(symbol),
[INFO] [stderr] 113 |         found: source,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `::std::collections::HashMap`
[INFO] [stderr]  --> src/referenced.rs:1:5
[INFO] [stderr]   |
[INFO] [stderr] 1 | use ::std::collections::HashMap;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `::std::collections::HashMap`
[INFO] [stderr]  --> src/referenced.rs:1:5
[INFO] [stderr]   |
[INFO] [stderr] 1 | use ::std::collections::HashMap;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `character`
[INFO] [stderr]    --> src/parse.rs:124:32
[INFO] [stderr]     |
[INFO] [stderr] 124 |             .map(|(byte_index, character)| byte_index)
[INFO] [stderr]     |                                ^^^^^^^^^ help: consider using `_character` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `e`
[INFO] [stderr]    --> src/parse.rs:133:19
[INFO] [stderr]     |
[INFO] [stderr] 133 |         .map_err(|e| ParseError::UnexpectedEndOfInput { expected: Some(delimiter) })
[INFO] [stderr]     |                   ^ help: consider using `_e` instead
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `parse_over_delimiter`
[INFO] [stderr]    --> src/parse.rs:151:1
[INFO] [stderr]     |
[INFO] [stderr] 151 | fn parse_over_delimiter(source: Source, delimiter: char) -> ParseResult<(&str, Source)> {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/parse.rs:125:21
[INFO] [stderr]     |
[INFO] [stderr] 125 |             .next().unwrap_or(source.len()) // if the end was reached, split after the last char
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| source.len())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/flat.rs:22:18
[INFO] [stderr]    |
[INFO] [stderr] 22 |             .map(|objects| FlatObject::Compound(objects))
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `FlatObject::Compound`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]   --> src/flat.rs:34:13
[INFO] [stderr]    |
[INFO] [stderr] 34 | /             if !properties.contains_key(&name_string) {
[INFO] [stderr] 35 | |                 properties.insert(
[INFO] [stderr] 36 | |                     name_string,
[INFO] [stderr] 37 | |                     FlatObject::build_from_parsed_unnamed_object(
[INFO] [stderr] ...  |
[INFO] [stderr] 41 | |                 );
[INFO] [stderr] 42 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] help: consider using
[INFO] [stderr]    |
[INFO] [stderr] 34 |             properties.entry(name_string).or_insert(FlatObject::build_from_parsed_unnamed_object(
[INFO] [stderr] 35 |                         &objects.objects[*override_index],
[INFO] [stderr] 36 |                         world
[INFO] [stderr] 37 |                     )?)
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `character`
[INFO] [stderr]    --> src/parse.rs:124:32
[INFO] [stderr]     |
[INFO] [stderr] 124 |             .map(|(byte_index, character)| byte_index)
[INFO] [stderr]     |                                ^^^^^^^^^ help: consider using `_character` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `e`
[INFO] [stderr]    --> src/parse.rs:133:19
[INFO] [stderr]     |
[INFO] [stderr] 133 |         .map_err(|e| ParseError::UnexpectedEndOfInput { expected: Some(delimiter) })
[INFO] [stderr]     |                   ^ help: consider using `_e` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `c`
[INFO] [stderr]    --> src/parse.rs:416:40
[INFO] [stderr]     |
[INFO] [stderr] 416 |         assert_eq!(parse_while("xyz", |c| true), ("xyz", ""));
[INFO] [stderr]     |                                        ^ help: consider using `_c` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `c`
[INFO] [stderr]    --> src/parse.rs:417:40
[INFO] [stderr]     |
[INFO] [stderr] 417 |         assert_eq!(parse_while("xyz", |c| false), ("", "xyz"));
[INFO] [stderr]     |                                        ^ help: consider using `_c` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `c`
[INFO] [stderr]    --> src/parse.rs:418:37
[INFO] [stderr]     |
[INFO] [stderr] 418 |         assert_eq!(parse_while("", |c| true), ("", ""));
[INFO] [stderr]     |                                     ^ help: consider using `_c` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `c`
[INFO] [stderr]    --> src/parse.rs:419:37
[INFO] [stderr]     |
[INFO] [stderr] 419 |         assert_eq!(parse_while("", |c| false), ("", ""));
[INFO] [stderr]     |                                     ^ help: consider using `_c` instead
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/parse.rs:125:21
[INFO] [stderr]     |
[INFO] [stderr] 125 |             .next().unwrap_or(source.len()) // if the end was reached, split after the last char
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| source.len())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/flat.rs:22:18
[INFO] [stderr]    |
[INFO] [stderr] 22 |             .map(|objects| FlatObject::Compound(objects))
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `FlatObject::Compound`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]   --> src/flat.rs:34:13
[INFO] [stderr]    |
[INFO] [stderr] 34 | /             if !properties.contains_key(&name_string) {
[INFO] [stderr] 35 | |                 properties.insert(
[INFO] [stderr] 36 | |                     name_string,
[INFO] [stderr] 37 | |                     FlatObject::build_from_parsed_unnamed_object(
[INFO] [stderr] ...  |
[INFO] [stderr] 41 | |                 );
[INFO] [stderr] 42 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] help: consider using
[INFO] [stderr]    |
[INFO] [stderr] 34 |             properties.entry(name_string).or_insert(FlatObject::build_from_parsed_unnamed_object(
[INFO] [stderr] 35 |                         &objects.objects[*override_index],
[INFO] [stderr] 36 |                         world
[INFO] [stderr] 37 |                     )?)
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.55s
[INFO] running `"docker" "inspect" "a8afcbdce7063db6ee490e93e93116296d4563ece37c92992fa0e0b6d49a2e5b"`
[INFO] running `"docker" "rm" "-f" "a8afcbdce7063db6ee490e93e93116296d4563ece37c92992fa0e0b6d49a2e5b"`
[INFO] [stdout] a8afcbdce7063db6ee490e93e93116296d4563ece37c92992fa0e0b6d49a2e5b