[INFO] updating cached repository johannesvollmer/id-vec
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/johannesvollmer/id-vec
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/johannesvollmer/id-vec" "work/ex/clippy-test-run/sources/stable/gh/johannesvollmer/id-vec"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/johannesvollmer/id-vec'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/johannesvollmer/id-vec" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johannesvollmer/id-vec"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johannesvollmer/id-vec'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] b8fb1ff262363839e7c61ee2b1f1f85628d15a50
[INFO] sha for GitHub repo johannesvollmer/id-vec: b8fb1ff262363839e7c61ee2b1f1f85628d15a50
[INFO] validating manifest of johannesvollmer/id-vec on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of johannesvollmer/id-vec on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing johannesvollmer/id-vec
[INFO] finished frobbing johannesvollmer/id-vec
[INFO] frobbed toml for johannesvollmer/id-vec written to work/ex/clippy-test-run/sources/stable/gh/johannesvollmer/id-vec/Cargo.toml
[INFO] started frobbing johannesvollmer/id-vec
[INFO] finished frobbing johannesvollmer/id-vec
[INFO] frobbed toml for johannesvollmer/id-vec written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johannesvollmer/id-vec/Cargo.toml
[INFO] crate johannesvollmer/id-vec has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting johannesvollmer/id-vec against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/johannesvollmer/id-vec:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 33d116236baf35c7aafe448b4462511187b06db1737f95e35e42818f196475c6
[INFO] running `"docker" "start" "-a" "33d116236baf35c7aafe448b4462511187b06db1737f95e35e42818f196475c6"`
[INFO] [stderr] warning: unused manifest key: package.maintenance
[INFO] [stderr]     Checking id-vec v0.5.7 (/opt/crater/workdir)
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/vec.rs:188:52
[INFO] [stderr]     |
[INFO] [stderr] 188 |             if let Some(previously_unused_index) = self.unused_indices.iter().next().map(|i| *i) {
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.unused_indices.iter().next().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/vec.rs:295:5
[INFO] [stderr]     |
[INFO] [stderr] 295 | /     pub fn iter<'s>(&'s self) -> Iter<'s, T> {
[INFO] [stderr] 296 | |         Iter {
[INFO] [stderr] 297 | |             inclusive_front_index: 0,
[INFO] [stderr] 298 | |             exclusive_back_index: self.elements.len(),
[INFO] [stderr] 299 | |             storage: self
[INFO] [stderr] 300 | |         }
[INFO] [stderr] 301 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/vec.rs:327:5
[INFO] [stderr]     |
[INFO] [stderr] 327 | /     pub fn elements<'s>(&'s self) -> ElementIter<'s, T> {
[INFO] [stderr] 328 | |         ElementIter { iter: self.iter() }
[INFO] [stderr] 329 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/vec.rs:332:5
[INFO] [stderr]     |
[INFO] [stderr] 332 | /     pub fn ids<'s>(&'s self) -> IdIter<'s, T> {
[INFO] [stderr] 333 | |         IdIter { iter: self.iter() }
[INFO] [stderr] 334 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/vec.rs:455:27
[INFO] [stderr]     |
[INFO] [stderr] 455 |     exclusive_back_index: &Index,
[INFO] [stderr]     |                           ^^^^^^ help: consider passing by value instead: `Index`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/vec.rs:476:28
[INFO] [stderr]     |
[INFO] [stderr] 476 |     inclusive_front_index: &Index,
[INFO] [stderr]     |                            ^^^^^^ help: consider passing by value instead: `Index`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/vec.rs:689:15
[INFO] [stderr]     |
[INFO] [stderr] 689 |           ).map(|index|
[INFO] [stderr]     |  _______________^
[INFO] [stderr] 690 | |             Id::from_index(index)
[INFO] [stderr]     | |_________________________________^ help: remove closure as shown: `Id::from_index`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/vec.rs:708:15
[INFO] [stderr]     |
[INFO] [stderr] 708 |           ).map(|index|
[INFO] [stderr]     |  _______________^
[INFO] [stderr] 709 | |             Id::from_index(index)
[INFO] [stderr]     | |_________________________________^ help: remove closure as shown: `Id::from_index`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/vec.rs:188:52
[INFO] [stderr]     |
[INFO] [stderr] 188 |             if let Some(previously_unused_index) = self.unused_indices.iter().next().map(|i| *i) {
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.unused_indices.iter().next().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/vec.rs:295:5
[INFO] [stderr]     |
[INFO] [stderr] 295 | /     pub fn iter<'s>(&'s self) -> Iter<'s, T> {
[INFO] [stderr] 296 | |         Iter {
[INFO] [stderr] 297 | |             inclusive_front_index: 0,
[INFO] [stderr] 298 | |             exclusive_back_index: self.elements.len(),
[INFO] [stderr] 299 | |             storage: self
[INFO] [stderr] 300 | |         }
[INFO] [stderr] 301 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/vec.rs:327:5
[INFO] [stderr]     |
[INFO] [stderr] 327 | /     pub fn elements<'s>(&'s self) -> ElementIter<'s, T> {
[INFO] [stderr] 328 | |         ElementIter { iter: self.iter() }
[INFO] [stderr] 329 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/vec.rs:332:5
[INFO] [stderr]     |
[INFO] [stderr] 332 | /     pub fn ids<'s>(&'s self) -> IdIter<'s, T> {
[INFO] [stderr] 333 | |         IdIter { iter: self.iter() }
[INFO] [stderr] 334 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/vec.rs:455:27
[INFO] [stderr]     |
[INFO] [stderr] 455 |     exclusive_back_index: &Index,
[INFO] [stderr]     |                           ^^^^^^ help: consider passing by value instead: `Index`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/vec.rs:476:28
[INFO] [stderr]     |
[INFO] [stderr] 476 |     inclusive_front_index: &Index,
[INFO] [stderr]     |                            ^^^^^^ help: consider passing by value instead: `Index`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/vec.rs:689:15
[INFO] [stderr]     |
[INFO] [stderr] 689 |           ).map(|index|
[INFO] [stderr]     |  _______________^
[INFO] [stderr] 690 | |             Id::from_index(index)
[INFO] [stderr]     | |_________________________________^ help: remove closure as shown: `Id::from_index`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/vec.rs:708:15
[INFO] [stderr]     |
[INFO] [stderr] 708 |           ).map(|index|
[INFO] [stderr]     |  _______________^
[INFO] [stderr] 709 | |             Id::from_index(index)
[INFO] [stderr]     | |_________________________________^ help: remove closure as shown: `Id::from_index`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.60s
[INFO] running `"docker" "inspect" "33d116236baf35c7aafe448b4462511187b06db1737f95e35e42818f196475c6"`
[INFO] running `"docker" "rm" "-f" "33d116236baf35c7aafe448b4462511187b06db1737f95e35e42818f196475c6"`
[INFO] [stdout] 33d116236baf35c7aafe448b4462511187b06db1737f95e35e42818f196475c6