[INFO] updating cached repository joeyjoejoejr/advent-of-code-2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/joeyjoejoejr/advent-of-code-2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/joeyjoejoejr/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable/gh/joeyjoejoejr/advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/joeyjoejoejr/advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/joeyjoejoejr/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joeyjoejoejr/advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joeyjoejoejr/advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ffcf90ee828a1ea58fff10567745522d8bffa685 [INFO] sha for GitHub repo joeyjoejoejr/advent-of-code-2018: ffcf90ee828a1ea58fff10567745522d8bffa685 [INFO] validating manifest of joeyjoejoejr/advent-of-code-2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of joeyjoejoejr/advent-of-code-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing joeyjoejoejr/advent-of-code-2018 [INFO] finished frobbing joeyjoejoejr/advent-of-code-2018 [INFO] frobbed toml for joeyjoejoejr/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable/gh/joeyjoejoejr/advent-of-code-2018/Cargo.toml [INFO] started frobbing joeyjoejoejr/advent-of-code-2018 [INFO] finished frobbing joeyjoejoejr/advent-of-code-2018 [INFO] frobbed toml for joeyjoejoejr/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joeyjoejoejr/advent-of-code-2018/Cargo.toml [INFO] crate joeyjoejoejr/advent-of-code-2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting joeyjoejoejr/advent-of-code-2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/joeyjoejoejr/advent-of-code-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ed5cac8a4a0fb1c0bcbc5264a2b3a1ba5d74525978abeb1cd19e3973c6c3b545 [INFO] running `"docker" "start" "-a" "ed5cac8a4a0fb1c0bcbc5264a2b3a1ba5d74525978abeb1cd19e3973c6c3b545"` [INFO] [stderr] Compiling syn v0.15.23 [INFO] [stderr] Compiling structopt-derive v0.2.14 [INFO] [stderr] Checking structopt v0.2.14 [INFO] [stderr] Checking advent-of-code-2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day-three.rs:72:7 [INFO] [stderr] | [INFO] [stderr] 72 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day-three.rs:72:7 [INFO] [stderr] | [INFO] [stderr] 72 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day-three.rs:91:51 [INFO] [stderr] | [INFO] [stderr] 91 | let mut coords = tokens.next().unwrap().split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day-three.rs:102:49 [INFO] [stderr] | [INFO] [stderr] 102 | let mut dims = tokens.next().unwrap().split("x"); [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/day-three.rs:143:23 [INFO] [stderr] | [INFO] [stderr] 143 | .all(|coord| *spaces.get(coord).unwrap() == 1u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&spaces[coord]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day-three.rs:91:51 [INFO] [stderr] | [INFO] [stderr] 91 | let mut coords = tokens.next().unwrap().split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day-three.rs:102:49 [INFO] [stderr] | [INFO] [stderr] 102 | let mut dims = tokens.next().unwrap().split("x"); [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/day-three.rs:143:23 [INFO] [stderr] | [INFO] [stderr] 143 | .all(|coord| *spaces.get(coord).unwrap() == 1u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&spaces[coord]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.51s [INFO] running `"docker" "inspect" "ed5cac8a4a0fb1c0bcbc5264a2b3a1ba5d74525978abeb1cd19e3973c6c3b545"` [INFO] running `"docker" "rm" "-f" "ed5cac8a4a0fb1c0bcbc5264a2b3a1ba5d74525978abeb1cd19e3973c6c3b545"` [INFO] [stdout] ed5cac8a4a0fb1c0bcbc5264a2b3a1ba5d74525978abeb1cd19e3973c6c3b545