[INFO] updating cached repository joeybloggs/mandlebrot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/joeybloggs/mandlebrot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/joeybloggs/mandlebrot" "work/ex/clippy-test-run/sources/stable/gh/joeybloggs/mandlebrot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/joeybloggs/mandlebrot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/joeybloggs/mandlebrot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joeybloggs/mandlebrot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joeybloggs/mandlebrot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4ce0ac6953d0671a1600a8753d8e07a01a7ac622 [INFO] sha for GitHub repo joeybloggs/mandlebrot: 4ce0ac6953d0671a1600a8753d8e07a01a7ac622 [INFO] validating manifest of joeybloggs/mandlebrot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of joeybloggs/mandlebrot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing joeybloggs/mandlebrot [INFO] finished frobbing joeybloggs/mandlebrot [INFO] frobbed toml for joeybloggs/mandlebrot written to work/ex/clippy-test-run/sources/stable/gh/joeybloggs/mandlebrot/Cargo.toml [INFO] started frobbing joeybloggs/mandlebrot [INFO] finished frobbing joeybloggs/mandlebrot [INFO] frobbed toml for joeybloggs/mandlebrot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joeybloggs/mandlebrot/Cargo.toml [INFO] crate joeybloggs/mandlebrot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting joeybloggs/mandlebrot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/joeybloggs/mandlebrot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bc2645c30e2fd8fd5aab2f1728c44f6e79d13f0e5f27dc0773f750eb4a7a4b19 [INFO] running `"docker" "start" "-a" "bc2645c30e2fd8fd5aab2f1728c44f6e79d13f0e5f27dc0773f750eb4a7a4b19"` [INFO] [stderr] Checking cookie v0.10.1 [INFO] [stderr] Checking tokio-io v0.1.4 [INFO] [stderr] Checking http v0.1.4 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking serde_qs v0.3.0 [INFO] [stderr] Checking tokio-core v0.1.12 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking hyper v0.11.15 [INFO] [stderr] Checking reset-router v0.3.0 [INFO] [stderr] Checking mandlebrot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mandlebrot.rs:32:16 [INFO] [stderr] | [INFO] [stderr] 32 | Self { pool: pool } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mandlebrot.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mandlebrot.rs:45:29 [INFO] [stderr] | [INFO] [stderr] 45 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mandlebrot.rs:46:29 [INFO] [stderr] | [INFO] [stderr] 46 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mandlebrot.rs:32:16 [INFO] [stderr] | [INFO] [stderr] 32 | Self { pool: pool } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mandlebrot.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mandlebrot.rs:45:29 [INFO] [stderr] | [INFO] [stderr] 45 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mandlebrot.rs:46:29 [INFO] [stderr] | [INFO] [stderr] 46 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mandlebrot.rs:42:58 [INFO] [stderr] | [INFO] [stderr] 42 | let value = generate_pixel(x, y, width as f64, height as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mandlebrot.rs:42:72 [INFO] [stderr] | [INFO] [stderr] 42 | let value = generate_pixel(x, y, width as f64, height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mandlebrot.rs:71:19 [INFO] [stderr] | [INFO] [stderr] 71 | let xi = norm(i as f64, width as f64, -1.0, 2.0); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mandlebrot.rs:72:19 [INFO] [stderr] | [INFO] [stderr] 72 | let yi = norm(j as f64, height as f64, -1.0, 1.0); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/mandlebrot.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mandlebrot.rs:42:58 [INFO] [stderr] | [INFO] [stderr] 42 | let value = generate_pixel(x, y, width as f64, height as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mandlebrot.rs:42:72 [INFO] [stderr] | [INFO] [stderr] 42 | let value = generate_pixel(x, y, width as f64, height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mandlebrot.rs:71:19 [INFO] [stderr] | [INFO] [stderr] 71 | let xi = norm(i as f64, width as f64, -1.0, 2.0); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mandlebrot.rs:72:19 [INFO] [stderr] | [INFO] [stderr] 72 | let yi = norm(j as f64, height as f64, -1.0, 1.0); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/mandlebrot.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.08s [INFO] running `"docker" "inspect" "bc2645c30e2fd8fd5aab2f1728c44f6e79d13f0e5f27dc0773f750eb4a7a4b19"` [INFO] running `"docker" "rm" "-f" "bc2645c30e2fd8fd5aab2f1728c44f6e79d13f0e5f27dc0773f750eb4a7a4b19"` [INFO] [stdout] bc2645c30e2fd8fd5aab2f1728c44f6e79d13f0e5f27dc0773f750eb4a7a4b19