[INFO] updating cached repository joelparkerhenderson/demo_rust_code [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/joelparkerhenderson/demo_rust_code [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/joelparkerhenderson/demo_rust_code" "work/ex/clippy-test-run/sources/stable/gh/joelparkerhenderson/demo_rust_code"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/joelparkerhenderson/demo_rust_code'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/joelparkerhenderson/demo_rust_code" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joelparkerhenderson/demo_rust_code"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joelparkerhenderson/demo_rust_code'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 532d8e8891519f3ed1f80e3be222e14f087cc7db [INFO] sha for GitHub repo joelparkerhenderson/demo_rust_code: 532d8e8891519f3ed1f80e3be222e14f087cc7db [INFO] validating manifest of joelparkerhenderson/demo_rust_code on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of joelparkerhenderson/demo_rust_code on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing joelparkerhenderson/demo_rust_code [INFO] finished frobbing joelparkerhenderson/demo_rust_code [INFO] frobbed toml for joelparkerhenderson/demo_rust_code written to work/ex/clippy-test-run/sources/stable/gh/joelparkerhenderson/demo_rust_code/Cargo.toml [INFO] started frobbing joelparkerhenderson/demo_rust_code [INFO] finished frobbing joelparkerhenderson/demo_rust_code [INFO] frobbed toml for joelparkerhenderson/demo_rust_code written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joelparkerhenderson/demo_rust_code/Cargo.toml [INFO] crate joelparkerhenderson/demo_rust_code has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting joelparkerhenderson/demo_rust_code against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/joelparkerhenderson/demo_rust_code:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a111e3042049d3797ec6fc30ed5f257b82dad6e57d0511006d1661c3921b8bbe [INFO] running `"docker" "start" "-a" "a111e3042049d3797ec6fc30ed5f257b82dad6e57d0511006d1661c3921b8bbe"` [INFO] [stderr] Checking demo-rust-code v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:156:33 [INFO] [stderr] | [INFO] [stderr] 156 | println!("Hello {} and {}", "Alice", "Bob"); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:156:42 [INFO] [stderr] | [INFO] [stderr] 156 | println!("Hello {} and {}", "Alice", "Bob"); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | let mut g = String::from("hello"); // Create a new string that says "hello" [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | let h = 98_222; // Decimal [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | let i = 0xff; // Hex [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/main.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | let j = 0o77; // Octal [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/main.rs:215:9 [INFO] [stderr] | [INFO] [stderr] 215 | let k = 0b1111_0000; // Binary [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/main.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | let l = b'A'; // Byte (u8 only) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:156:33 [INFO] [stderr] | [INFO] [stderr] 156 | println!("Hello {} and {}", "Alice", "Bob"); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:156:42 [INFO] [stderr] | [INFO] [stderr] 156 | println!("Hello {} and {}", "Alice", "Bob"); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | let mut g = String::from("hello"); // Create a new string that says "hello" [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | let h = 98_222; // Decimal [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | let i = 0xff; // Hex [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/main.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | let j = 0o77; // Octal [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/main.rs:215:9 [INFO] [stderr] | [INFO] [stderr] 215 | let k = 0b1111_0000; // Binary [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/main.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | let l = b'A'; // Byte (u8 only) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:243:12 [INFO] [stderr] | [INFO] [stderr] 243 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 244 | | //... [INFO] [stderr] 245 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:241:10 [INFO] [stderr] | [INFO] [stderr] 241 | if a { [INFO] [stderr] | __________^ [INFO] [stderr] 242 | | //... [INFO] [stderr] 243 | | } else { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:249:17 [INFO] [stderr] | [INFO] [stderr] 249 | } else if b { [INFO] [stderr] | _________________^ [INFO] [stderr] 250 | | //... [INFO] [stderr] 251 | | } else if c { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:247:10 [INFO] [stderr] | [INFO] [stderr] 247 | if a { [INFO] [stderr] | __________^ [INFO] [stderr] 248 | | //... [INFO] [stderr] 249 | | } else if b { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:257:5 [INFO] [stderr] | [INFO] [stderr] 257 | / loop { [INFO] [stderr] 258 | | //... [INFO] [stderr] 259 | | break; [INFO] [stderr] 260 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:262:5 [INFO] [stderr] | [INFO] [stderr] 262 | / while a { [INFO] [stderr] 263 | | //... [INFO] [stderr] 264 | | break; [INFO] [stderr] 265 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop. [INFO] [stderr] --> src/main.rs:262:11 [INFO] [stderr] | [INFO] [stderr] 262 | while a { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::while_immutable_condition)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `demo-rust-code`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:243:12 [INFO] [stderr] | [INFO] [stderr] 243 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 244 | | //... [INFO] [stderr] 245 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:241:10 [INFO] [stderr] | [INFO] [stderr] 241 | if a { [INFO] [stderr] | __________^ [INFO] [stderr] 242 | | //... [INFO] [stderr] 243 | | } else { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:249:17 [INFO] [stderr] | [INFO] [stderr] 249 | } else if b { [INFO] [stderr] | _________________^ [INFO] [stderr] 250 | | //... [INFO] [stderr] 251 | | } else if c { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:247:10 [INFO] [stderr] | [INFO] [stderr] 247 | if a { [INFO] [stderr] | __________^ [INFO] [stderr] 248 | | //... [INFO] [stderr] 249 | | } else if b { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:257:5 [INFO] [stderr] | [INFO] [stderr] 257 | / loop { [INFO] [stderr] 258 | | //... [INFO] [stderr] 259 | | break; [INFO] [stderr] 260 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:262:5 [INFO] [stderr] | [INFO] [stderr] 262 | / while a { [INFO] [stderr] 263 | | //... [INFO] [stderr] 264 | | break; [INFO] [stderr] 265 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop. [INFO] [stderr] --> src/main.rs:262:11 [INFO] [stderr] | [INFO] [stderr] 262 | while a { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::while_immutable_condition)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `demo-rust-code`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a111e3042049d3797ec6fc30ed5f257b82dad6e57d0511006d1661c3921b8bbe"` [INFO] running `"docker" "rm" "-f" "a111e3042049d3797ec6fc30ed5f257b82dad6e57d0511006d1661c3921b8bbe"` [INFO] [stdout] a111e3042049d3797ec6fc30ed5f257b82dad6e57d0511006d1661c3921b8bbe