[INFO] updating cached repository joek13/hangman [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/joek13/hangman [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/joek13/hangman" "work/ex/clippy-test-run/sources/stable/gh/joek13/hangman"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/joek13/hangman'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/joek13/hangman" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joek13/hangman"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joek13/hangman'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 130ab05429dcc6db97af6b6ad6ce1d4e5167a8fa [INFO] sha for GitHub repo joek13/hangman: 130ab05429dcc6db97af6b6ad6ce1d4e5167a8fa [INFO] validating manifest of joek13/hangman on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of joek13/hangman on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing joek13/hangman [INFO] finished frobbing joek13/hangman [INFO] frobbed toml for joek13/hangman written to work/ex/clippy-test-run/sources/stable/gh/joek13/hangman/Cargo.toml [INFO] started frobbing joek13/hangman [INFO] finished frobbing joek13/hangman [INFO] frobbed toml for joek13/hangman written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joek13/hangman/Cargo.toml [INFO] crate joek13/hangman has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting joek13/hangman against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/joek13/hangman:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6afe663baaf6cafb5cbd8103313aabac186063328e41723c56c2f575451390f9 [INFO] running `"docker" "start" "-a" "6afe663baaf6cafb5cbd8103313aabac186063328e41723c56c2f575451390f9"` [INFO] [stderr] Checking termion v1.4.0 [INFO] [stderr] Checking hangman v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::thread::sleep` [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use std::thread::sleep; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::time::Duration` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | use std::time::Duration; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:36:15 [INFO] [stderr] | [INFO] [stderr] 36 | const words: &'static str = include_str!("words.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:207:17 [INFO] [stderr] | [INFO] [stderr] 207 | / if state == State::Game { [INFO] [stderr] 208 | | if !game.guesses.contains(&x) && x.is_alphabetic() { [INFO] [stderr] 209 | | game.guesses.push(x); [INFO] [stderr] 210 | | print!("{}{}", clear::All, game.display()); [INFO] [stderr] 211 | | stdout.flush().unwrap(); [INFO] [stderr] 212 | | } [INFO] [stderr] 213 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 207 | if state == State::Game && !game.guesses.contains(&x) && x.is_alphabetic() { [INFO] [stderr] 208 | game.guesses.push(x); [INFO] [stderr] 209 | print!("{}{}", clear::All, game.display()); [INFO] [stderr] 210 | stdout.flush().unwrap(); [INFO] [stderr] 211 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::thread::sleep` [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use std::thread::sleep; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::time::Duration` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | use std::time::Duration; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:36:15 [INFO] [stderr] | [INFO] [stderr] 36 | const words: &'static str = include_str!("words.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:207:17 [INFO] [stderr] | [INFO] [stderr] 207 | / if state == State::Game { [INFO] [stderr] 208 | | if !game.guesses.contains(&x) && x.is_alphabetic() { [INFO] [stderr] 209 | | game.guesses.push(x); [INFO] [stderr] 210 | | print!("{}{}", clear::All, game.display()); [INFO] [stderr] 211 | | stdout.flush().unwrap(); [INFO] [stderr] 212 | | } [INFO] [stderr] 213 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 207 | if state == State::Game && !game.guesses.contains(&x) && x.is_alphabetic() { [INFO] [stderr] 208 | game.guesses.push(x); [INFO] [stderr] 209 | print!("{}{}", clear::All, game.display()); [INFO] [stderr] 210 | stdout.flush().unwrap(); [INFO] [stderr] 211 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:21:37 [INFO] [stderr] | [INFO] [stderr] 21 | for (index, line) in text.split("\n").enumerate() { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: constant `words` should have an upper case name such as `WORDS` [INFO] [stderr] --> src/main.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | const words: &'static str = include_str!("words.txt"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:41:45 [INFO] [stderr] | [INFO] [stderr] 41 | .choose(words.split("\n").collect::>().as_slice()) [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:86:29 [INFO] [stderr] | [INFO] [stderr] 86 | let lines = input.split("\n").collect::>(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:21:37 [INFO] [stderr] | [INFO] [stderr] 21 | for (index, line) in text.split("\n").enumerate() { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: constant `words` should have an upper case name such as `WORDS` [INFO] [stderr] --> src/main.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | const words: &'static str = include_str!("words.txt"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:41:45 [INFO] [stderr] | [INFO] [stderr] 41 | .choose(words.split("\n").collect::>().as_slice()) [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:86:29 [INFO] [stderr] | [INFO] [stderr] 86 | let lines = input.split("\n").collect::>(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.31s [INFO] running `"docker" "inspect" "6afe663baaf6cafb5cbd8103313aabac186063328e41723c56c2f575451390f9"` [INFO] running `"docker" "rm" "-f" "6afe663baaf6cafb5cbd8103313aabac186063328e41723c56c2f575451390f9"` [INFO] [stdout] 6afe663baaf6cafb5cbd8103313aabac186063328e41723c56c2f575451390f9