[INFO] updating cached repository joebentley/rust-life [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/joebentley/rust-life [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/joebentley/rust-life" "work/ex/clippy-test-run/sources/stable/gh/joebentley/rust-life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/joebentley/rust-life'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/joebentley/rust-life" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joebentley/rust-life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joebentley/rust-life'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5557bbc6411ba20b70d0eb394e99476b6c75117a [INFO] sha for GitHub repo joebentley/rust-life: 5557bbc6411ba20b70d0eb394e99476b6c75117a [INFO] validating manifest of joebentley/rust-life on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of joebentley/rust-life on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing joebentley/rust-life [INFO] finished frobbing joebentley/rust-life [INFO] frobbed toml for joebentley/rust-life written to work/ex/clippy-test-run/sources/stable/gh/joebentley/rust-life/Cargo.toml [INFO] started frobbing joebentley/rust-life [INFO] finished frobbing joebentley/rust-life [INFO] frobbed toml for joebentley/rust-life written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joebentley/rust-life/Cargo.toml [INFO] crate joebentley/rust-life has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting joebentley/rust-life against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/joebentley/rust-life:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ed27618db0d50d6ec63cbfbbeccc97e6862d9ea5eb39bdf321f32763add52b51 [INFO] running `"docker" "start" "-a" "ed27618db0d50d6ec63cbfbbeccc97e6862d9ea5eb39bdf321f32763add52b51"` [INFO] [stderr] Checking rust-life v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `automaton::Board` [INFO] [stderr] --> src/automaton.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / pub fn new() -> Board { [INFO] [stderr] 57 | | Board { [INFO] [stderr] 58 | | living_cells: HashSet::new() [INFO] [stderr] 59 | | } [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 51 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `automaton::Automaton` [INFO] [stderr] --> src/automaton.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | / pub fn new() -> Automaton { [INFO] [stderr] 136 | | Automaton { [INFO] [stderr] 137 | | board: Board::new() [INFO] [stderr] 138 | | } [INFO] [stderr] 139 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 134 | impl Default for automaton::Automaton { [INFO] [stderr] 135 | fn default() -> Self { [INFO] [stderr] 136 | Self::new() [INFO] [stderr] 137 | } [INFO] [stderr] 138 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/loader.rs:59:31 [INFO] [stderr] | [INFO] [stderr] 59 | let data = data.split("$"); [INFO] [stderr] | ^^^ help: try using a char instead: `'$'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `automaton::Board` [INFO] [stderr] --> src/automaton.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / pub fn new() -> Board { [INFO] [stderr] 57 | | Board { [INFO] [stderr] 58 | | living_cells: HashSet::new() [INFO] [stderr] 59 | | } [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 51 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `automaton::Automaton` [INFO] [stderr] --> src/automaton.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | / pub fn new() -> Automaton { [INFO] [stderr] 136 | | Automaton { [INFO] [stderr] 137 | | board: Board::new() [INFO] [stderr] 138 | | } [INFO] [stderr] 139 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 134 | impl Default for automaton::Automaton { [INFO] [stderr] 135 | fn default() -> Self { [INFO] [stderr] 136 | Self::new() [INFO] [stderr] 137 | } [INFO] [stderr] 138 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/loader.rs:59:31 [INFO] [stderr] | [INFO] [stderr] 59 | let data = data.split("$"); [INFO] [stderr] | ^^^ help: try using a char instead: `'$'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.81s [INFO] running `"docker" "inspect" "ed27618db0d50d6ec63cbfbbeccc97e6862d9ea5eb39bdf321f32763add52b51"` [INFO] running `"docker" "rm" "-f" "ed27618db0d50d6ec63cbfbbeccc97e6862d9ea5eb39bdf321f32763add52b51"` [INFO] [stdout] ed27618db0d50d6ec63cbfbbeccc97e6862d9ea5eb39bdf321f32763add52b51