[INFO] updating cached repository joe-mojo/xke_rusty_mower
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/joe-mojo/xke_rusty_mower
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/joe-mojo/xke_rusty_mower" "work/ex/clippy-test-run/sources/stable/gh/joe-mojo/xke_rusty_mower"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/joe-mojo/xke_rusty_mower'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/joe-mojo/xke_rusty_mower" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joe-mojo/xke_rusty_mower"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joe-mojo/xke_rusty_mower'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a4f954cb53cc72224ccc049b82edd7e214e59353
[INFO] sha for GitHub repo joe-mojo/xke_rusty_mower: a4f954cb53cc72224ccc049b82edd7e214e59353
[INFO] validating manifest of joe-mojo/xke_rusty_mower on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of joe-mojo/xke_rusty_mower on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing joe-mojo/xke_rusty_mower
[INFO] finished frobbing joe-mojo/xke_rusty_mower
[INFO] frobbed toml for joe-mojo/xke_rusty_mower written to work/ex/clippy-test-run/sources/stable/gh/joe-mojo/xke_rusty_mower/Cargo.toml
[INFO] started frobbing joe-mojo/xke_rusty_mower
[INFO] finished frobbing joe-mojo/xke_rusty_mower
[INFO] frobbed toml for joe-mojo/xke_rusty_mower written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joe-mojo/xke_rusty_mower/Cargo.toml
[INFO] crate joe-mojo/xke_rusty_mower has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting joe-mojo/xke_rusty_mower against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/joe-mojo/xke_rusty_mower:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 867deebb1ec9deccda921a605ad9d8d7cae9ec01e1fd626e4000af2b4ba6aca7
[INFO] running `"docker" "start" "-a" "867deebb1ec9deccda921a605ad9d8d7cae9ec01e1fd626e4000af2b4ba6aca7"`
[INFO] [stderr]     Checking rusty_mower v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/mower.rs:59:41
[INFO] [stderr]    |
[INFO] [stderr] 59 |     fn apply(&mut self, command: &Command) -> () {
[INFO] [stderr]    |                                            ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:79:2
[INFO] [stderr]    |
[INFO] [stderr] 79 |     report_res
[INFO] [stderr]    |     ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:51:19
[INFO] [stderr]    |
[INFO] [stderr] 51 |       let report_res = next_line(&mut line_split).map(|line_str| line_str.to_string())
[INFO] [stderr]    |  ______________________^
[INFO] [stderr] 52 | |         .ok_or("First line with lawn dimension not found".to_string())
[INFO] [stderr] 53 | |         .and_then(Lawn::parse)
[INFO] [stderr] 54 | |         .map(|working_area: Lawn|{
[INFO] [stderr] ...  |
[INFO] [stderr] 76 | |             exec_report
[INFO] [stderr] 77 | |     });
[INFO] [stderr]    | |______^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/mower.rs:59:41
[INFO] [stderr]    |
[INFO] [stderr] 59 |     fn apply(&mut self, command: &Command) -> () {
[INFO] [stderr]    |                                            ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:79:2
[INFO] [stderr]    |
[INFO] [stderr] 79 |     report_res
[INFO] [stderr]    |     ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:51:19
[INFO] [stderr]    |
[INFO] [stderr] 51 |       let report_res = next_line(&mut line_split).map(|line_str| line_str.to_string())
[INFO] [stderr]    |  ______________________^
[INFO] [stderr] 52 | |         .ok_or("First line with lawn dimension not found".to_string())
[INFO] [stderr] 53 | |         .and_then(Lawn::parse)
[INFO] [stderr] 54 | |         .map(|working_area: Lawn|{
[INFO] [stderr] ...  |
[INFO] [stderr] 76 | |             exec_report
[INFO] [stderr] 77 | |     });
[INFO] [stderr]    | |______^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/lawn.rs:10:17
[INFO] [stderr]    |
[INFO] [stderr] 10 |     maybe_line.map(|wstr:&str| Ok(wstr))
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Ok`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/lawn.rs:20:35
[INFO] [stderr]    |
[INFO] [stderr] 20 |         let mut line_split = line.split(" ");
[INFO] [stderr]    |                                         ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/mower.rs:47:6
[INFO] [stderr]    |
[INFO] [stderr] 47 |         }).ok_or(format!("Cannot parse Mower from {}", line))
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Cannot parse Mower from {}", line))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/direction.rs:13:22
[INFO] [stderr]    |
[INFO] [stderr] 13 |     pub fn from_char(c: &char) -> Option<Direction> {
[INFO] [stderr]    |                         ^^^^^ help: consider passing by value instead: `char`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/command.rs:10:22
[INFO] [stderr]    |
[INFO] [stderr] 10 |     pub fn from_char(c: &char) -> Option<Command>{
[INFO] [stderr]    |                         ^^^^^ help: consider passing by value instead: `char`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/command.rs:22:27
[INFO] [stderr]    |
[INFO] [stderr] 22 |             Command::from_char(&c).ok_or(format!("Cannot parse commands: invalid char '{}' in line {}", c, line))
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Cannot parse commands: invalid char '{}' in line {}", c, line))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:47:38
[INFO] [stderr]    |
[INFO] [stderr] 47 |     let mut line_split = contents.split("\n");
[INFO] [stderr]    |                                         ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:52:4
[INFO] [stderr]    |
[INFO] [stderr] 52 |         .ok_or("First line with lawn dimension not found".to_string())
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "First line with lawn dimension not found".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:66:7
[INFO] [stderr]    |
[INFO] [stderr] 66 |                         id_counter = id_counter + 1;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `id_counter += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/lawn.rs:10:17
[INFO] [stderr]    |
[INFO] [stderr] 10 |     maybe_line.map(|wstr:&str| Ok(wstr))
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Ok`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/lawn.rs:20:35
[INFO] [stderr]    |
[INFO] [stderr] 20 |         let mut line_split = line.split(" ");
[INFO] [stderr]    |                                         ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/mower.rs:47:6
[INFO] [stderr]    |
[INFO] [stderr] 47 |         }).ok_or(format!("Cannot parse Mower from {}", line))
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Cannot parse Mower from {}", line))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/direction.rs:13:22
[INFO] [stderr]    |
[INFO] [stderr] 13 |     pub fn from_char(c: &char) -> Option<Direction> {
[INFO] [stderr]    |                         ^^^^^ help: consider passing by value instead: `char`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/command.rs:10:22
[INFO] [stderr]    |
[INFO] [stderr] 10 |     pub fn from_char(c: &char) -> Option<Command>{
[INFO] [stderr]    |                         ^^^^^ help: consider passing by value instead: `char`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/command.rs:22:27
[INFO] [stderr]    |
[INFO] [stderr] 22 |             Command::from_char(&c).ok_or(format!("Cannot parse commands: invalid char '{}' in line {}", c, line))
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Cannot parse commands: invalid char '{}' in line {}", c, line))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:47:38
[INFO] [stderr]    |
[INFO] [stderr] 47 |     let mut line_split = contents.split("\n");
[INFO] [stderr]    |                                         ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:52:4
[INFO] [stderr]    |
[INFO] [stderr] 52 |         .ok_or("First line with lawn dimension not found".to_string())
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "First line with lawn dimension not found".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:66:7
[INFO] [stderr]    |
[INFO] [stderr] 66 |                         id_counter = id_counter + 1;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `id_counter += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.29s
[INFO] running `"docker" "inspect" "867deebb1ec9deccda921a605ad9d8d7cae9ec01e1fd626e4000af2b4ba6aca7"`
[INFO] running `"docker" "rm" "-f" "867deebb1ec9deccda921a605ad9d8d7cae9ec01e1fd626e4000af2b4ba6aca7"`
[INFO] [stdout] 867deebb1ec9deccda921a605ad9d8d7cae9ec01e1fd626e4000af2b4ba6aca7