[INFO] updating cached repository joar/rust-game-of-life [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/joar/rust-game-of-life [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/joar/rust-game-of-life" "work/ex/clippy-test-run/sources/stable/gh/joar/rust-game-of-life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/joar/rust-game-of-life'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/joar/rust-game-of-life" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joar/rust-game-of-life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joar/rust-game-of-life'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d56ad8337345dce19979ac2b318db461a5c509c5 [INFO] sha for GitHub repo joar/rust-game-of-life: d56ad8337345dce19979ac2b318db461a5c509c5 [INFO] validating manifest of joar/rust-game-of-life on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of joar/rust-game-of-life on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing joar/rust-game-of-life [INFO] finished frobbing joar/rust-game-of-life [INFO] frobbed toml for joar/rust-game-of-life written to work/ex/clippy-test-run/sources/stable/gh/joar/rust-game-of-life/Cargo.toml [INFO] started frobbing joar/rust-game-of-life [INFO] finished frobbing joar/rust-game-of-life [INFO] frobbed toml for joar/rust-game-of-life written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joar/rust-game-of-life/Cargo.toml [INFO] crate joar/rust-game-of-life has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting joar/rust-game-of-life against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/joar/rust-game-of-life:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c1ffadcf04fa40e50cdb589b964d7ed3dbab1a14c517b3e08963e50d430e76e5 [INFO] running `"docker" "start" "-a" "c1ffadcf04fa40e50cdb589b964d7ed3dbab1a14c517b3e08963e50d430e76e5"` [INFO] [stderr] Compiling libc v0.2.19 [INFO] [stderr] Compiling serde v0.8.22 [INFO] [stderr] Checking num_cpus v1.2.1 [INFO] [stderr] Checking shared_library v0.1.5 [INFO] [stderr] Checking term_size v0.2.1 [INFO] [stderr] Compiling x11-dl v2.12.0 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking deflate v0.7.2 [INFO] [stderr] Checking nodrop v0.1.8 [INFO] [stderr] Compiling wayland-scanner v0.7.6 [INFO] [stderr] Checking deque v0.3.1 [INFO] [stderr] Checking num-bigint v0.1.35 [INFO] [stderr] Checking pistoncore-input v0.15.0 [INFO] [stderr] Checking gfx_core v0.5.1 [INFO] [stderr] Checking clap v2.19.3 [INFO] [stderr] Compiling glutin v0.7.2 [INFO] [stderr] Compiling gfx_gl v0.3.1 [INFO] [stderr] Compiling gl v0.6.1 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking arrayvec v0.3.20 [INFO] [stderr] Compiling rand v0.3.15 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Checking rayon v0.6.0 [INFO] [stderr] Checking num-rational v0.1.35 [INFO] [stderr] Compiling wayland-client v0.7.6 [INFO] [stderr] Checking pistoncore-window v0.24.0 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking tempfile v2.1.4 [INFO] [stderr] Checking rusttype v0.2.1 [INFO] [stderr] Compiling phf_generator v0.7.20 [INFO] [stderr] Checking jpeg-decoder v0.1.11 [INFO] [stderr] Compiling serde_json v0.8.4 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking pistoncore-event_loop v0.27.0 [INFO] [stderr] Compiling phf_codegen v0.7.20 [INFO] [stderr] Checking image v0.12.1 [INFO] [stderr] Checking piston v0.27.0 [INFO] [stderr] Compiling target_build_utils v0.1.2 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking piston2d-opengl_graphics v0.37.0 [INFO] [stderr] Compiling libloading v0.3.1 [INFO] [stderr] Checking gfx v0.13.0 [INFO] [stderr] Checking gfx_device_gl v0.12.0 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.6 [INFO] [stderr] Checking piston-gfx_texture v0.20.0 [INFO] [stderr] Checking wayland-window v0.4.3 [INFO] [stderr] Checking wayland-kbd v0.6.2 [INFO] [stderr] Checking piston2d-gfx_graphics v0.35.0 [INFO] [stderr] Checking winit v0.5.7 [INFO] [stderr] Checking pistoncore-glutin_window v0.33.0 [INFO] [stderr] Checking piston_window v0.61.0 [INFO] [stderr] Checking game-of-life v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:59:25 [INFO] [stderr] | [INFO] [stderr] 59 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:60:25 [INFO] [stderr] | [INFO] [stderr] 60 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | y: y [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | gl: gl, [INFO] [stderr] | ^^^^^^ help: replace it with: `gl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | window_size: window_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `window_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | world_state: world_state, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `world_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:237:35 [INFO] [stderr] | [INFO] [stderr] 237 | let cell = CellPosition { x: x, y: y }; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:237:41 [INFO] [stderr] | [INFO] [stderr] 237 | let cell = CellPosition { x: x, y: y }; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:59:25 [INFO] [stderr] | [INFO] [stderr] 59 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:60:25 [INFO] [stderr] | [INFO] [stderr] 60 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | y: y [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | gl: gl, [INFO] [stderr] | ^^^^^^ help: replace it with: `gl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | window_size: window_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `window_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | world_state: world_state, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `world_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:237:35 [INFO] [stderr] | [INFO] [stderr] 237 | let cell = CellPosition { x: x, y: y }; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:237:41 [INFO] [stderr] | [INFO] [stderr] 237 | let cell = CellPosition { x: x, y: y }; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Button`, `RenderArgs`, `UpdateArgs` [INFO] [stderr] --> src/life.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | RenderArgs, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] 24 | UpdateArgs, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] 25 | Button, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/world.rs:138:21 [INFO] [stderr] | [INFO] [stderr] 138 | let num_cells = (size_x * size_y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::default::Default` [INFO] [stderr] --> src/game.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::default::Default; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `PressEvent` [INFO] [stderr] --> src/game.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | PressEvent, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `piston::window::Size` [INFO] [stderr] --> src/game.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use piston::window::Size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Button`, `RenderArgs`, `UpdateArgs` [INFO] [stderr] --> src/life.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | RenderArgs, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] 24 | UpdateArgs, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] 25 | Button, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/world.rs:138:21 [INFO] [stderr] | [INFO] [stderr] 138 | let num_cells = (size_x * size_y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::default::Default` [INFO] [stderr] --> src/game.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::default::Default; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `PressEvent` [INFO] [stderr] --> src/game.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | PressEvent, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `piston::window::Size` [INFO] [stderr] --> src/game.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use piston::window::Size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `AdvancedWindow` [INFO] [stderr] --> src/life.rs:14:23 [INFO] [stderr] | [INFO] [stderr] 14 | use piston::window::{ AdvancedWindow, WindowSettings }; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/game.rs:88:28 [INFO] [stderr] | [INFO] [stderr] 88 | pub fn tick(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/world.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / match self._alive_cells.contains(&cell) { [INFO] [stderr] 33 | | true => CellState::Alive, [INFO] [stderr] 34 | | false => CellState::Dead, [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self._alive_cells.contains(&cell) { CellState::Alive } else { CellState::Dead }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world.rs:124:12 [INFO] [stderr] | [INFO] [stderr] 124 | cells: &Vec<(CellPosition, CellState)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(CellPosition, CellState)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/game.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | let ref mut gl = self.gl; [INFO] [stderr] | ----^^^^^^^^^^----------- help: try: `let gl = &mut self.gl;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/game.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | / match is_ticking { [INFO] [stderr] 67 | | true => clear(RUNNING_BG, gl), [INFO] [stderr] 68 | | false => clear(PAUSED_BG, gl), [INFO] [stderr] 69 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if is_ticking { clear(RUNNING_BG, gl) } else { clear(PAUSED_BG, gl) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:78:25 [INFO] [stderr] | [INFO] [stderr] 78 | cx as f64, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(cx)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:79:25 [INFO] [stderr] | [INFO] [stderr] 79 | cy as f64, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(cy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:88:34 [INFO] [stderr] | [INFO] [stderr] 88 | pub fn tick(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:149:14 [INFO] [stderr] | [INFO] [stderr] 149 | (wx as f64 / self.block_size) as i32, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(wx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:150:14 [INFO] [stderr] | [INFO] [stderr] 150 | (wy as f64 / self.block_size) as i32, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(wy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused import: `AdvancedWindow` [INFO] [stderr] --> src/life.rs:14:23 [INFO] [stderr] | [INFO] [stderr] 14 | use piston::window::{ AdvancedWindow, WindowSettings }; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/game.rs:88:28 [INFO] [stderr] | [INFO] [stderr] 88 | pub fn tick(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/world.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / match self._alive_cells.contains(&cell) { [INFO] [stderr] 33 | | true => CellState::Alive, [INFO] [stderr] 34 | | false => CellState::Dead, [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self._alive_cells.contains(&cell) { CellState::Alive } else { CellState::Dead }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world.rs:124:12 [INFO] [stderr] | [INFO] [stderr] 124 | cells: &Vec<(CellPosition, CellState)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(CellPosition, CellState)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/game.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | let ref mut gl = self.gl; [INFO] [stderr] | ----^^^^^^^^^^----------- help: try: `let gl = &mut self.gl;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/game.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | / match is_ticking { [INFO] [stderr] 67 | | true => clear(RUNNING_BG, gl), [INFO] [stderr] 68 | | false => clear(PAUSED_BG, gl), [INFO] [stderr] 69 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if is_ticking { clear(RUNNING_BG, gl) } else { clear(PAUSED_BG, gl) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:78:25 [INFO] [stderr] | [INFO] [stderr] 78 | cx as f64, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(cx)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:79:25 [INFO] [stderr] | [INFO] [stderr] 79 | cy as f64, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(cy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:88:34 [INFO] [stderr] | [INFO] [stderr] 88 | pub fn tick(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:149:14 [INFO] [stderr] | [INFO] [stderr] 149 | (wx as f64 / self.block_size) as i32, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(wx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:150:14 [INFO] [stderr] | [INFO] [stderr] 150 | (wy as f64 / self.block_size) as i32, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(wy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 02s [INFO] running `"docker" "inspect" "c1ffadcf04fa40e50cdb589b964d7ed3dbab1a14c517b3e08963e50d430e76e5"` [INFO] running `"docker" "rm" "-f" "c1ffadcf04fa40e50cdb589b964d7ed3dbab1a14c517b3e08963e50d430e76e5"` [INFO] [stdout] c1ffadcf04fa40e50cdb589b964d7ed3dbab1a14c517b3e08963e50d430e76e5