[INFO] updating cached repository joaodelgado/rustyboy
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/joaodelgado/rustyboy
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/joaodelgado/rustyboy" "work/ex/clippy-test-run/sources/stable/gh/joaodelgado/rustyboy"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/joaodelgado/rustyboy'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/joaodelgado/rustyboy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joaodelgado/rustyboy"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joaodelgado/rustyboy'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 7ea4eca44fb5356782beb9f4bdcc02bb1bd53b9e
[INFO] sha for GitHub repo joaodelgado/rustyboy: 7ea4eca44fb5356782beb9f4bdcc02bb1bd53b9e
[INFO] validating manifest of joaodelgado/rustyboy on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of joaodelgado/rustyboy on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing joaodelgado/rustyboy
[INFO] finished frobbing joaodelgado/rustyboy
[INFO] frobbed toml for joaodelgado/rustyboy written to work/ex/clippy-test-run/sources/stable/gh/joaodelgado/rustyboy/Cargo.toml
[INFO] started frobbing joaodelgado/rustyboy
[INFO] finished frobbing joaodelgado/rustyboy
[INFO] frobbed toml for joaodelgado/rustyboy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joaodelgado/rustyboy/Cargo.toml
[INFO] crate joaodelgado/rustyboy has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting joaodelgado/rustyboy against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/joaodelgado/rustyboy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6ad0e2351a3b8e62f869563b2d3ec4cf26efb89493412fd4b6230e929c867b72
[INFO] running `"docker" "start" "-a" "6ad0e2351a3b8e62f869563b2d3ec4cf26efb89493412fd4b6230e929c867b72"`
[INFO] [stderr]     Checking rustyboy v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes
[INFO] [stderr]   --> src/cpu/mod.rs:79:5
[INFO] [stderr]    |
[INFO] [stderr] 79 |     #[cfg_attr(rustfmt, rustfmt_skip)]
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::deprecated_cfg_attr)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr
[INFO] [stderr] 
[INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes
[INFO] [stderr]   --> src/cpu/mod.rs:79:5
[INFO] [stderr]    |
[INFO] [stderr] 79 |     #[cfg_attr(rustfmt, rustfmt_skip)]
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::deprecated_cfg_attr)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/cpu/test/logic.rs:341:13
[INFO] [stderr]     |
[INFO] [stderr] 341 |     cpu.a = 0b00000011;
[INFO] [stderr]     |             ^^^^^^^^^^ help: consider: `0b0000_0011`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/cpu/test/logic.rs:342:13
[INFO] [stderr]     |
[INFO] [stderr] 342 |     cpu.c = 0b00010011;
[INFO] [stderr]     |             ^^^^^^^^^^ help: consider: `0b0001_0011`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/cpu/test/logic.rs:389:13
[INFO] [stderr]     |
[INFO] [stderr] 389 |     cpu.a = 0b10000001;
[INFO] [stderr]     |             ^^^^^^^^^^ help: consider: `0b1000_0001`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/cpu/test/logic.rs:393:23
[INFO] [stderr]     |
[INFO] [stderr] 393 |     assert_eq!(cpu.a, 0b00000011);
[INFO] [stderr]     |                       ^^^^^^^^^^ help: consider: `0b0000_0011`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `cpu.a`
[INFO] [stderr]    --> src/cpu/test/alu.rs:419:18
[INFO] [stderr]     |
[INFO] [stderr] 419 |     let result = cpu.a + 0x00;
[INFO] [stderr]     |                  ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `cpu.get_hl()`
[INFO] [stderr]    --> src/cpu/test/alu.rs:554:18
[INFO] [stderr]     |
[INFO] [stderr] 554 |     let result = cpu.get_hl() + 0x0000;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 26
[INFO] [stderr]    --> src/cpu/test/alu.rs:636:1
[INFO] [stderr]     |
[INFO] [stderr] 636 | / fn test_add_sp_r8() {
[INFO] [stderr] 637 | |     let new_cpu = || {
[INFO] [stderr] 638 | |         let mut cpu = Cpu::new();
[INFO] [stderr] 639 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 726 | |     assert!(cpu.flag(&Flag::Carry));
[INFO] [stderr] 727 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 32
[INFO] [stderr]    --> src/cpu/test/alu.rs:729:1
[INFO] [stderr]     |
[INFO] [stderr] 729 | / fn _test_adc_a<S>(opcode: u8, r: S, is_a: bool)
[INFO] [stderr] 730 | | where
[INFO] [stderr] 731 | |     S: Fn(&mut Cpu, u8),
[INFO] [stderr] 732 | | {
[INFO] [stderr] ...   |
[INFO] [stderr] 832 | |     }
[INFO] [stderr] 833 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `cpu.a`
[INFO] [stderr]    --> src/cpu/test/alu.rs:754:18
[INFO] [stderr]     |
[INFO] [stderr] 754 |     let result = cpu.a + 0x00 + carry;
[INFO] [stderr]     |                  ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `cpu.a`
[INFO] [stderr]    --> src/cpu/test/alu.rs:921:18
[INFO] [stderr]     |
[INFO] [stderr] 921 |     let result = cpu.a - 0x00;
[INFO] [stderr]     |                  ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/test/jump.rs:118:40
[INFO] [stderr]     |
[INFO] [stderr] 118 |         assert_eq!(cpu.pc, inital_pc + (jump as u16) + 2);
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^ help: try: `u16::from(jump)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/test/jump.rs:138:40
[INFO] [stderr]     |
[INFO] [stderr] 138 |         assert_eq!(cpu.pc, inital_pc + (jump as u16) + 2);
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^ help: try: `u16::from(jump)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 31
[INFO] [stderr]    --> src/cpu/test/load.rs:658:1
[INFO] [stderr]     |
[INFO] [stderr] 658 | / fn test_ldhl_sp_r8() {
[INFO] [stderr] 659 | |     let new_cpu = || {
[INFO] [stderr] 660 | |         let mut cpu = Cpu::new();
[INFO] [stderr] 661 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 753 | |     assert!(cpu.flag(&Flag::Carry));
[INFO] [stderr] 754 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.51s
[INFO] running `"docker" "inspect" "6ad0e2351a3b8e62f869563b2d3ec4cf26efb89493412fd4b6230e929c867b72"`
[INFO] running `"docker" "rm" "-f" "6ad0e2351a3b8e62f869563b2d3ec4cf26efb89493412fd4b6230e929c867b72"`
[INFO] [stdout] 6ad0e2351a3b8e62f869563b2d3ec4cf26efb89493412fd4b6230e929c867b72