[INFO] updating cached repository jnordberg/AdventOfCode2016 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jnordberg/AdventOfCode2016 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jnordberg/AdventOfCode2016" "work/ex/clippy-test-run/sources/stable/gh/jnordberg/AdventOfCode2016"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jnordberg/AdventOfCode2016'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jnordberg/AdventOfCode2016" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jnordberg/AdventOfCode2016"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jnordberg/AdventOfCode2016'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 47b68a52dce461c7322abba9bafef24fc34b79ba [INFO] sha for GitHub repo jnordberg/AdventOfCode2016: 47b68a52dce461c7322abba9bafef24fc34b79ba [INFO] validating manifest of jnordberg/AdventOfCode2016 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jnordberg/AdventOfCode2016 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jnordberg/AdventOfCode2016 [INFO] finished frobbing jnordberg/AdventOfCode2016 [INFO] frobbed toml for jnordberg/AdventOfCode2016 written to work/ex/clippy-test-run/sources/stable/gh/jnordberg/AdventOfCode2016/Cargo.toml [INFO] started frobbing jnordberg/AdventOfCode2016 [INFO] finished frobbing jnordberg/AdventOfCode2016 [INFO] frobbed toml for jnordberg/AdventOfCode2016 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jnordberg/AdventOfCode2016/Cargo.toml [INFO] crate jnordberg/AdventOfCode2016 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jnordberg/AdventOfCode2016 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jnordberg/AdventOfCode2016:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f89357254011fc67c3d860b0151bdd254c864383f65035036d8e5f82a6204bf3 [INFO] running `"docker" "start" "-a" "f89357254011fc67c3d860b0151bdd254c864383f65035036d8e5f82a6204bf3"` [INFO] [stderr] Checking md5 v0.3.2 [INFO] [stderr] Checking aoc16 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:25:31 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn manhattan_distance(&self, to: Point) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day04.rs:78:26 [INFO] [stderr] | [INFO] [stderr] 78 | let room = Room {encrypted_name: encrypted_name, sector_id: sector_id, checksum: checksum}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `encrypted_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day04.rs:78:58 [INFO] [stderr] | [INFO] [stderr] 78 | let room = Room {encrypted_name: encrypted_name, sector_id: sector_id, checksum: checksum}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sector_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day04.rs:78:80 [INFO] [stderr] | [INFO] [stderr] 78 | let room = Room {encrypted_name: encrypted_name, sector_id: sector_id, checksum: checksum}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day04.rs:78:26 [INFO] [stderr] | [INFO] [stderr] 78 | let room = Room {encrypted_name: encrypted_name, sector_id: sector_id, checksum: checksum}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `encrypted_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day04.rs:78:58 [INFO] [stderr] | [INFO] [stderr] 78 | let room = Room {encrypted_name: encrypted_name, sector_id: sector_id, checksum: checksum}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sector_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day04.rs:78:80 [INFO] [stderr] | [INFO] [stderr] 78 | let room = Room {encrypted_name: encrypted_name, sector_id: sector_id, checksum: checksum}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:25:31 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn manhattan_distance(&self, to: Point) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day01.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / return match *self { [INFO] [stderr] 34 | | Cardinal::West => Cardinal::South, [INFO] [stderr] 35 | | Cardinal::South => Cardinal::East, [INFO] [stderr] 36 | | Cardinal::East => Cardinal::North, [INFO] [stderr] 37 | | Cardinal::North => Cardinal::West, [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | match *self { [INFO] [stderr] 34 | Cardinal::West => Cardinal::South, [INFO] [stderr] 35 | Cardinal::South => Cardinal::East, [INFO] [stderr] 36 | Cardinal::East => Cardinal::North, [INFO] [stderr] 37 | Cardinal::North => Cardinal::West, [INFO] [stderr] 38 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day01.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / return match *self { [INFO] [stderr] 43 | | Cardinal::North => Cardinal::East, [INFO] [stderr] 44 | | Cardinal::East => Cardinal::South, [INFO] [stderr] 45 | | Cardinal::South => Cardinal::West, [INFO] [stderr] 46 | | Cardinal::West => Cardinal::North, [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 42 | match *self { [INFO] [stderr] 43 | Cardinal::North => Cardinal::East, [INFO] [stderr] 44 | Cardinal::East => Cardinal::South, [INFO] [stderr] 45 | Cardinal::South => Cardinal::West, [INFO] [stderr] 46 | Cardinal::West => Cardinal::North, [INFO] [stderr] 47 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day03.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day01.rs:63:36 [INFO] [stderr] | [INFO] [stderr] 63 | for instruction in input.split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/day03.rs:4:29 [INFO] [stderr] | [INFO] [stderr] 4 | fn is_valid_triangle(sides: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/bin/day03.rs:7:12 [INFO] [stderr] | [INFO] [stderr] 7 | if side >= &other { [INFO] [stderr] | ^^^^^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `other` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bin/day03.rs:26:21 [INFO] [stderr] | [INFO] [stderr] 26 | let sides = unwrapped_line.split(' ').into_iter() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `unwrapped_line.split(' ')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/day03.rs:27:25 [INFO] [stderr] | [INFO] [stderr] 27 | .filter(|&v|v.len() > 0) [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day03.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day02.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | return Keypad {pos: start_pos.unwrap(), buttons: button_lookup} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Keypad {pos: start_pos.unwrap(), buttons: button_lookup}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day02.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | return *self.buttons.get(&self.pos).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*self.buttons.get(&self.pos).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day02.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day02.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day02.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | return keypad.active_button(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `keypad.active_button()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day02.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | return Keypad {pos: start_pos.unwrap(), buttons: button_lookup} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Keypad {pos: start_pos.unwrap(), buttons: button_lookup}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day02.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | return *self.buttons.get(&self.pos).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*self.buttons.get(&self.pos).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day02.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day02.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day02.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | return keypad.active_button(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `keypad.active_button()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bin/day02.rs:30:34 [INFO] [stderr] | [INFO] [stderr] 30 | start_pos = Some(pos.clone()) [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/day02.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | return *self.buttons.get(&self.pos).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.buttons[&self.pos]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/day02.rs:45:22 [INFO] [stderr] | [INFO] [stderr] 45 | let button = self.buttons.get(&pos).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.buttons[&pos]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/day02.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | / if *button == '_' { [INFO] [stderr] 47 | | return false; [INFO] [stderr] 48 | | } else { [INFO] [stderr] 49 | | return true; [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `return !(*button == '_')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/bin/day02.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | if self.is_valid_pos(new_pos) == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.is_valid_pos(new_pos)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day06.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return CharCount { counters: HashMap::new() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CharCount { counters: HashMap::new() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day06.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return self.counters.entry(pos).or_insert(HashMap::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.counters.entry(pos).or_insert(HashMap::new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day06.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | return rv; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `rv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day06.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return rv; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `rv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/day03.rs:4:29 [INFO] [stderr] | [INFO] [stderr] 4 | fn is_valid_triangle(sides: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/bin/day03.rs:7:12 [INFO] [stderr] | [INFO] [stderr] 7 | if side >= &other { [INFO] [stderr] | ^^^^^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `other` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bin/day03.rs:26:21 [INFO] [stderr] | [INFO] [stderr] 26 | let sides = unwrapped_line.split(' ').into_iter() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `unwrapped_line.split(' ')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/day03.rs:27:25 [INFO] [stderr] | [INFO] [stderr] 27 | .filter(|&v|v.len() > 0) [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bin/day02.rs:30:34 [INFO] [stderr] | [INFO] [stderr] 30 | start_pos = Some(pos.clone()) [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/day02.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | return *self.buttons.get(&self.pos).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.buttons[&self.pos]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/day02.rs:45:22 [INFO] [stderr] | [INFO] [stderr] 45 | let button = self.buttons.get(&pos).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.buttons[&pos]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/day02.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | / if *button == '_' { [INFO] [stderr] 47 | | return false; [INFO] [stderr] 48 | | } else { [INFO] [stderr] 49 | | return true; [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `return !(*button == '_')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/bin/day02.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | if self.is_valid_pos(new_pos) == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.is_valid_pos(new_pos)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/bin/day06.rs:18:41 [INFO] [stderr] | [INFO] [stderr] 18 | return self.counters.entry(pos).or_insert(HashMap::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashMap::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day04.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | return a.0.cmp(b.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a.0.cmp(b.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day04.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | return count_order; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `count_order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day04.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | return checksum == self.checksum; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `checksum == self.checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day04.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | return rv; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `rv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day04.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | return a.0.cmp(b.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a.0.cmp(b.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day04.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | return count_order; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `count_order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day04.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | return checksum == self.checksum; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `checksum == self.checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day04.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | return rv; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `rv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day01.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / return match *self { [INFO] [stderr] 34 | | Cardinal::West => Cardinal::South, [INFO] [stderr] 35 | | Cardinal::South => Cardinal::East, [INFO] [stderr] 36 | | Cardinal::East => Cardinal::North, [INFO] [stderr] 37 | | Cardinal::North => Cardinal::West, [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | match *self { [INFO] [stderr] 34 | Cardinal::West => Cardinal::South, [INFO] [stderr] 35 | Cardinal::South => Cardinal::East, [INFO] [stderr] 36 | Cardinal::East => Cardinal::North, [INFO] [stderr] 37 | Cardinal::North => Cardinal::West, [INFO] [stderr] 38 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day01.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / return match *self { [INFO] [stderr] 43 | | Cardinal::North => Cardinal::East, [INFO] [stderr] 44 | | Cardinal::East => Cardinal::South, [INFO] [stderr] 45 | | Cardinal::South => Cardinal::West, [INFO] [stderr] 46 | | Cardinal::West => Cardinal::North, [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 42 | match *self { [INFO] [stderr] 43 | Cardinal::North => Cardinal::East, [INFO] [stderr] 44 | Cardinal::East => Cardinal::South, [INFO] [stderr] 45 | Cardinal::South => Cardinal::West, [INFO] [stderr] 46 | Cardinal::West => Cardinal::North, [INFO] [stderr] 47 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day01.rs:63:36 [INFO] [stderr] | [INFO] [stderr] 63 | for instruction in input.split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bin/day05.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | let ref door_id:String = args[1]; [INFO] [stderr] | ----^^^^^^^^^^^------------------ help: try: `let door_id: &String = &args[1];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/bin/day05.rs:23:12 [INFO] [stderr] | [INFO] [stderr] 23 | if hash[0..5].to_string() == "00000" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `hash[0..5]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day06.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return CharCount { counters: HashMap::new() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CharCount { counters: HashMap::new() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day06.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return self.counters.entry(pos).or_insert(HashMap::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.counters.entry(pos).or_insert(HashMap::new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day06.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | return rv; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `rv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day06.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return rv; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `rv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bin/day05.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | let ref door_id:String = args[1]; [INFO] [stderr] | ----^^^^^^^^^^^------------------ help: try: `let door_id: &String = &args[1];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/bin/day05.rs:23:12 [INFO] [stderr] | [INFO] [stderr] 23 | if hash[0..5].to_string() == "00000" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `hash[0..5]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/bin/day06.rs:18:41 [INFO] [stderr] | [INFO] [stderr] 18 | return self.counters.entry(pos).or_insert(HashMap::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashMap::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.20s [INFO] running `"docker" "inspect" "f89357254011fc67c3d860b0151bdd254c864383f65035036d8e5f82a6204bf3"` [INFO] running `"docker" "rm" "-f" "f89357254011fc67c3d860b0151bdd254c864383f65035036d8e5f82a6204bf3"` [INFO] [stdout] f89357254011fc67c3d860b0151bdd254c864383f65035036d8e5f82a6204bf3