[INFO] updating cached repository jneumann/Rust-RSS-Reader [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jneumann/Rust-RSS-Reader [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jneumann/Rust-RSS-Reader" "work/ex/clippy-test-run/sources/stable/gh/jneumann/Rust-RSS-Reader"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jneumann/Rust-RSS-Reader'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jneumann/Rust-RSS-Reader" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jneumann/Rust-RSS-Reader"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jneumann/Rust-RSS-Reader'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 90935ac7313e5bd7b40ebeb8374f9786654254b4 [INFO] sha for GitHub repo jneumann/Rust-RSS-Reader: 90935ac7313e5bd7b40ebeb8374f9786654254b4 [INFO] validating manifest of jneumann/Rust-RSS-Reader on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jneumann/Rust-RSS-Reader on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jneumann/Rust-RSS-Reader [INFO] finished frobbing jneumann/Rust-RSS-Reader [INFO] frobbed toml for jneumann/Rust-RSS-Reader written to work/ex/clippy-test-run/sources/stable/gh/jneumann/Rust-RSS-Reader/Cargo.toml [INFO] started frobbing jneumann/Rust-RSS-Reader [INFO] finished frobbing jneumann/Rust-RSS-Reader [INFO] frobbed toml for jneumann/Rust-RSS-Reader written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jneumann/Rust-RSS-Reader/Cargo.toml [INFO] crate jneumann/Rust-RSS-Reader has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jneumann/Rust-RSS-Reader against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jneumann/Rust-RSS-Reader:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 57af3247ddc2bdf647751d7820578e0351882764a3e6c46aecfa5cc2b3398141 [INFO] running `"docker" "start" "-a" "57af3247ddc2bdf647751d7820578e0351882764a3e6c46aecfa5cc2b3398141"` [INFO] [stderr] Compiling openssl v0.9.12 [INFO] [stderr] Checking serde v1.0.9 [INFO] [stderr] Compiling backtrace-sys v0.1.11 [INFO] [stderr] Compiling openssl-sys v0.9.12 [INFO] [stderr] Checking libflate v0.1.8 [INFO] [stderr] Checking encoding_rs v0.6.11 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking hyper v0.10.10 [INFO] [stderr] Compiling curl-sys v0.3.11 [INFO] [stderr] Checking native-tls v0.1.2 [INFO] [stderr] Checking hyper-native-tls v0.2.2 [INFO] [stderr] Checking serde_json v1.0.2 [INFO] [stderr] Checking serde_urlencoded v0.5.1 [INFO] [stderr] Checking reqwest v0.6.2 [INFO] [stderr] Checking backtrace v0.3.2 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking quick-xml v0.8.0 [INFO] [stderr] Checking rss v0.6.1 [INFO] [stderr] Checking curl v0.4.6 [INFO] [stderr] Checking rss_reader v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | file [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | let file = BufReader::new(file); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | file [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | let file = BufReader::new(file); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `name` [INFO] [stderr] --> src/main.rs:36:41 [INFO] [stderr] | [INFO] [stderr] 36 | Ok(XmlEvent::StartElement { name, attributes, .. }) => { [INFO] [stderr] | ^^^^ help: try ignoring the field: `name: _` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | if title != "".to_string() && url != "".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:50:54 [INFO] [stderr] | [INFO] [stderr] 50 | if title != "".to_string() && url != "".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: the loop variable `index` is used to index `processed_file` [INFO] [stderr] --> src/main.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | for index in 1..processed_file.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 70 | for (index, ) in processed_file.iter().enumerate().skip(1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `channel_items`. [INFO] [stderr] --> src/main.rs:96:14 [INFO] [stderr] | [INFO] [stderr] 96 | for i in 0..5 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 96 | for in channel_items.iter().take(5) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | / match e { [INFO] [stderr] 102 | | Ok(Characters(data)) => { [INFO] [stderr] 103 | | println!("{}", data); [INFO] [stderr] 104 | | }, [INFO] [stderr] 105 | | _ => {} [INFO] [stderr] 106 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 101 | if let Ok(Characters(data)) = e { [INFO] [stderr] 102 | println!("{}", data); [INFO] [stderr] 103 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `name` [INFO] [stderr] --> src/main.rs:36:41 [INFO] [stderr] | [INFO] [stderr] 36 | Ok(XmlEvent::StartElement { name, attributes, .. }) => { [INFO] [stderr] | ^^^^ help: try ignoring the field: `name: _` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | if title != "".to_string() && url != "".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:50:54 [INFO] [stderr] | [INFO] [stderr] 50 | if title != "".to_string() && url != "".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: the loop variable `index` is used to index `processed_file` [INFO] [stderr] --> src/main.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | for index in 1..processed_file.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 70 | for (index, ) in processed_file.iter().enumerate().skip(1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `channel_items`. [INFO] [stderr] --> src/main.rs:96:14 [INFO] [stderr] | [INFO] [stderr] 96 | for i in 0..5 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 96 | for in channel_items.iter().take(5) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | / match e { [INFO] [stderr] 102 | | Ok(Characters(data)) => { [INFO] [stderr] 103 | | println!("{}", data); [INFO] [stderr] 104 | | }, [INFO] [stderr] 105 | | _ => {} [INFO] [stderr] 106 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 101 | if let Ok(Characters(data)) = e { [INFO] [stderr] 102 | println!("{}", data); [INFO] [stderr] 103 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 08s [INFO] running `"docker" "inspect" "57af3247ddc2bdf647751d7820578e0351882764a3e6c46aecfa5cc2b3398141"` [INFO] running `"docker" "rm" "-f" "57af3247ddc2bdf647751d7820578e0351882764a3e6c46aecfa5cc2b3398141"` [INFO] [stdout] 57af3247ddc2bdf647751d7820578e0351882764a3e6c46aecfa5cc2b3398141