[INFO] updating cached repository jmodjeski/rust-datamodel-parser [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jmodjeski/rust-datamodel-parser [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jmodjeski/rust-datamodel-parser" "work/ex/clippy-test-run/sources/stable/gh/jmodjeski/rust-datamodel-parser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jmodjeski/rust-datamodel-parser'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jmodjeski/rust-datamodel-parser" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jmodjeski/rust-datamodel-parser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jmodjeski/rust-datamodel-parser'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2f57b4b96152be9d8f14539407ec9525c219dc32 [INFO] sha for GitHub repo jmodjeski/rust-datamodel-parser: 2f57b4b96152be9d8f14539407ec9525c219dc32 [INFO] validating manifest of jmodjeski/rust-datamodel-parser on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jmodjeski/rust-datamodel-parser on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jmodjeski/rust-datamodel-parser [INFO] finished frobbing jmodjeski/rust-datamodel-parser [INFO] frobbed toml for jmodjeski/rust-datamodel-parser written to work/ex/clippy-test-run/sources/stable/gh/jmodjeski/rust-datamodel-parser/Cargo.toml [INFO] started frobbing jmodjeski/rust-datamodel-parser [INFO] finished frobbing jmodjeski/rust-datamodel-parser [INFO] frobbed toml for jmodjeski/rust-datamodel-parser written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jmodjeski/rust-datamodel-parser/Cargo.toml [INFO] crate jmodjeski/rust-datamodel-parser has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jmodjeski/rust-datamodel-parser against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jmodjeski/rust-datamodel-parser:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5976784120b5f7158796f1733c00d07c6a7377d80fa238a80fb6933d0ad33611 [INFO] running `"docker" "start" "-a" "5976784120b5f7158796f1733c00d07c6a7377d80fa238a80fb6933d0ad33611"` [INFO] [stderr] Compiling peg v0.5.7 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Compiling syn v0.15.15 [INFO] [stderr] Compiling datamodel-parser v0.2.0 (/opt/crater/workdir) [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] warning: lint name `suspicious_else_formatting` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/datamodel_parser.rs:2:45 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(feature = "cargo-clippy", allow(suspicious_else_formatting, single_match, cyclomatic_complexity, unit_arg, naive_bytecount, len_zero))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::suspicious_else_formatting` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `single_match` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/datamodel_parser.rs:2:73 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(feature = "cargo-clippy", allow(suspicious_else_formatting, single_match, cyclomatic_complexity, unit_arg, naive_bytecount, len_zero))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::single_match` [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/datamodel_parser.rs:2:87 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(feature = "cargo-clippy", allow(suspicious_else_formatting, single_match, cyclomatic_complexity, unit_arg, naive_bytecount, len_zero))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `unit_arg` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/datamodel_parser.rs:2:110 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(feature = "cargo-clippy", allow(suspicious_else_formatting, single_match, cyclomatic_complexity, unit_arg, naive_bytecount, len_zero))] [INFO] [stderr] | ^^^^^^^^ help: change it to: `clippy::unit_arg` [INFO] [stderr] [INFO] [stderr] warning: lint name `naive_bytecount` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/datamodel_parser.rs:2:120 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(feature = "cargo-clippy", allow(suspicious_else_formatting, single_match, cyclomatic_complexity, unit_arg, naive_bytecount, len_zero))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::naive_bytecount` [INFO] [stderr] [INFO] [stderr] warning: lint name `len_zero` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/datamodel_parser.rs:2:137 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(feature = "cargo-clippy", allow(suspicious_else_formatting, single_match, cyclomatic_complexity, unit_arg, naive_bytecount, len_zero))] [INFO] [stderr] | ^^^^^^^^ help: change it to: `clippy::len_zero` [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/json_formatter.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | Ok(f) => return Ok(f), [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `Ok(f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/json_formatter.rs:16:23 [INFO] [stderr] | [INFO] [stderr] 16 | Err(e) => return Err(e.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/json_formatter.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | Ok(f) => return Ok(f), [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `Ok(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/json_formatter.rs:21:23 [INFO] [stderr] | [INFO] [stderr] 21 | Err(e) => return Err(e.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: lint name `suspicious_else_formatting` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/datamodel_parser.rs:2:45 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(feature = "cargo-clippy", allow(suspicious_else_formatting, single_match, cyclomatic_complexity, unit_arg, naive_bytecount, len_zero))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::suspicious_else_formatting` [INFO] [stderr] [INFO] [stderr] warning: lint name `suspicious_else_formatting` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/datamodel_parser.rs:2:45 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(feature = "cargo-clippy", allow(suspicious_else_formatting, single_match, cyclomatic_complexity, unit_arg, naive_bytecount, len_zero))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::suspicious_else_formatting` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `single_match` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/datamodel_parser.rs:2:73 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(feature = "cargo-clippy", allow(suspicious_else_formatting, single_match, cyclomatic_complexity, unit_arg, naive_bytecount, len_zero))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::single_match` [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/datamodel_parser.rs:2:87 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(feature = "cargo-clippy", allow(suspicious_else_formatting, single_match, cyclomatic_complexity, unit_arg, naive_bytecount, len_zero))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `unit_arg` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/datamodel_parser.rs:2:110 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(feature = "cargo-clippy", allow(suspicious_else_formatting, single_match, cyclomatic_complexity, unit_arg, naive_bytecount, len_zero))] [INFO] [stderr] | ^^^^^^^^ help: change it to: `clippy::unit_arg` [INFO] [stderr] [INFO] [stderr] warning: lint name `naive_bytecount` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/datamodel_parser.rs:2:120 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(feature = "cargo-clippy", allow(suspicious_else_formatting, single_match, cyclomatic_complexity, unit_arg, naive_bytecount, len_zero))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::naive_bytecount` [INFO] [stderr] [INFO] [stderr] warning: lint name `len_zero` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/datamodel_parser.rs:2:137 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(feature = "cargo-clippy", allow(suspicious_else_formatting, single_match, cyclomatic_complexity, unit_arg, naive_bytecount, len_zero))] [INFO] [stderr] | ^^^^^^^^ help: change it to: `clippy::len_zero` [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/json_formatter.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | Ok(f) => return Ok(f), [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `Ok(f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/json_formatter.rs:16:23 [INFO] [stderr] | [INFO] [stderr] 16 | Err(e) => return Err(e.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/json_formatter.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | Ok(f) => return Ok(f), [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `Ok(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/json_formatter.rs:21:23 [INFO] [stderr] | [INFO] [stderr] 21 | Err(e) => return Err(e.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: lint name `suspicious_else_formatting` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/datamodel_parser.rs:2:45 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(feature = "cargo-clippy", allow(suspicious_else_formatting, single_match, cyclomatic_complexity, unit_arg, naive_bytecount, len_zero))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::suspicious_else_formatting` [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/datamodel-parser-0d8ce415c391741c/out/datamodel_grammar.rs:156:2 [INFO] [stderr] | [INFO] [stderr] 156 | pub fn models < 'input > ( __input : & 'input str ) -> ParseResult < Vec > { # ! [ allow ( non_snake_case , unused ) ] let mut __state = ParseState :: new ( ) ; match __parse_models ( __input , & mut __state , 0 ) { Matched ( __pos , __value ) => { if __pos == __input . len ( ) { return Ok ( __value ) } } _ => { } } let ( __line , __col ) = pos_to_line ( __input , __state . max_err_pos ) ; Err ( ParseError { line : __line , column : __col , offset : __state . max_err_pos , expected : __state . expected , } ) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/dot_formatter.rs:51:55 [INFO] [stderr] | [INFO] [stderr] 51 | if field_type.starts_with("[") { [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/dot_formatter.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | let ref reffed = field.inner_type; [INFO] [stderr] | ----^^^^^^^^^^-------------------- help: try: `let reffed = &field.inner_type;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/dot_formatter.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | let ref reffed = field.inner_type; [INFO] [stderr] | ----^^^^^^^^^^-------------------- help: try: `let reffed = &field.inner_type;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/datamodel-parser-0d8ce415c391741c/out/datamodel_grammar.rs:156:2 [INFO] [stderr] | [INFO] [stderr] 156 | pub fn models < 'input > ( __input : & 'input str ) -> ParseResult < Vec > { # ! [ allow ( non_snake_case , unused ) ] let mut __state = ParseState :: new ( ) ; match __parse_models ( __input , & mut __state , 0 ) { Matched ( __pos , __value ) => { if __pos == __input . len ( ) { return Ok ( __value ) } } _ => { } } let ( __line , __col ) = pos_to_line ( __input , __state . max_err_pos ) ; Err ( ParseError { line : __line , column : __col , offset : __state . max_err_pos , expected : __state . expected , } ) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/dot_formatter.rs:51:55 [INFO] [stderr] | [INFO] [stderr] 51 | if field_type.starts_with("[") { [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/dot_formatter.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | let ref reffed = field.inner_type; [INFO] [stderr] | ----^^^^^^^^^^-------------------- help: try: `let reffed = &field.inner_type;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/dot_formatter.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | let ref reffed = field.inner_type; [INFO] [stderr] | ----^^^^^^^^^^-------------------- help: try: `let reffed = &field.inner_type;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.44s [INFO] running `"docker" "inspect" "5976784120b5f7158796f1733c00d07c6a7377d80fa238a80fb6933d0ad33611"` [INFO] running `"docker" "rm" "-f" "5976784120b5f7158796f1733c00d07c6a7377d80fa238a80fb6933d0ad33611"` [INFO] [stdout] 5976784120b5f7158796f1733c00d07c6a7377d80fa238a80fb6933d0ad33611