[INFO] updating cached repository jmcelwain/the_linux_programming_interface [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jmcelwain/the_linux_programming_interface [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jmcelwain/the_linux_programming_interface" "work/ex/clippy-test-run/sources/stable/gh/jmcelwain/the_linux_programming_interface"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jmcelwain/the_linux_programming_interface'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jmcelwain/the_linux_programming_interface" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jmcelwain/the_linux_programming_interface"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jmcelwain/the_linux_programming_interface'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 20d87244e4a21b0c11f1818de6e85d89b1648b19 [INFO] sha for GitHub repo jmcelwain/the_linux_programming_interface: 20d87244e4a21b0c11f1818de6e85d89b1648b19 [INFO] validating manifest of jmcelwain/the_linux_programming_interface on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jmcelwain/the_linux_programming_interface on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jmcelwain/the_linux_programming_interface [INFO] finished frobbing jmcelwain/the_linux_programming_interface [INFO] frobbed toml for jmcelwain/the_linux_programming_interface written to work/ex/clippy-test-run/sources/stable/gh/jmcelwain/the_linux_programming_interface/Cargo.toml [INFO] started frobbing jmcelwain/the_linux_programming_interface [INFO] finished frobbing jmcelwain/the_linux_programming_interface [INFO] frobbed toml for jmcelwain/the_linux_programming_interface written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jmcelwain/the_linux_programming_interface/Cargo.toml [INFO] crate jmcelwain/the_linux_programming_interface has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jmcelwain/the_linux_programming_interface against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jmcelwain/the_linux_programming_interface:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9a7a52394fba0b09e4cb2771b77aa514d72bbee5a7cf712afce747a10952dca0 [INFO] running `"docker" "start" "-a" "9a7a52394fba0b09e4cb2771b77aa514d72bbee5a7cf712afce747a10952dca0"` [INFO] [stderr] Checking linux_interface v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `to_path` [INFO] [stderr] --> src/fileio/copy.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | let to_path = Path::new(to); [INFO] [stderr] | ^^^^^^^ help: consider using `_to_path` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file` [INFO] [stderr] --> src/fileio/copy.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | let file = match File::open(&from) { [INFO] [stderr] | ^^^^ help: consider using `_file` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `to_path` [INFO] [stderr] --> src/fileio/copy.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | let to_path = Path::new(to); [INFO] [stderr] | ^^^^^^^ help: consider using `_to_path` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file` [INFO] [stderr] --> src/fileio/copy.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | let file = match File::open(&from) { [INFO] [stderr] | ^^^^ help: consider using `_file` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `copy` [INFO] [stderr] --> src/fileio/copy.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn copy(from: &String, to: &String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/fileio/copy.rs:4:19 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn copy(from: &String, to: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/fileio/copy.rs:4:32 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn copy(from: &String, to: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: function is never used: `copy` [INFO] [stderr] --> src/fileio/copy.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn copy(from: &String, to: &String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/fileio/copy.rs:4:19 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn copy(from: &String, to: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/fileio/copy.rs:4:32 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn copy(from: &String, to: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.73s [INFO] running `"docker" "inspect" "9a7a52394fba0b09e4cb2771b77aa514d72bbee5a7cf712afce747a10952dca0"` [INFO] running `"docker" "rm" "-f" "9a7a52394fba0b09e4cb2771b77aa514d72bbee5a7cf712afce747a10952dca0"` [INFO] [stdout] 9a7a52394fba0b09e4cb2771b77aa514d72bbee5a7cf712afce747a10952dca0