[INFO] updating cached repository jmageau/advent_of_code [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jmageau/advent_of_code [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jmageau/advent_of_code" "work/ex/clippy-test-run/sources/stable/gh/jmageau/advent_of_code"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jmageau/advent_of_code'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jmageau/advent_of_code" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jmageau/advent_of_code"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jmageau/advent_of_code'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 15ca824ed9e29267e35a55abdc929063be13a57a [INFO] sha for GitHub repo jmageau/advent_of_code: 15ca824ed9e29267e35a55abdc929063be13a57a [INFO] validating manifest of jmageau/advent_of_code on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jmageau/advent_of_code on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jmageau/advent_of_code [INFO] finished frobbing jmageau/advent_of_code [INFO] frobbed toml for jmageau/advent_of_code written to work/ex/clippy-test-run/sources/stable/gh/jmageau/advent_of_code/Cargo.toml [INFO] started frobbing jmageau/advent_of_code [INFO] finished frobbing jmageau/advent_of_code [INFO] frobbed toml for jmageau/advent_of_code written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jmageau/advent_of_code/Cargo.toml [INFO] crate jmageau/advent_of_code has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jmageau/advent_of_code against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jmageau/advent_of_code:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 32b978ba81a49084934997d84edf508cdf531f4bfa1370f28682904f3159c958 [INFO] running `"docker" "start" "-a" "32b978ba81a49084934997d84edf508cdf531f4bfa1370f28682904f3159c958"` [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking advent_of_code v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/year_2018/day_9.rs:12:19 [INFO] [stderr] | [INFO] [stderr] 12 | run_game(432, 7101900).to_string() [INFO] [stderr] | ^^^^^^^ help: consider: `7_101_900` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/year_2018/day_9.rs:12:19 [INFO] [stderr] | [INFO] [stderr] 12 | run_game(432, 7101900).to_string() [INFO] [stderr] | ^^^^^^^ help: consider: `7_101_900` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/year_2018/day_10.rs:98:24 [INFO] [stderr] | [INFO] [stderr] 98 | let c = if points.iter().find(|p| p.x == x && p.y == y).is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|p| p.x == x && p.y == y).is_some()` with `any(|p| p.x == x && p.y == y)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/year_2018/day_11.rs:33:30 [INFO] [stderr] | [INFO] [stderr] 33 | fn get_largest_square(cells: &Vec, square_size: usize) -> ((usize, usize), isize) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[isize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/year_2018/day_11.rs:54:35 [INFO] [stderr] | [INFO] [stderr] 54 | fn get_largest_square_size(cells: &Vec) -> (usize, usize, usize) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[isize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/year_2018/day_10.rs:98:24 [INFO] [stderr] | [INFO] [stderr] 98 | let c = if points.iter().find(|p| p.x == x && p.y == y).is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|p| p.x == x && p.y == y).is_some()` with `any(|p| p.x == x && p.y == y)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/year_2018/day_11.rs:33:30 [INFO] [stderr] | [INFO] [stderr] 33 | fn get_largest_square(cells: &Vec, square_size: usize) -> ((usize, usize), isize) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[isize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/year_2018/day_11.rs:54:35 [INFO] [stderr] | [INFO] [stderr] 54 | fn get_largest_square_size(cells: &Vec) -> (usize, usize, usize) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[isize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.58s [INFO] running `"docker" "inspect" "32b978ba81a49084934997d84edf508cdf531f4bfa1370f28682904f3159c958"` [INFO] running `"docker" "rm" "-f" "32b978ba81a49084934997d84edf508cdf531f4bfa1370f28682904f3159c958"` [INFO] [stdout] 32b978ba81a49084934997d84edf508cdf531f4bfa1370f28682904f3159c958