[INFO] updating cached repository jmacdonald/reference-iterator
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jmacdonald/reference-iterator
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jmacdonald/reference-iterator" "work/ex/clippy-test-run/sources/stable/gh/jmacdonald/reference-iterator"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jmacdonald/reference-iterator'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jmacdonald/reference-iterator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jmacdonald/reference-iterator"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jmacdonald/reference-iterator'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 453b31520657aa3cd6b54dd7d0aba9d27c63ffcd
[INFO] sha for GitHub repo jmacdonald/reference-iterator: 453b31520657aa3cd6b54dd7d0aba9d27c63ffcd
[INFO] validating manifest of jmacdonald/reference-iterator on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jmacdonald/reference-iterator on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jmacdonald/reference-iterator
[INFO] finished frobbing jmacdonald/reference-iterator
[INFO] frobbed toml for jmacdonald/reference-iterator written to work/ex/clippy-test-run/sources/stable/gh/jmacdonald/reference-iterator/Cargo.toml
[INFO] started frobbing jmacdonald/reference-iterator
[INFO] finished frobbing jmacdonald/reference-iterator
[INFO] frobbed toml for jmacdonald/reference-iterator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jmacdonald/reference-iterator/Cargo.toml
[INFO] crate jmacdonald/reference-iterator has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jmacdonald/reference-iterator against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jmacdonald/reference-iterator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 1cdd43690e3a21ea91571dae9a2d119a7641c13901ecf80746b96a91d5bdc000
[INFO] running `"docker" "start" "-a" "1cdd43690e3a21ea91571dae9a2d119a7641c13901ecf80746b96a91d5bdc000"`
[INFO] [stderr]     Checking reference-iterator v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]  --> src/main.rs:7:19
[INFO] [stderr]   |
[INFO] [stderr] 7 |         TokenSet{ data: data }
[INFO] [stderr]   |                   ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:24:13
[INFO] [stderr]    |
[INFO] [stderr] 24 |             data: data,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]  --> src/main.rs:7:19
[INFO] [stderr]   |
[INFO] [stderr] 7 |         TokenSet{ data: data }
[INFO] [stderr]   |                   ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:24:13
[INFO] [stderr]    |
[INFO] [stderr] 24 |             data: data,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/main.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | /     pub fn iter<'a>(&'a self) -> TokenIterator<'a> {
[INFO] [stderr] 11 | |         TokenIterator::new(&self.data)
[INFO] [stderr] 12 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:55:18
[INFO] [stderr]    |
[INFO] [stderr] 55 |                 .unwrap_or(self.data.len());
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.data.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/main.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | /     pub fn iter<'a>(&'a self) -> TokenIterator<'a> {
[INFO] [stderr] 11 | |         TokenIterator::new(&self.data)
[INFO] [stderr] 12 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:55:18
[INFO] [stderr]    |
[INFO] [stderr] 55 |                 .unwrap_or(self.data.len());
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.data.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.53s
[INFO] running `"docker" "inspect" "1cdd43690e3a21ea91571dae9a2d119a7641c13901ecf80746b96a91d5bdc000"`
[INFO] running `"docker" "rm" "-f" "1cdd43690e3a21ea91571dae9a2d119a7641c13901ecf80746b96a91d5bdc000"`
[INFO] [stdout] 1cdd43690e3a21ea91571dae9a2d119a7641c13901ecf80746b96a91d5bdc000