[INFO] updating cached repository jlrickert/rusty [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jlrickert/rusty [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jlrickert/rusty" "work/ex/clippy-test-run/sources/stable/gh/jlrickert/rusty"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jlrickert/rusty'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jlrickert/rusty" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jlrickert/rusty"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jlrickert/rusty'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8c6f28451a73425db469616de8ccd57e8c3cb6f2 [INFO] sha for GitHub repo jlrickert/rusty: 8c6f28451a73425db469616de8ccd57e8c3cb6f2 [INFO] validating manifest of jlrickert/rusty on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jlrickert/rusty on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jlrickert/rusty [INFO] finished frobbing jlrickert/rusty [INFO] frobbed toml for jlrickert/rusty written to work/ex/clippy-test-run/sources/stable/gh/jlrickert/rusty/Cargo.toml [INFO] started frobbing jlrickert/rusty [INFO] finished frobbing jlrickert/rusty [INFO] frobbed toml for jlrickert/rusty written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jlrickert/rusty/Cargo.toml [INFO] crate jlrickert/rusty has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jlrickert/rusty against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jlrickert/rusty:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9b381f1af40742651f779684f65671fc40763e96dc1a9791970b18a24962cf45 [INFO] running `"docker" "start" "-a" "9b381f1af40742651f779684f65671fc40763e96dc1a9791970b18a24962cf45"` [INFO] [stderr] Checking simplelog v0.4.4 [INFO] [stderr] Checking MyBot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hlt/game_map.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | game: game, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `game` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hlt/game_map.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rusty/unit.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | behavior: behavior, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `behavior` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hlt/game_map.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | game: game, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `game` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hlt/game_map.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rusty/unit.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | behavior: behavior, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `behavior` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp::Eq` [INFO] [stderr] --> src/hlt/entity/position.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::cmp::Eq; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp::min` [INFO] [stderr] --> src/hlt/entity/ship.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::cmp::min; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hlt/entity/ship.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | return Some(target.position()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(target.position())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/hlt/game_map.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hlt/game_map.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `DockingStatus`, `Entity` [INFO] [stderr] --> src/rusty/bot.rs:6:19 [INFO] [stderr] | [INFO] [stderr] 6 | use hlt::entity::{Entity, DockingStatus}; [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp::min` [INFO] [stderr] --> src/rusty/unit.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::cmp::min; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `DOCK_RADIUS` [INFO] [stderr] --> src/rusty/unit.rs:5:33 [INFO] [stderr] | [INFO] [stderr] 5 | use hlt::constants::{MAX_SPEED, DOCK_RADIUS}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Planet` [INFO] [stderr] --> src/rusty/unit.rs:7:43 [INFO] [stderr] | [INFO] [stderr] 7 | use hlt::entity::{Entity, Ship, Position, Planet}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rusty/unit.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/rusty/unit.rs:273:24 [INFO] [stderr] | [INFO] [stderr] 273 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 274 | | if dist_a < dist_b { [INFO] [stderr] 275 | | Less [INFO] [stderr] 276 | | } else if dist_a == dist_b { [INFO] [stderr] ... | [INFO] [stderr] 280 | | } [INFO] [stderr] 281 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 273 | } else if dist_a < dist_b { [INFO] [stderr] 274 | Less [INFO] [stderr] 275 | } else if dist_a == dist_b { [INFO] [stderr] 276 | Equal [INFO] [stderr] 277 | } else { [INFO] [stderr] 278 | Greater [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp::Eq` [INFO] [stderr] --> src/hlt/entity/position.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::cmp::Eq; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp::min` [INFO] [stderr] --> src/hlt/entity/ship.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::cmp::min; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hlt/entity/ship.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | return Some(target.position()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(target.position())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/hlt/game_map.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hlt/game_map.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `DockingStatus`, `Entity` [INFO] [stderr] --> src/rusty/bot.rs:6:19 [INFO] [stderr] | [INFO] [stderr] 6 | use hlt::entity::{Entity, DockingStatus}; [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp::min` [INFO] [stderr] --> src/rusty/unit.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::cmp::min; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `DOCK_RADIUS` [INFO] [stderr] --> src/rusty/unit.rs:5:33 [INFO] [stderr] | [INFO] [stderr] 5 | use hlt::constants::{MAX_SPEED, DOCK_RADIUS}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Planet` [INFO] [stderr] --> src/rusty/unit.rs:7:43 [INFO] [stderr] | [INFO] [stderr] 7 | use hlt::entity::{Entity, Ship, Position, Planet}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rusty/unit.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/rusty/unit.rs:273:24 [INFO] [stderr] | [INFO] [stderr] 273 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 274 | | if dist_a < dist_b { [INFO] [stderr] 275 | | Less [INFO] [stderr] 276 | | } else if dist_a == dist_b { [INFO] [stderr] ... | [INFO] [stderr] 280 | | } [INFO] [stderr] 281 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 273 | } else if dist_a < dist_b { [INFO] [stderr] 274 | Less [INFO] [stderr] 275 | } else if dist_a == dist_b { [INFO] [stderr] 276 | Equal [INFO] [stderr] 277 | } else { [INFO] [stderr] 278 | Greater [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused variable: `name` [INFO] [stderr] --> src/main.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | let name = "Rusty"; [INFO] [stderr] | ^^^^ help: consider using `_name` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `name` [INFO] [stderr] --> src/main.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | let name = "Rusty"; [INFO] [stderr] | ^^^^ help: consider using `_name` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_origin` [INFO] [stderr] --> src/hlt/entity/position.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn from_origin(pos: &T, angle: f64, distance: f64) -> Position { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `undock` [INFO] [stderr] --> src/hlt/entity/ship.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn undock(&self) -> Command { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_owned` [INFO] [stderr] --> src/hlt/entity/planet.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn is_owned(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Undock` [INFO] [stderr] --> src/hlt/command.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | Undock(i32), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `all_ships` [INFO] [stderr] --> src/hlt/game_map.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn all_ships(&self) -> Box<[&Ship]> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `obstacles_between` [INFO] [stderr] --> src/hlt/game_map.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn obstacles_between(&self, ship: &Ship, target: &T, fudge: f64) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Attacker` [INFO] [stderr] --> src/rusty/behavior.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | Attacker, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Defense` [INFO] [stderr] --> src/rusty/behavior.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | Defense, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Sabotage` [INFO] [stderr] --> src/rusty/behavior.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | Sabotage, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: crate `MyBot` should have a snake case name such as `my_bot` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hlt/entity/ship.rs:93:45 [INFO] [stderr] | [INFO] [stderr] 93 | if self.distance_with(target) < MAX_SPEED as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(MAX_SPEED)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hlt/entity/ship.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | MAX_SPEED as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(MAX_SPEED)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/hlt/entity/ship.rs:123:16 [INFO] [stderr] | [INFO] [stderr] 123 | if let Some(_) = game_map.planet_between(self, target, self.radius() + 0.1) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 124 | | trace!("Planet collision found"); [INFO] [stderr] 125 | | return None; [INFO] [stderr] 126 | | } [INFO] [stderr] | |_________- help: try this: `if game_map.planet_between(self, target, self.radius() + 0.1).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/hlt/game.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | let mut iter = parts.into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `parts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/hlt/game.rs:31:24 [INFO] [stderr] | [INFO] [stderr] 31 | let mut iter = parts.into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `parts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/hlt/game.rs:58:24 [INFO] [stderr] | [INFO] [stderr] 58 | let mut iter = parts.into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `parts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/hlt/game.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | stdout().write(encoded.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hlt/game_map.rs:84:48 [INFO] [stderr] | [INFO] [stderr] 84 | entity.distance_with(target) < MAX_SPEED as f64 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(MAX_SPEED)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_origin` [INFO] [stderr] --> src/hlt/entity/position.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn from_origin(pos: &T, angle: f64, distance: f64) -> Position { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `undock` [INFO] [stderr] --> src/hlt/entity/ship.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn undock(&self) -> Command { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/hlt/game_map.rs:110:27 [INFO] [stderr] | [INFO] [stderr] 110 | } else if dist_a == dist_b { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(dist_a - dist_b).abs() < error` [INFO] [stderr] warning: method is never used: `is_owned` [INFO] [stderr] --> src/hlt/entity/planet.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn is_owned(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/hlt/game_map.rs:110:27 [INFO] [stderr] | [INFO] [stderr] 110 | } else if dist_a == dist_b { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: method is never used: `all_ships` [INFO] [stderr] --> src/hlt/game_map.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn all_ships(&self) -> Box<[&Ship]> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `obstacles_between` [INFO] [stderr] --> src/hlt/game_map.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn obstacles_between(&self, ship: &Ship, target: &T, fudge: f64) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Attacker` [INFO] [stderr] --> src/rusty/behavior.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | Attacker, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Defense` [INFO] [stderr] --> src/rusty/behavior.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | Defense, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Sabotage` [INFO] [stderr] --> src/rusty/behavior.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | Sabotage, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: crate `MyBot` should have a snake case name such as `my_bot` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hlt/game_map.rs:121:28 [INFO] [stderr] | [INFO] [stderr] 121 | if distance >= MAX_SPEED as f64 || ship.id == ship_.id { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(MAX_SPEED)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/hlt/parse.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / match present { [INFO] [stderr] 90 | | true => Some(value), [INFO] [stderr] 91 | | false => None, [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if present { Some(value) } else { None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hlt/entity/ship.rs:93:45 [INFO] [stderr] | [INFO] [stderr] 93 | if self.distance_with(target) < MAX_SPEED as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(MAX_SPEED)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hlt/entity/ship.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | MAX_SPEED as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(MAX_SPEED)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/rusty/bot.rs:45:48 [INFO] [stderr] | [INFO] [stderr] 45 | let unit = self.fleet.get_mut(&id).expect(&format!( [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 46 | | "Unit {} doesn't exist or is dead", [INFO] [stderr] 47 | | id [INFO] [stderr] 48 | | )); [INFO] [stderr] | |______________^ help: try this: `unwrap_or_else(|| panic!("Unit {} doesn't exist or is dead", id))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rusty/bot.rs:61:24 [INFO] [stderr] | [INFO] [stderr] 61 | let unit = if self.fleet.contains_key(&ship.id) { [INFO] [stderr] | ________________________^ [INFO] [stderr] 62 | | self.fleet.get_mut(&ship.id).unwrap() [INFO] [stderr] 63 | | } else { [INFO] [stderr] 64 | | let behavior = if self.round < 50 { [INFO] [stderr] ... | [INFO] [stderr] 74 | | u [INFO] [stderr] 75 | | }; [INFO] [stderr] | |_____________^ help: consider using: `self.fleet.entry(ship.id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/hlt/entity/ship.rs:123:16 [INFO] [stderr] | [INFO] [stderr] 123 | if let Some(_) = game_map.planet_between(self, target, self.radius() + 0.1) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 124 | | trace!("Planet collision found"); [INFO] [stderr] 125 | | return None; [INFO] [stderr] 126 | | } [INFO] [stderr] | |_________- help: try this: `if game_map.planet_between(self, target, self.radius() + 0.1).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/rusty/unit.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | / format!("{}", [INFO] [stderr] 36 | | self.target [INFO] [stderr] 37 | | .and_then(|id| Some(id.to_string())) [INFO] [stderr] 38 | | .unwrap_or("None".to_string())), [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( self.target [INFO] [stderr] 3 | .and_then(|id| Some(id.to_string())) [INFO] [stderr] 4 | .unwrap_or("None".to_string()).to_string() ) ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/rusty/unit.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | .unwrap_or("None".to_string())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "None".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/rusty/unit.rs:40:64 [INFO] [stderr] | [INFO] [stderr] 40 | ship.and_then(|ship| Some(format!("{}", ship))).unwrap_or("None".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "None".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rusty/unit.rs:178:36 [INFO] [stderr] | [INFO] [stderr] 178 | let distance = MAX_SPEED as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(MAX_SPEED)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rusty/unit.rs:222:27 [INFO] [stderr] | [INFO] [stderr] 222 | } else if dist_a == dist_b { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(dist_a - dist_b).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rusty/unit.rs:222:27 [INFO] [stderr] | [INFO] [stderr] 222 | } else if dist_a == dist_b { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/rusty/unit.rs:267:70 [INFO] [stderr] | [INFO] [stderr] 267 | } else if a.owner != Some(me) && b.owner == Some(me) { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 268 | | Less [INFO] [stderr] 269 | | } else if b.owner.is_none() && a.owner.is_some() { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/rusty/unit.rs:265:59 [INFO] [stderr] | [INFO] [stderr] 265 | if a.owner.is_none() && b.owner.is_some() { [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 266 | | Less [INFO] [stderr] 267 | | } else if a.owner != Some(me) && b.owner == Some(me) { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rusty/unit.rs:276:31 [INFO] [stderr] | [INFO] [stderr] 276 | } else if dist_a == dist_b { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(dist_a - dist_b).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rusty/unit.rs:276:31 [INFO] [stderr] | [INFO] [stderr] 276 | } else if dist_a == dist_b { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/hlt/game.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | let mut iter = parts.into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `parts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/hlt/game.rs:31:24 [INFO] [stderr] | [INFO] [stderr] 31 | let mut iter = parts.into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `parts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/hlt/game.rs:58:24 [INFO] [stderr] | [INFO] [stderr] 58 | let mut iter = parts.into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `parts` [INFO] [stderr] | [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/hlt/game.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | stdout().write(encoded.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: Could not compile `MyBot`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hlt/game_map.rs:84:48 [INFO] [stderr] | [INFO] [stderr] 84 | entity.distance_with(target) < MAX_SPEED as f64 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(MAX_SPEED)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/hlt/game_map.rs:110:27 [INFO] [stderr] | [INFO] [stderr] 110 | } else if dist_a == dist_b { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(dist_a - dist_b).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/hlt/game_map.rs:110:27 [INFO] [stderr] | [INFO] [stderr] 110 | } else if dist_a == dist_b { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hlt/game_map.rs:121:28 [INFO] [stderr] | [INFO] [stderr] 121 | if distance >= MAX_SPEED as f64 || ship.id == ship_.id { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(MAX_SPEED)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/hlt/parse.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / match present { [INFO] [stderr] 90 | | true => Some(value), [INFO] [stderr] 91 | | false => None, [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if present { Some(value) } else { None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/rusty/bot.rs:45:48 [INFO] [stderr] | [INFO] [stderr] 45 | let unit = self.fleet.get_mut(&id).expect(&format!( [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 46 | | "Unit {} doesn't exist or is dead", [INFO] [stderr] 47 | | id [INFO] [stderr] 48 | | )); [INFO] [stderr] | |______________^ help: try this: `unwrap_or_else(|| panic!("Unit {} doesn't exist or is dead", id))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rusty/bot.rs:61:24 [INFO] [stderr] | [INFO] [stderr] 61 | let unit = if self.fleet.contains_key(&ship.id) { [INFO] [stderr] | ________________________^ [INFO] [stderr] 62 | | self.fleet.get_mut(&ship.id).unwrap() [INFO] [stderr] 63 | | } else { [INFO] [stderr] 64 | | let behavior = if self.round < 50 { [INFO] [stderr] ... | [INFO] [stderr] 74 | | u [INFO] [stderr] 75 | | }; [INFO] [stderr] | |_____________^ help: consider using: `self.fleet.entry(ship.id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/rusty/unit.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | / format!("{}", [INFO] [stderr] 36 | | self.target [INFO] [stderr] 37 | | .and_then(|id| Some(id.to_string())) [INFO] [stderr] 38 | | .unwrap_or("None".to_string())), [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( self.target [INFO] [stderr] 3 | .and_then(|id| Some(id.to_string())) [INFO] [stderr] 4 | .unwrap_or("None".to_string()).to_string() ) ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/rusty/unit.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | .unwrap_or("None".to_string())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "None".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/rusty/unit.rs:40:64 [INFO] [stderr] | [INFO] [stderr] 40 | ship.and_then(|ship| Some(format!("{}", ship))).unwrap_or("None".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "None".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rusty/unit.rs:178:36 [INFO] [stderr] | [INFO] [stderr] 178 | let distance = MAX_SPEED as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(MAX_SPEED)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rusty/unit.rs:222:27 [INFO] [stderr] | [INFO] [stderr] 222 | } else if dist_a == dist_b { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(dist_a - dist_b).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rusty/unit.rs:222:27 [INFO] [stderr] | [INFO] [stderr] 222 | } else if dist_a == dist_b { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/rusty/unit.rs:267:70 [INFO] [stderr] | [INFO] [stderr] 267 | } else if a.owner != Some(me) && b.owner == Some(me) { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 268 | | Less [INFO] [stderr] 269 | | } else if b.owner.is_none() && a.owner.is_some() { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/rusty/unit.rs:265:59 [INFO] [stderr] | [INFO] [stderr] 265 | if a.owner.is_none() && b.owner.is_some() { [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 266 | | Less [INFO] [stderr] 267 | | } else if a.owner != Some(me) && b.owner == Some(me) { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rusty/unit.rs:276:31 [INFO] [stderr] | [INFO] [stderr] 276 | } else if dist_a == dist_b { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(dist_a - dist_b).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rusty/unit.rs:276:31 [INFO] [stderr] | [INFO] [stderr] 276 | } else if dist_a == dist_b { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `MyBot`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9b381f1af40742651f779684f65671fc40763e96dc1a9791970b18a24962cf45"` [INFO] running `"docker" "rm" "-f" "9b381f1af40742651f779684f65671fc40763e96dc1a9791970b18a24962cf45"` [INFO] [stdout] 9b381f1af40742651f779684f65671fc40763e96dc1a9791970b18a24962cf45