[INFO] updating cached repository jlprince21/file_scanner [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jlprince21/file_scanner [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jlprince21/file_scanner" "work/ex/clippy-test-run/sources/stable/gh/jlprince21/file_scanner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jlprince21/file_scanner'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jlprince21/file_scanner" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jlprince21/file_scanner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jlprince21/file_scanner'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1a4bfe598dea0a330cfcadd54d653550a166e685 [INFO] sha for GitHub repo jlprince21/file_scanner: 1a4bfe598dea0a330cfcadd54d653550a166e685 [INFO] validating manifest of jlprince21/file_scanner on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jlprince21/file_scanner on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jlprince21/file_scanner [INFO] finished frobbing jlprince21/file_scanner [INFO] frobbed toml for jlprince21/file_scanner written to work/ex/clippy-test-run/sources/stable/gh/jlprince21/file_scanner/Cargo.toml [INFO] started frobbing jlprince21/file_scanner [INFO] finished frobbing jlprince21/file_scanner [INFO] frobbed toml for jlprince21/file_scanner written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jlprince21/file_scanner/Cargo.toml [INFO] crate jlprince21/file_scanner has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jlprince21/file_scanner against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jlprince21/file_scanner:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a4b782155085130da5958a9f1f5a6438a5b3b313165937a6f5cfad8948a7a51e [INFO] running `"docker" "start" "-a" "a4b782155085130da5958a9f1f5a6438a5b3b313165937a6f5cfad8948a7a51e"` [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking twox-hash v1.1.1 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking nom v4.1.0 [INFO] [stderr] Checking diesel v1.3.3 [INFO] [stderr] Checking dotenv v0.9.0 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking serde-hjson v0.8.1 [INFO] [stderr] Checking config v0.9.1 [INFO] [stderr] Checking card_catalog v1.0.6 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `App`, `Arg`, `SubCommand` [INFO] [stderr] --> src/lib.rs:15:12 [INFO] [stderr] | [INFO] [stderr] 15 | use clap::{Arg, App, SubCommand}; [INFO] [stderr] | ^^^ ^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `App`, `Arg`, `SubCommand` [INFO] [stderr] --> src/lib.rs:15:12 [INFO] [stderr] | [INFO] [stderr] 15 | use clap::{Arg, App, SubCommand}; [INFO] [stderr] | ^^^ ^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mods/sql.rs:8:105 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn create_listing(conn: &PgConnection, checksum: &str, file_name: &str, file_path: &str, file_size: &i64) -> Listing { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mods/sql.rs:8:105 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn create_listing(conn: &PgConnection, checksum: &str, file_name: &str, file_path: &str, file_size: &i64) -> Listing { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Arg`, `SubCommand` [INFO] [stderr] --> src/bin.rs:15:12 [INFO] [stderr] | [INFO] [stderr] 15 | use clap::{Arg, App, SubCommand}; [INFO] [stderr] | ^^^ ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Arg`, `SubCommand` [INFO] [stderr] --> src/bin.rs:15:12 [INFO] [stderr] | [INFO] [stderr] 15 | use clap::{Arg, App, SubCommand}; [INFO] [stderr] | ^^^ ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mods/sql.rs:8:105 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn create_listing(conn: &PgConnection, checksum: &str, file_name: &str, file_path: &str, file_size: &i64) -> Listing { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mods/sql.rs:8:105 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn create_listing(conn: &PgConnection, checksum: &str, file_name: &str, file_path: &str, file_size: &i64) -> Listing { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 52.71s [INFO] running `"docker" "inspect" "a4b782155085130da5958a9f1f5a6438a5b3b313165937a6f5cfad8948a7a51e"` [INFO] running `"docker" "rm" "-f" "a4b782155085130da5958a9f1f5a6438a5b3b313165937a6f5cfad8948a7a51e"` [INFO] [stdout] a4b782155085130da5958a9f1f5a6438a5b3b313165937a6f5cfad8948a7a51e