[INFO] updating cached repository jlmbaka/simple-vm [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jlmbaka/simple-vm [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jlmbaka/simple-vm" "work/ex/clippy-test-run/sources/stable/gh/jlmbaka/simple-vm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jlmbaka/simple-vm'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jlmbaka/simple-vm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jlmbaka/simple-vm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jlmbaka/simple-vm'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 92e1b6bffe3bdd19fcf4e3b7157dddbf621f5329 [INFO] sha for GitHub repo jlmbaka/simple-vm: 92e1b6bffe3bdd19fcf4e3b7157dddbf621f5329 [INFO] validating manifest of jlmbaka/simple-vm on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jlmbaka/simple-vm on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jlmbaka/simple-vm [INFO] finished frobbing jlmbaka/simple-vm [INFO] frobbed toml for jlmbaka/simple-vm written to work/ex/clippy-test-run/sources/stable/gh/jlmbaka/simple-vm/Cargo.toml [INFO] started frobbing jlmbaka/simple-vm [INFO] finished frobbing jlmbaka/simple-vm [INFO] frobbed toml for jlmbaka/simple-vm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jlmbaka/simple-vm/Cargo.toml [INFO] crate jlmbaka/simple-vm has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jlmbaka/simple-vm against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jlmbaka/simple-vm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b3bfde3bd530a8f046cd86a2c2ae74f7fb79a618c1149a66f30328068f647129 [INFO] running `"docker" "start" "-a" "b3bfde3bd530a8f046cd86a2c2ae74f7fb79a618c1149a66f30328068f647129"` [INFO] [stderr] Checking vm v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `SET` [INFO] [stderr] --> src/main.rs:2:37 [INFO] [stderr] | [INFO] [stderr] 2 | use InstructionSet::{PSH, ADD, POP, SET, HLT, VAL}; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:35:3 [INFO] [stderr] | [INFO] [stderr] 35 | instr [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:34:15 [INFO] [stderr] | [INFO] [stderr] 34 | let instr = self.program[self.ip]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SET` [INFO] [stderr] --> src/main.rs:9:2 [INFO] [stderr] | [INFO] [stderr] 9 | SET, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `SET` [INFO] [stderr] --> src/main.rs:2:37 [INFO] [stderr] | [INFO] [stderr] 2 | use InstructionSet::{PSH, ADD, POP, SET, HLT, VAL}; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:35:3 [INFO] [stderr] | [INFO] [stderr] 35 | instr [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:34:15 [INFO] [stderr] | [INFO] [stderr] 34 | let instr = self.program[self.ip]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SET` [INFO] [stderr] --> src/main.rs:9:2 [INFO] [stderr] | [INFO] [stderr] 9 | SET, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.82s [INFO] running `"docker" "inspect" "b3bfde3bd530a8f046cd86a2c2ae74f7fb79a618c1149a66f30328068f647129"` [INFO] running `"docker" "rm" "-f" "b3bfde3bd530a8f046cd86a2c2ae74f7fb79a618c1149a66f30328068f647129"` [INFO] [stdout] b3bfde3bd530a8f046cd86a2c2ae74f7fb79a618c1149a66f30328068f647129