[INFO] updating cached repository jlgerber/fixspaces
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jlgerber/fixspaces
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jlgerber/fixspaces" "work/ex/clippy-test-run/sources/stable/gh/jlgerber/fixspaces"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jlgerber/fixspaces'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jlgerber/fixspaces" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jlgerber/fixspaces"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jlgerber/fixspaces'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 11451cc4c9d60209eac2ac5ba072b3c86ee7b845
[INFO] sha for GitHub repo jlgerber/fixspaces: 11451cc4c9d60209eac2ac5ba072b3c86ee7b845
[INFO] validating manifest of jlgerber/fixspaces on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jlgerber/fixspaces on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jlgerber/fixspaces
[INFO] finished frobbing jlgerber/fixspaces
[INFO] frobbed toml for jlgerber/fixspaces written to work/ex/clippy-test-run/sources/stable/gh/jlgerber/fixspaces/Cargo.toml
[INFO] started frobbing jlgerber/fixspaces
[INFO] finished frobbing jlgerber/fixspaces
[INFO] frobbed toml for jlgerber/fixspaces written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jlgerber/fixspaces/Cargo.toml
[INFO] crate jlgerber/fixspaces has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jlgerber/fixspaces against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jlgerber/fixspaces:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ed806c6006770b6895476a633357919fb51f9fbc3a80c259b1f32e6d4670110f
[INFO] running `"docker" "start" "-a" "ed806c6006770b6895476a633357919fb51f9fbc3a80c259b1f32e6d4670110f"`
[INFO] [stderr]     Checking fixspaces v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/main.rs:35:24
[INFO] [stderr]    |
[INFO] [stderr] 35 |                   } else {
[INFO] [stderr]    |  ________________________^
[INFO] [stderr] 36 | |                     if pathstr.contains(replace) { 
[INFO] [stderr] 37 | |                         println!("mv {} => {}",pathstr, replacement_string);
[INFO] [stderr] 38 | |                         path = replacement.to_path_buf();
[INFO] [stderr] 39 | |                     }
[INFO] [stderr] 40 | |                 };
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 35 |                 } else if pathstr.contains(replace) { 
[INFO] [stderr] 36 |     println!("mv {} => {}",pathstr, replacement_string);
[INFO] [stderr] 37 |     path = replacement.to_path_buf();
[INFO] [stderr] 38 | };
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/main.rs:35:24
[INFO] [stderr]    |
[INFO] [stderr] 35 |                   } else {
[INFO] [stderr]    |  ________________________^
[INFO] [stderr] 36 | |                     if pathstr.contains(replace) { 
[INFO] [stderr] 37 | |                         println!("mv {} => {}",pathstr, replacement_string);
[INFO] [stderr] 38 | |                         path = replacement.to_path_buf();
[INFO] [stderr] 39 | |                     }
[INFO] [stderr] 40 | |                 };
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 35 |                 } else if pathstr.contains(replace) { 
[INFO] [stderr] 36 |     println!("mv {} => {}",pathstr, replacement_string);
[INFO] [stderr] 37 |     path = replacement.to_path_buf();
[INFO] [stderr] 38 | };
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/main.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 | /         fs::read_dir(dir)?
[INFO] [stderr] 22 | |         .into_iter()
[INFO] [stderr]    | |____________________^ help: consider removing `.into_iter()`: `fs::read_dir(dir)?`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:57:35
[INFO] [stderr]    |
[INFO] [stderr] 57 |     let skipchar = enviter.next().unwrap_or(" ".to_string());
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| " ".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:58:35
[INFO] [stderr]    |
[INFO] [stderr] 58 |     let withchar = enviter.next().unwrap_or("_".to_string());
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "_".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/main.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 | /         fs::read_dir(dir)?
[INFO] [stderr] 22 | |         .into_iter()
[INFO] [stderr]    | |____________________^ help: consider removing `.into_iter()`: `fs::read_dir(dir)?`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:57:35
[INFO] [stderr]    |
[INFO] [stderr] 57 |     let skipchar = enviter.next().unwrap_or(" ".to_string());
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| " ".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:58:35
[INFO] [stderr]    |
[INFO] [stderr] 58 |     let withchar = enviter.next().unwrap_or("_".to_string());
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "_".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.89s
[INFO] running `"docker" "inspect" "ed806c6006770b6895476a633357919fb51f9fbc3a80c259b1f32e6d4670110f"`
[INFO] running `"docker" "rm" "-f" "ed806c6006770b6895476a633357919fb51f9fbc3a80c259b1f32e6d4670110f"`
[INFO] [stdout] ed806c6006770b6895476a633357919fb51f9fbc3a80c259b1f32e6d4670110f