[INFO] updating cached repository jlewisbrewer/rust_kana [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jlewisbrewer/rust_kana [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jlewisbrewer/rust_kana" "work/ex/clippy-test-run/sources/stable/gh/jlewisbrewer/rust_kana"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jlewisbrewer/rust_kana'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jlewisbrewer/rust_kana" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jlewisbrewer/rust_kana"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jlewisbrewer/rust_kana'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d67bd05ccfa84c4f3c4a587c9784f6be2a5ebb6b [INFO] sha for GitHub repo jlewisbrewer/rust_kana: d67bd05ccfa84c4f3c4a587c9784f6be2a5ebb6b [INFO] validating manifest of jlewisbrewer/rust_kana on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jlewisbrewer/rust_kana on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jlewisbrewer/rust_kana [INFO] finished frobbing jlewisbrewer/rust_kana [INFO] frobbed toml for jlewisbrewer/rust_kana written to work/ex/clippy-test-run/sources/stable/gh/jlewisbrewer/rust_kana/Cargo.toml [INFO] started frobbing jlewisbrewer/rust_kana [INFO] finished frobbing jlewisbrewer/rust_kana [INFO] frobbed toml for jlewisbrewer/rust_kana written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jlewisbrewer/rust_kana/Cargo.toml [INFO] crate jlewisbrewer/rust_kana has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jlewisbrewer/rust_kana against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jlewisbrewer/rust_kana:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 99ca14661f343732f450a1150a7d72438ff96c83ad424688e7ef29e3ea7380cb [INFO] running `"docker" "start" "-a" "99ca14661f343732f450a1150a7d72438ff96c83ad424688e7ef29e3ea7380cb"` [INFO] [stderr] Checking to_kana v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:50:28 [INFO] [stderr] | [INFO] [stderr] 50 | syllabary.push(format!("{}", v)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `v.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:688:13 [INFO] [stderr] | [INFO] [stderr] 688 | / let mut temp = c.to_string(); [INFO] [stderr] 689 | | if &last_vowel.to_string() == c && last_vowel.is_alphabetic() { [INFO] [stderr] 690 | | // This retrieves the choonpu used for long vowels in katakana. [INFO] [stderr] 691 | | temp = "L".to_string(); [INFO] [stderr] 692 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let temp = if &last_vowel.to_string() == c && last_vowel.is_alphabetic() { "L".to_string() } else { c.to_string() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/main.rs:736:44 [INFO] [stderr] | [INFO] [stderr] 736 | let index = digraph_vowels.into_iter().position(|x| x == &c).unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/main.rs:790:44 [INFO] [stderr] | [INFO] [stderr] 790 | let index = digraph_vowels.into_iter().position(|x| x == &c).unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:865:28 [INFO] [stderr] | [INFO] [stderr] 865 | while let Some(line) = reader.next() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `for line in reader { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:899:16 [INFO] [stderr] | [INFO] [stderr] 899 | if character.is_alphabetic() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!character.is_alphabetic()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:905:12 [INFO] [stderr] | [INFO] [stderr] 905 | if has_stress == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `has_stress` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `to_kana`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:50:28 [INFO] [stderr] | [INFO] [stderr] 50 | syllabary.push(format!("{}", v)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `v.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:688:13 [INFO] [stderr] | [INFO] [stderr] 688 | / let mut temp = c.to_string(); [INFO] [stderr] 689 | | if &last_vowel.to_string() == c && last_vowel.is_alphabetic() { [INFO] [stderr] 690 | | // This retrieves the choonpu used for long vowels in katakana. [INFO] [stderr] 691 | | temp = "L".to_string(); [INFO] [stderr] 692 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let temp = if &last_vowel.to_string() == c && last_vowel.is_alphabetic() { "L".to_string() } else { c.to_string() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/main.rs:736:44 [INFO] [stderr] | [INFO] [stderr] 736 | let index = digraph_vowels.into_iter().position(|x| x == &c).unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/main.rs:790:44 [INFO] [stderr] | [INFO] [stderr] 790 | let index = digraph_vowels.into_iter().position(|x| x == &c).unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:865:28 [INFO] [stderr] | [INFO] [stderr] 865 | while let Some(line) = reader.next() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `for line in reader { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:899:16 [INFO] [stderr] | [INFO] [stderr] 899 | if character.is_alphabetic() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!character.is_alphabetic()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:905:12 [INFO] [stderr] | [INFO] [stderr] 905 | if has_stress == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `has_stress` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `to_kana`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "99ca14661f343732f450a1150a7d72438ff96c83ad424688e7ef29e3ea7380cb"` [INFO] running `"docker" "rm" "-f" "99ca14661f343732f450a1150a7d72438ff96c83ad424688e7ef29e3ea7380cb"` [INFO] [stdout] 99ca14661f343732f450a1150a7d72438ff96c83ad424688e7ef29e3ea7380cb