[INFO] updating cached repository jlewisbrewer/Rust-HW1
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jlewisbrewer/Rust-HW1
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jlewisbrewer/Rust-HW1" "work/ex/clippy-test-run/sources/stable/gh/jlewisbrewer/Rust-HW1"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jlewisbrewer/Rust-HW1'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jlewisbrewer/Rust-HW1" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jlewisbrewer/Rust-HW1"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jlewisbrewer/Rust-HW1'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 58fbe126b360c1140d5c9753520641e43ed78aba
[INFO] sha for GitHub repo jlewisbrewer/Rust-HW1: 58fbe126b360c1140d5c9753520641e43ed78aba
[INFO] validating manifest of jlewisbrewer/Rust-HW1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jlewisbrewer/Rust-HW1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jlewisbrewer/Rust-HW1
[INFO] finished frobbing jlewisbrewer/Rust-HW1
[INFO] frobbed toml for jlewisbrewer/Rust-HW1 written to work/ex/clippy-test-run/sources/stable/gh/jlewisbrewer/Rust-HW1/Cargo.toml
[INFO] started frobbing jlewisbrewer/Rust-HW1
[INFO] finished frobbing jlewisbrewer/Rust-HW1
[INFO] frobbed toml for jlewisbrewer/Rust-HW1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jlewisbrewer/Rust-HW1/Cargo.toml
[INFO] crate jlewisbrewer/Rust-HW1 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jlewisbrewer/Rust-HW1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jlewisbrewer/Rust-HW1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 14b39c47acf31edad894fe22a54dad125cd5792f810bffc95fb5f6ce0d8448f8
[INFO] running `"docker" "start" "-a" "14b39c47acf31edad894fe22a54dad125cd5792f810bffc95fb5f6ce0d8448f8"`
[INFO] [stderr]     Checking calc v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 |     lcm
[INFO] [stderr]    |     ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:38:15
[INFO] [stderr]    |
[INFO] [stderr] 38 |     let lcm = numerator / denominator;
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/main.rs:4:11
[INFO] [stderr]   |
[INFO] [stderr] 4 | fn sum(a: &Vec<u64>) -> u64 {
[INFO] [stderr]   |           ^^^^^^^^^ help: change this to: `&[u64]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:12:15
[INFO] [stderr]    |
[INFO] [stderr] 12 | fn product(a: &Vec<u64>) -> u64 {
[INFO] [stderr]    |               ^^^^^^^^^ help: change this to: `&[u64]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 |     lcm
[INFO] [stderr]    |     ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:38:15
[INFO] [stderr]    |
[INFO] [stderr] 38 |     let lcm = numerator / denominator;
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:15:9
[INFO] [stderr]    |
[INFO] [stderr] 15 |         product = number * product;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `product *= number`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this looks like you are swapping `m` and `n` manually
[INFO] [stderr]   --> src/main.rs:25:13
[INFO] [stderr]    |
[INFO] [stderr] 25 | /             let t = m;
[INFO] [stderr] 26 | |             m = n;
[INFO] [stderr] 27 | |             n = t;
[INFO] [stderr]    | |_________________^ help: try: `std::mem::swap(&mut m, &mut n)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_swap)] on by default
[INFO] [stderr]    = note: or maybe you should use `std::mem::replace`?
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 |         m = m % n;
[INFO] [stderr]    |         ^^^^^^^^^ help: replace it with: `m %= n`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:44:32
[INFO] [stderr]    |
[INFO] [stderr] 44 | fn calc_selector(a: &str, num: &Vec<u64>) {
[INFO] [stderr]    |                                ^^^^^^^^^ help: change this to: `&[u64]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:85:12
[INFO] [stderr]    |
[INFO] [stderr] 85 |         if numbers.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!numbers.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/main.rs:4:11
[INFO] [stderr]   |
[INFO] [stderr] 4 | fn sum(a: &Vec<u64>) -> u64 {
[INFO] [stderr]   |           ^^^^^^^^^ help: change this to: `&[u64]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:12:15
[INFO] [stderr]    |
[INFO] [stderr] 12 | fn product(a: &Vec<u64>) -> u64 {
[INFO] [stderr]    |               ^^^^^^^^^ help: change this to: `&[u64]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:15:9
[INFO] [stderr]    |
[INFO] [stderr] 15 |         product = number * product;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `product *= number`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this looks like you are swapping `m` and `n` manually
[INFO] [stderr]   --> src/main.rs:25:13
[INFO] [stderr]    |
[INFO] [stderr] 25 | /             let t = m;
[INFO] [stderr] 26 | |             m = n;
[INFO] [stderr] 27 | |             n = t;
[INFO] [stderr]    | |_________________^ help: try: `std::mem::swap(&mut m, &mut n)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_swap)] on by default
[INFO] [stderr]    = note: or maybe you should use `std::mem::replace`?
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 |         m = m % n;
[INFO] [stderr]    |         ^^^^^^^^^ help: replace it with: `m %= n`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:44:32
[INFO] [stderr]    |
[INFO] [stderr] 44 | fn calc_selector(a: &str, num: &Vec<u64>) {
[INFO] [stderr]    |                                ^^^^^^^^^ help: change this to: `&[u64]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:85:12
[INFO] [stderr]    |
[INFO] [stderr] 85 |         if numbers.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!numbers.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.62s
[INFO] running `"docker" "inspect" "14b39c47acf31edad894fe22a54dad125cd5792f810bffc95fb5f6ce0d8448f8"`
[INFO] running `"docker" "rm" "-f" "14b39c47acf31edad894fe22a54dad125cd5792f810bffc95fb5f6ce0d8448f8"`
[INFO] [stdout] 14b39c47acf31edad894fe22a54dad125cd5792f810bffc95fb5f6ce0d8448f8