[INFO] updating cached repository jkhsjdhjs/surveillance-cleaner [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jkhsjdhjs/surveillance-cleaner [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jkhsjdhjs/surveillance-cleaner" "work/ex/clippy-test-run/sources/stable/gh/jkhsjdhjs/surveillance-cleaner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jkhsjdhjs/surveillance-cleaner'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jkhsjdhjs/surveillance-cleaner" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jkhsjdhjs/surveillance-cleaner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jkhsjdhjs/surveillance-cleaner'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f86fe71fdcdf31844294b5c14159098be3ec3779 [INFO] sha for GitHub repo jkhsjdhjs/surveillance-cleaner: f86fe71fdcdf31844294b5c14159098be3ec3779 [INFO] validating manifest of jkhsjdhjs/surveillance-cleaner on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jkhsjdhjs/surveillance-cleaner on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jkhsjdhjs/surveillance-cleaner [INFO] finished frobbing jkhsjdhjs/surveillance-cleaner [INFO] frobbed toml for jkhsjdhjs/surveillance-cleaner written to work/ex/clippy-test-run/sources/stable/gh/jkhsjdhjs/surveillance-cleaner/Cargo.toml [INFO] started frobbing jkhsjdhjs/surveillance-cleaner [INFO] finished frobbing jkhsjdhjs/surveillance-cleaner [INFO] frobbed toml for jkhsjdhjs/surveillance-cleaner written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jkhsjdhjs/surveillance-cleaner/Cargo.toml [INFO] crate jkhsjdhjs/surveillance-cleaner has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jkhsjdhjs/surveillance-cleaner against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jkhsjdhjs/surveillance-cleaner:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 750d05ef90a9d23099ce5cda431626d99a9484c14045d0745bb4e5572c8a7f8b [INFO] running `"docker" "start" "-a" "750d05ef90a9d23099ce5cda431626d99a9484c14045d0745bb4e5572c8a7f8b"` [INFO] [stderr] Compiling syn v0.14.4 [INFO] [stderr] Compiling structopt-derive v0.2.10 [INFO] [stderr] Checking structopt v0.2.10 [INFO] [stderr] Checking surveillance-cleaner v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `remove_unwrap` [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | let remove_unwrap = 0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_remove_unwrap` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:34:10 [INFO] [stderr] | [INFO] [stderr] 34 | .ok_or(Error::new(ErrorKind::Other, "Error splitting filename"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new(ErrorKind::Other, "Error splitting filename"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:32:16 [INFO] [stderr] | [INFO] [stderr] 32 | .split(".") [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:28:10 [INFO] [stderr] | [INFO] [stderr] 28 | .ok_or(Error::new( [INFO] [stderr] | __________^ [INFO] [stderr] 29 | | ErrorKind::Other, [INFO] [stderr] 30 | | "Error converting filename to &str", [INFO] [stderr] 31 | | ))? [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | .ok_or_else(|| Error::new( [INFO] [stderr] 29 | ErrorKind::Other, [INFO] [stderr] 30 | "Error converting filename to &str", [INFO] [stderr] 31 | ))? [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `remove_unwrap` [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | let remove_unwrap = 0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_remove_unwrap` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:34:10 [INFO] [stderr] | [INFO] [stderr] 34 | .ok_or(Error::new(ErrorKind::Other, "Error splitting filename"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new(ErrorKind::Other, "Error splitting filename"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:32:16 [INFO] [stderr] | [INFO] [stderr] 32 | .split(".") [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:28:10 [INFO] [stderr] | [INFO] [stderr] 28 | .ok_or(Error::new( [INFO] [stderr] | __________^ [INFO] [stderr] 29 | | ErrorKind::Other, [INFO] [stderr] 30 | | "Error converting filename to &str", [INFO] [stderr] 31 | | ))? [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | .ok_or_else(|| Error::new( [INFO] [stderr] 29 | ErrorKind::Other, [INFO] [stderr] 30 | "Error converting filename to &str", [INFO] [stderr] 31 | ))? [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.95s [INFO] running `"docker" "inspect" "750d05ef90a9d23099ce5cda431626d99a9484c14045d0745bb4e5572c8a7f8b"` [INFO] running `"docker" "rm" "-f" "750d05ef90a9d23099ce5cda431626d99a9484c14045d0745bb4e5572c8a7f8b"` [INFO] [stdout] 750d05ef90a9d23099ce5cda431626d99a9484c14045d0745bb4e5572c8a7f8b