[INFO] updating cached repository jkang8/risp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jkang8/risp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jkang8/risp" "work/ex/clippy-test-run/sources/stable/gh/jkang8/risp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jkang8/risp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jkang8/risp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jkang8/risp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jkang8/risp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e073f95ed46aa70339078608fa00501f8c7b9cb2 [INFO] sha for GitHub repo jkang8/risp: e073f95ed46aa70339078608fa00501f8c7b9cb2 [INFO] validating manifest of jkang8/risp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jkang8/risp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jkang8/risp [INFO] finished frobbing jkang8/risp [INFO] frobbed toml for jkang8/risp written to work/ex/clippy-test-run/sources/stable/gh/jkang8/risp/Cargo.toml [INFO] started frobbing jkang8/risp [INFO] finished frobbing jkang8/risp [INFO] frobbed toml for jkang8/risp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jkang8/risp/Cargo.toml [INFO] crate jkang8/risp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jkang8/risp against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jkang8/risp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4c53ec300aec66ee01f154b9fa6c06858f9890cc7d104fd2494a4128aae6717b [INFO] running `"docker" "start" "-a" "4c53ec300aec66ee01f154b9fa6c06858f9890cc7d104fd2494a4128aae6717b"` [INFO] [stderr] Checking risp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:8:15 [INFO] [stderr] | [INFO] [stderr] 8 | let res = _chars [INFO] [stderr] | _______________^ [INFO] [stderr] 9 | | .replace("(", " ( ") [INFO] [stderr] 10 | | .replace(")", " ) ") [INFO] [stderr] 11 | | .split_whitespace() [INFO] [stderr] 12 | | .map(|s| s.to_string()) [INFO] [stderr] 13 | | .collect(); [INFO] [stderr] | |__________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | tokens [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | let tokens = tokenize(program); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:8:15 [INFO] [stderr] | [INFO] [stderr] 8 | let res = _chars [INFO] [stderr] | _______________^ [INFO] [stderr] 9 | | .replace("(", " ( ") [INFO] [stderr] 10 | | .replace(")", " ) ") [INFO] [stderr] 11 | | .split_whitespace() [INFO] [stderr] 12 | | .map(|s| s.to_string()) [INFO] [stderr] 13 | | .collect(); [INFO] [stderr] | |__________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | tokens [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | let tokens = tokenize(program); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.45s [INFO] running `"docker" "inspect" "4c53ec300aec66ee01f154b9fa6c06858f9890cc7d104fd2494a4128aae6717b"` [INFO] running `"docker" "rm" "-f" "4c53ec300aec66ee01f154b9fa6c06858f9890cc7d104fd2494a4128aae6717b"` [INFO] [stdout] 4c53ec300aec66ee01f154b9fa6c06858f9890cc7d104fd2494a4128aae6717b