[INFO] updating cached repository jjpe/download [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jjpe/download [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jjpe/download" "work/ex/clippy-test-run/sources/stable/gh/jjpe/download"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jjpe/download'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jjpe/download" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jjpe/download"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jjpe/download'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2b53ad520f98d013dac8390d4f1d4622d74691ed [INFO] sha for GitHub repo jjpe/download: 2b53ad520f98d013dac8390d4f1d4622d74691ed [INFO] validating manifest of jjpe/download on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jjpe/download on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jjpe/download [INFO] finished frobbing jjpe/download [INFO] frobbed toml for jjpe/download written to work/ex/clippy-test-run/sources/stable/gh/jjpe/download/Cargo.toml [INFO] started frobbing jjpe/download [INFO] finished frobbing jjpe/download [INFO] frobbed toml for jjpe/download written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jjpe/download/Cargo.toml [INFO] crate jjpe/download has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jjpe/download against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jjpe/download:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 184e62c732cee792574ac48a5cea0cad0f7b4d8f071d89e68b1f0758ac4c9abd [INFO] running `"docker" "start" "-a" "184e62c732cee792574ac48a5cea0cad0f7b4d8f071d89e68b1f0758ac4c9abd"` [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking atty v0.2.2 [INFO] [stderr] Checking socket2 v0.2.1 [INFO] [stderr] Checking serde_json v1.0.2 [INFO] [stderr] Checking libz-sys v1.0.16 [INFO] [stderr] Checking openssl-sys v0.9.14 [INFO] [stderr] Compiling serde_derive v1.0.10 [INFO] [stderr] Checking textwrap v0.6.0 [INFO] [stderr] Checking curl-sys v0.3.14 [INFO] [stderr] Checking clap v2.25.0 [INFO] [stderr] Checking curl v0.4.7 [INFO] [stderr] Checking download v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:88:57 [INFO] [stderr] | [INFO] [stderr] 88 | return Ok(DlStatus::Replaced{ location: to, num_bytes: num_bytes }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:96:52 [INFO] [stderr] | [INFO] [stderr] 96 | Ok(DlStatus::Downloaded{ location: to, num_bytes: num_bytes }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:88:57 [INFO] [stderr] | [INFO] [stderr] 88 | return Ok(DlStatus::Replaced{ location: to, num_bytes: num_bytes }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:96:52 [INFO] [stderr] | [INFO] [stderr] 96 | Ok(DlStatus::Downloaded{ location: to, num_bytes: num_bytes }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | return Ok(DlStatus::Replaced{ location: to, num_bytes: num_bytes }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(DlStatus::Replaced{ location: to, num_bytes: num_bytes })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | return Ok(DlStatus::FileExists(to)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(DlStatus::FileExists(to))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | return Ok(DlStatus::Replaced{ location: to, num_bytes: num_bytes }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(DlStatus::Replaced{ location: to, num_bytes: num_bytes })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | return Ok(DlStatus::FileExists(to)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(DlStatus::FileExists(to))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Dl` [INFO] [stderr] --> src/lib.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / pub fn new() -> Self { [INFO] [stderr] 58 | | Dl { [INFO] [stderr] 59 | | buffer: vec![], [INFO] [stderr] 60 | | overwrite: false, [INFO] [stderr] 61 | | verbose: false, [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | format!("Accept: application/octet-stream"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Accept: application/octet-stream".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | format!("User-Agent: download"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"User-Agent: download".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Dl` [INFO] [stderr] --> src/lib.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / pub fn new() -> Self { [INFO] [stderr] 58 | | Dl { [INFO] [stderr] 59 | | buffer: vec![], [INFO] [stderr] 60 | | overwrite: false, [INFO] [stderr] 61 | | verbose: false, [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | format!("Accept: application/octet-stream"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Accept: application/octet-stream".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | format!("User-Agent: download"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"User-Agent: download".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/main.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | overwrite: overwrite, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `overwrite` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/main.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | verbose: verbose, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `verbose` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/main.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | overwrite: overwrite, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `overwrite` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/main.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | verbose: verbose, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `verbose` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.45s [INFO] running `"docker" "inspect" "184e62c732cee792574ac48a5cea0cad0f7b4d8f071d89e68b1f0758ac4c9abd"` [INFO] running `"docker" "rm" "-f" "184e62c732cee792574ac48a5cea0cad0f7b4d8f071d89e68b1f0758ac4c9abd"` [INFO] [stdout] 184e62c732cee792574ac48a5cea0cad0f7b4d8f071d89e68b1f0758ac4c9abd