[INFO] updating cached repository jjhbw/background-modelling [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jjhbw/background-modelling [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jjhbw/background-modelling" "work/ex/clippy-test-run/sources/stable/gh/jjhbw/background-modelling"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jjhbw/background-modelling'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jjhbw/background-modelling" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jjhbw/background-modelling"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jjhbw/background-modelling'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] afb5a57e6fd74fa7b2d8576db99a5f0a50d05cff [INFO] sha for GitHub repo jjhbw/background-modelling: afb5a57e6fd74fa7b2d8576db99a5f0a50d05cff [INFO] validating manifest of jjhbw/background-modelling on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jjhbw/background-modelling on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jjhbw/background-modelling [INFO] finished frobbing jjhbw/background-modelling [INFO] frobbed toml for jjhbw/background-modelling written to work/ex/clippy-test-run/sources/stable/gh/jjhbw/background-modelling/Cargo.toml [INFO] started frobbing jjhbw/background-modelling [INFO] finished frobbing jjhbw/background-modelling [INFO] frobbed toml for jjhbw/background-modelling written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jjhbw/background-modelling/Cargo.toml [INFO] crate jjhbw/background-modelling has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jjhbw/background-modelling against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jjhbw/background-modelling:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c3ceb19f147365d4627eada1e9534ff49e83507577c20500f331fac5c858164f [INFO] running `"docker" "start" "-a" "c3ceb19f147365d4627eada1e9534ff49e83507577c20500f331fac5c858164f"` [INFO] [stderr] Checking criterion-stats v0.2.3 [INFO] [stderr] Checking itertools-num v0.1.1 [INFO] [stderr] Checking alga v0.5.4 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Compiling serde_derive v1.0.67 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking handlebars v0.31.0 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking simplelog v0.5.2 [INFO] [stderr] Checking rusttype v0.5.2 [INFO] [stderr] Checking nalgebra v0.15.3 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking quickcheck v0.6.2 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking nalgebra v0.13.1 [INFO] [stderr] Checking criterion v0.2.3 [INFO] [stderr] Checking imageproc v0.15.0 [INFO] [stderr] Checking traffic_counter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bg_model/mod.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bg_model/mod.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bg_model/mod.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bg_model/mod.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/gmm.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return top / bottom; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `top / bottom` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/gmm.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | return contrib; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `contrib` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/gmm.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | return xt - self.mu; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `xt - self.mu` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/gmm.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | return (dist.tr_dot(&dist.transpose())) / self.variance; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(dist.tr_dot(&dist.transpose())) / self.variance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/gmm.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | / return GaussianMixtureModel { [INFO] [stderr] 167 | | components: Vec::new(), [INFO] [stderr] 168 | | alphamin: settings.alphamin, [INFO] [stderr] 169 | | alpha: 1.0, [INFO] [stderr] ... | [INFO] [stderr] 174 | | mahal_threshold: settings.mahal_threshold, [INFO] [stderr] 175 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 166 | GaussianMixtureModel { [INFO] [stderr] 167 | components: Vec::new(), [INFO] [stderr] 168 | alphamin: settings.alphamin, [INFO] [stderr] 169 | alpha: 1.0, [INFO] [stderr] 170 | training_set_size: 0, [INFO] [stderr] 171 | max_components: settings.max_components, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/gmm.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | return &self.components[0].mu; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.components[0].mu` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/gmm.rs:211:22 [INFO] [stderr] | [INFO] [stderr] 211 | .map(|c| return c.d_squared(&xt) < self.mahal_threshold) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `c.d_squared(&xt) < self.mahal_threshold` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/gmm.rs:311:9 [INFO] [stderr] | [INFO] [stderr] 311 | return (bg_prob, fg_prob); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(bg_prob, fg_prob)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/gmm.rs:333:17 [INFO] [stderr] | [INFO] [stderr] 333 | return simplified_mvn_density(x, mu, *var); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `simplified_mvn_density(x, mu, *var)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bg_model/gmm.rs:336:29 [INFO] [stderr] | [INFO] [stderr] 336 | let expected = vec![0.008815429]; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.008_815_429` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/gmm.rs:395:9 [INFO] [stderr] | [INFO] [stderr] 395 | / return GaussianMixtureModel::new(&GaussianMixtureSettings { [INFO] [stderr] 396 | | alphamin, [INFO] [stderr] 397 | | max_components, [INFO] [stderr] 398 | | initial_variance: 20.0, [INFO] [stderr] 399 | | cf, [INFO] [stderr] 400 | | mahal_threshold: 3.0 * 3.0, [INFO] [stderr] 401 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 395 | GaussianMixtureModel::new(&GaussianMixtureSettings { [INFO] [stderr] 396 | alphamin, [INFO] [stderr] 397 | max_components, [INFO] [stderr] 398 | initial_variance: 20.0, [INFO] [stderr] 399 | cf, [INFO] [stderr] 400 | mahal_threshold: 3.0 * 3.0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/mod.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / return Vector3::new( [INFO] [stderr] 27 | | pixel.data[0] as f32, [INFO] [stderr] 28 | | pixel.data[1] as f32, [INFO] [stderr] 29 | | pixel.data[2] as f32, [INFO] [stderr] 30 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 26 | Vector3::new( [INFO] [stderr] 27 | pixel.data[0] as f32, [INFO] [stderr] 28 | pixel.data[1] as f32, [INFO] [stderr] 29 | pixel.data[2] as f32, [INFO] [stderr] 30 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/mod.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / return Rgb { [INFO] [stderr] 35 | | data: [vec[0] as u8, vec[1] as u8, vec[2] as u8], [INFO] [stderr] 36 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 34 | Rgb { [INFO] [stderr] 35 | data: [vec[0] as u8, vec[1] as u8, vec[2] as u8], [INFO] [stderr] 36 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/mod.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return model; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/mod.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | return probability_map; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `probability_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/mod.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | return background; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `background` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | return testfiles; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `testfiles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | return images; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `images` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:49:57 [INFO] [stderr] | [INFO] [stderr] 49 | let dims: Vec<(u32, u32)> = images.iter().map(|img| return img.dimensions()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `img.dimensions()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/gmm.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return top / bottom; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `top / bottom` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/gmm.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | return contrib; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `contrib` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/gmm.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | return xt - self.mu; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `xt - self.mu` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/gmm.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | return (dist.tr_dot(&dist.transpose())) / self.variance; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(dist.tr_dot(&dist.transpose())) / self.variance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/gmm.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | / return GaussianMixtureModel { [INFO] [stderr] 167 | | components: Vec::new(), [INFO] [stderr] 168 | | alphamin: settings.alphamin, [INFO] [stderr] 169 | | alpha: 1.0, [INFO] [stderr] ... | [INFO] [stderr] 174 | | mahal_threshold: settings.mahal_threshold, [INFO] [stderr] 175 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 166 | GaussianMixtureModel { [INFO] [stderr] 167 | components: Vec::new(), [INFO] [stderr] 168 | alphamin: settings.alphamin, [INFO] [stderr] 169 | alpha: 1.0, [INFO] [stderr] 170 | training_set_size: 0, [INFO] [stderr] 171 | max_components: settings.max_components, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/gmm.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | return &self.components[0].mu; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.components[0].mu` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/gmm.rs:211:22 [INFO] [stderr] | [INFO] [stderr] 211 | .map(|c| return c.d_squared(&xt) < self.mahal_threshold) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `c.d_squared(&xt) < self.mahal_threshold` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/gmm.rs:311:9 [INFO] [stderr] | [INFO] [stderr] 311 | return (bg_prob, fg_prob); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(bg_prob, fg_prob)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/mod.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / return Vector3::new( [INFO] [stderr] 27 | | pixel.data[0] as f32, [INFO] [stderr] 28 | | pixel.data[1] as f32, [INFO] [stderr] 29 | | pixel.data[2] as f32, [INFO] [stderr] 30 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 26 | Vector3::new( [INFO] [stderr] 27 | pixel.data[0] as f32, [INFO] [stderr] 28 | pixel.data[1] as f32, [INFO] [stderr] 29 | pixel.data[2] as f32, [INFO] [stderr] 30 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/mod.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / return Rgb { [INFO] [stderr] 35 | | data: [vec[0] as u8, vec[1] as u8, vec[2] as u8], [INFO] [stderr] 36 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 34 | Rgb { [INFO] [stderr] 35 | data: [vec[0] as u8, vec[1] as u8, vec[2] as u8], [INFO] [stderr] 36 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/mod.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return model; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/mod.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | return probability_map; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `probability_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bg_model/mod.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | return background; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `background` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | return testfiles; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `testfiles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | return images; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `images` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:49:57 [INFO] [stderr] | [INFO] [stderr] 49 | let dims: Vec<(u32, u32)> = images.iter().map(|img| return img.dimensions()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `img.dimensions()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bg_model/gmm.rs:79:72 [INFO] [stderr] | [INFO] [stderr] 79 | fn update_params(&mut self, xt: &Vector3, owned: bool, alpha: &f32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bg_model/gmm.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | self.mu = self.mu + damp * dist; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.mu += damp * dist` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/bg_model/gmm.rs:195:12 [INFO] [stderr] | [INFO] [stderr] 195 | if self.alpha != self.alphamin { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.alpha - self.alphamin).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/bg_model/gmm.rs:195:12 [INFO] [stderr] | [INFO] [stderr] 195 | if self.alpha != self.alphamin { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bg_model/gmm.rs:201:12 [INFO] [stderr] | [INFO] [stderr] 201 | if self.components.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.components.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bg_model/mod.rs:25:31 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn pixel_to_vector(pixel: &Rgb) -> Vector3 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Rgb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/bg_model/mod.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | pixel.data[0] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/bg_model/mod.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | pixel.data[1] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/bg_model/mod.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | pixel.data[2] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:35:45 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn import_images>(paths: &Vec

) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[P]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `traffic_counter`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bg_model/gmm.rs:79:72 [INFO] [stderr] | [INFO] [stderr] 79 | fn update_params(&mut self, xt: &Vector3, owned: bool, alpha: &f32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bg_model/gmm.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | self.mu = self.mu + damp * dist; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.mu += damp * dist` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/bg_model/gmm.rs:195:12 [INFO] [stderr] | [INFO] [stderr] 195 | if self.alpha != self.alphamin { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.alpha - self.alphamin).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/bg_model/gmm.rs:195:12 [INFO] [stderr] | [INFO] [stderr] 195 | if self.alpha != self.alphamin { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bg_model/gmm.rs:201:12 [INFO] [stderr] | [INFO] [stderr] 201 | if self.components.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.components.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bg_model/gmm.rs:384:33 [INFO] [stderr] | [INFO] [stderr] 384 | fn get_test_model(testdata: &Vec>) -> GaussianMixtureModel { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vector3]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bg_model/mod.rs:25:31 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn pixel_to_vector(pixel: &Rgb) -> Vector3 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Rgb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/bg_model/mod.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | pixel.data[0] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/bg_model/mod.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | pixel.data[1] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/bg_model/mod.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | pixel.data[2] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/bg_model/mod.rs:157:26 [INFO] [stderr] | [INFO] [stderr] 157 | Vector3::new(r as f32, g as f32, b as f32), [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/bg_model/mod.rs:157:36 [INFO] [stderr] | [INFO] [stderr] 157 | Vector3::new(r as f32, g as f32, b as f32), [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/bg_model/mod.rs:157:46 [INFO] [stderr] | [INFO] [stderr] 157 | Vector3::new(r as f32, g as f32, b as f32), [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:35:45 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn import_images>(paths: &Vec

) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[P]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `traffic_counter`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c3ceb19f147365d4627eada1e9534ff49e83507577c20500f331fac5c858164f"` [INFO] running `"docker" "rm" "-f" "c3ceb19f147365d4627eada1e9534ff49e83507577c20500f331fac5c858164f"` [INFO] [stdout] c3ceb19f147365d4627eada1e9534ff49e83507577c20500f331fac5c858164f