[INFO] updating cached repository jit-y/spreadsheet_textconv [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jit-y/spreadsheet_textconv [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jit-y/spreadsheet_textconv" "work/ex/clippy-test-run/sources/stable/gh/jit-y/spreadsheet_textconv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jit-y/spreadsheet_textconv'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jit-y/spreadsheet_textconv" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jit-y/spreadsheet_textconv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jit-y/spreadsheet_textconv'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 754f4aef186fd5aca3bdd67fa7837d5e955ab205 [INFO] sha for GitHub repo jit-y/spreadsheet_textconv: 754f4aef186fd5aca3bdd67fa7837d5e955ab205 [INFO] validating manifest of jit-y/spreadsheet_textconv on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jit-y/spreadsheet_textconv on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jit-y/spreadsheet_textconv [INFO] finished frobbing jit-y/spreadsheet_textconv [INFO] frobbed toml for jit-y/spreadsheet_textconv written to work/ex/clippy-test-run/sources/stable/gh/jit-y/spreadsheet_textconv/Cargo.toml [INFO] started frobbing jit-y/spreadsheet_textconv [INFO] finished frobbing jit-y/spreadsheet_textconv [INFO] frobbed toml for jit-y/spreadsheet_textconv written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jit-y/spreadsheet_textconv/Cargo.toml [INFO] crate jit-y/spreadsheet_textconv has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jit-y/spreadsheet_textconv against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jit-y/spreadsheet_textconv:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a39e46ddada82e3fa0622a439f10e08f97ab3b991dfc3f79447f67b7a37173f2 [INFO] running `"docker" "start" "-a" "a39e46ddada82e3fa0622a439f10e08f97ab3b991dfc3f79447f67b7a37173f2"` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Compiling miniz-sys v0.1.10 [INFO] [stderr] Checking encoding_rs v0.7.1 [INFO] [stderr] Checking encoding_rs v0.6.11 [INFO] [stderr] Checking msdos_time v0.1.5 [INFO] [stderr] Checking flate2 v0.2.20 [INFO] [stderr] Checking zip v0.2.6 [INFO] [stderr] Checking backtrace v0.3.3 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking quick-xml v0.9.4 [INFO] [stderr] Checking calamine v0.11.8 [INFO] [stderr] Checking spreadsheet_textconv v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/main.rs:13:44 [INFO] [stderr] | [INFO] [stderr] 13 | static ref REGEX_N: Regex = Regex::new(r"\n").unwrap(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/main.rs:14:44 [INFO] [stderr] | [INFO] [stderr] 14 | static ref REGEX_R: Regex = Regex::new(r"\r").unwrap(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/main.rs:15:44 [INFO] [stderr] | [INFO] [stderr] 15 | static ref REGEX_T: Regex = Regex::new(r"\t").unwrap(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/main.rs:16:45 [INFO] [stderr] | [INFO] [stderr] 16 | static ref REGEX_BS: Regex = Regex::new(r"\\").unwrap(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:24:38 [INFO] [stderr] | [INFO] [stderr] 24 | let file_path: &Path = Path::new(args.get(1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/main.rs:13:44 [INFO] [stderr] | [INFO] [stderr] 13 | static ref REGEX_N: Regex = Regex::new(r"\n").unwrap(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/main.rs:14:44 [INFO] [stderr] | [INFO] [stderr] 14 | static ref REGEX_R: Regex = Regex::new(r"\r").unwrap(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/main.rs:15:44 [INFO] [stderr] | [INFO] [stderr] 15 | static ref REGEX_T: Regex = Regex::new(r"\t").unwrap(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/main.rs:16:45 [INFO] [stderr] | [INFO] [stderr] 16 | static ref REGEX_BS: Regex = Regex::new(r"\\").unwrap(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:24:38 [INFO] [stderr] | [INFO] [stderr] 24 | let file_path: &Path = Path::new(args.get(1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 26.07s [INFO] running `"docker" "inspect" "a39e46ddada82e3fa0622a439f10e08f97ab3b991dfc3f79447f67b7a37173f2"` [INFO] running `"docker" "rm" "-f" "a39e46ddada82e3fa0622a439f10e08f97ab3b991dfc3f79447f67b7a37173f2"` [INFO] [stdout] a39e46ddada82e3fa0622a439f10e08f97ab3b991dfc3f79447f67b7a37173f2