[INFO] updating cached repository jiqiang/rustbyexample [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jiqiang/rustbyexample [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jiqiang/rustbyexample" "work/ex/clippy-test-run/sources/stable/gh/jiqiang/rustbyexample"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jiqiang/rustbyexample'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jiqiang/rustbyexample" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jiqiang/rustbyexample"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jiqiang/rustbyexample'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c126372694f641f35e262fc11117036c5201166b [INFO] sha for GitHub repo jiqiang/rustbyexample: c126372694f641f35e262fc11117036c5201166b [INFO] validating manifest of jiqiang/rustbyexample on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jiqiang/rustbyexample on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jiqiang/rustbyexample [INFO] finished frobbing jiqiang/rustbyexample [INFO] frobbed toml for jiqiang/rustbyexample written to work/ex/clippy-test-run/sources/stable/gh/jiqiang/rustbyexample/Cargo.toml [INFO] started frobbing jiqiang/rustbyexample [INFO] finished frobbing jiqiang/rustbyexample [INFO] frobbed toml for jiqiang/rustbyexample written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jiqiang/rustbyexample/Cargo.toml [INFO] crate jiqiang/rustbyexample has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jiqiang/rustbyexample against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jiqiang/rustbyexample:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6d6ef62e065f6302dc87e03948d03628b7b6e9ddcf6fc68968de8f6c714bd69b [INFO] running `"docker" "start" "-a" "6d6ef62e065f6302dc87e03948d03628b7b6e9ddcf6fc68968de8f6c714bd69b"` [INFO] [stderr] Checking rustbyexample v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/structures.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | return (rect.p2.x - rect.p1.x) * (rect.p2.y - rect.p1.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(rect.p2.x - rect.p1.x) * (rect.p2.y - rect.p1.y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/structures.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / return Rectangle { [INFO] [stderr] 34 | | p1: Point { x: p.x, y: p.y + w }, [INFO] [stderr] 35 | | p2: Point { x: p.x + w, y: p.y } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | Rectangle { [INFO] [stderr] 34 | p1: Point { x: p.x, y: p.y + w }, [INFO] [stderr] 35 | p2: Point { x: p.x + w, y: p.y } [INFO] [stderr] 36 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/enum_linked_list.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | format!("Nils") [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Nils".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/formatted_print.rs:54:20 [INFO] [stderr] | [INFO] [stderr] 54 | println!("{}", 32); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/formatted_print.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | println!("{1} {0}", 2, 3); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/formatted_print.rs:55:28 [INFO] [stderr] | [INFO] [stderr] 55 | println!("{1} {0}", 2, 3); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/formatted_print.rs:56:35 [INFO] [stderr] | [INFO] [stderr] 56 | println!("{glenn} {joy}", joy=37, glenn=40); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/formatted_print.rs:56:45 [INFO] [stderr] | [INFO] [stderr] 56 | println!("{glenn} {joy}", joy=37, glenn=40); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/custom_types.rs:29:26 [INFO] [stderr] | [INFO] [stderr] 29 | List::Nil => format!("Nil") [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"Nil".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/formatted_print.rs:65:14 [INFO] [stderr] | [INFO] [stderr] 65 | let pi = 3.1415926; [INFO] [stderr] | ^^^^^^^^^ help: consider: `3.141_592_6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/primitives.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | println!("{}", 1_000_000u32); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/bin/formatted_print.rs:65:14 [INFO] [stderr] | [INFO] [stderr] 65 | let pi = 3.1415926; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/formatted_print.rs:54:20 [INFO] [stderr] | [INFO] [stderr] 54 | println!("{}", 32); [INFO] [stderr] | ^^ [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/formatted_print.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | println!("{1} {0}", 2, 3); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/formatted_print.rs:55:28 [INFO] [stderr] | [INFO] [stderr] 55 | println!("{1} {0}", 2, 3); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/formatted_print.rs:56:35 [INFO] [stderr] | [INFO] [stderr] 56 | println!("{glenn} {joy}", joy=37, glenn=40); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/formatted_print.rs:56:45 [INFO] [stderr] | [INFO] [stderr] 56 | println!("{glenn} {joy}", joy=37, glenn=40); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustbyexample`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/enum_linked_list.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | format!("Nils") [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Nils".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/formatted_print.rs:65:14 [INFO] [stderr] | [INFO] [stderr] 65 | let pi = 3.1415926; [INFO] [stderr] | ^^^^^^^^^ help: consider: `3.141_592_6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/bin/formatted_print.rs:65:14 [INFO] [stderr] | [INFO] [stderr] 65 | let pi = 3.1415926; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustbyexample`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "6d6ef62e065f6302dc87e03948d03628b7b6e9ddcf6fc68968de8f6c714bd69b"` [INFO] running `"docker" "rm" "-f" "6d6ef62e065f6302dc87e03948d03628b7b6e9ddcf6fc68968de8f6c714bd69b"` [INFO] [stdout] 6d6ef62e065f6302dc87e03948d03628b7b6e9ddcf6fc68968de8f6c714bd69b