[INFO] updating cached repository jimktrains/predictrs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jimktrains/predictrs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jimktrains/predictrs" "work/ex/clippy-test-run/sources/stable/gh/jimktrains/predictrs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jimktrains/predictrs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jimktrains/predictrs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jimktrains/predictrs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jimktrains/predictrs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] caf11b4b440dbe0e5c80e2bd27b6e9c5ec41af3a [INFO] sha for GitHub repo jimktrains/predictrs: caf11b4b440dbe0e5c80e2bd27b6e9c5ec41af3a [INFO] validating manifest of jimktrains/predictrs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jimktrains/predictrs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jimktrains/predictrs [INFO] finished frobbing jimktrains/predictrs [INFO] frobbed toml for jimktrains/predictrs written to work/ex/clippy-test-run/sources/stable/gh/jimktrains/predictrs/Cargo.toml [INFO] started frobbing jimktrains/predictrs [INFO] finished frobbing jimktrains/predictrs [INFO] frobbed toml for jimktrains/predictrs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jimktrains/predictrs/Cargo.toml [INFO] crate jimktrains/predictrs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jimktrains/predictrs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jimktrains/predictrs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8cbad905e3cba69c0fb15f723ae45c10da843303027ea555c2d82038faac3377 [INFO] running `"docker" "start" "-a" "8cbad905e3cba69c0fb15f723ae45c10da843303027ea555c2d82038faac3377"` [INFO] [stderr] Checking predictrs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sbsqsort.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | let v: *mut T = &mut arr[right as usize]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sbsqsort.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | let mut k: isize = left; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:81:7 [INFO] [stderr] | [INFO] [stderr] 81 | categories: categories, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `categories` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:82:7 [INFO] [stderr] | [INFO] [stderr] 82 | pages: pages [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `pages` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sbsqsort.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | let v: *mut T = &mut arr[right as usize]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sbsqsort.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | let mut k: isize = left; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:81:7 [INFO] [stderr] | [INFO] [stderr] 81 | categories: categories, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `categories` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:82:7 [INFO] [stderr] | [INFO] [stderr] 82 | pages: pages [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `pages` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | return keys; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `keys` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine.rs:142:6 [INFO] [stderr] | [INFO] [stderr] 142 | return 1000 * ((2 * found_in_both) as u64 / (cnt_a + cnt_b - found_in_both)) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `1000 * ((2 * found_in_both) as u64 / (cnt_a + cnt_b - found_in_both)) as u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | return keys; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `keys` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine.rs:142:6 [INFO] [stderr] | [INFO] [stderr] 142 | return 1000 * ((2 * found_in_both) as u64 / (cnt_a + cnt_b - found_in_both)) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `1000 * ((2 * found_in_both) as u64 / (cnt_a + cnt_b - found_in_both)) as u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/engine.rs:52:41 [INFO] [stderr] | [INFO] [stderr] 52 | let data : Vec<&str> = line.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/engine.rs:68:24 [INFO] [stderr] | [INFO] [stderr] 68 | .or_insert(BTreeSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(BTreeSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/engine.rs:75:20 [INFO] [stderr] | [INFO] [stderr] 75 | .or_insert(BTreeSet::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(BTreeSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/engine.rs:97:7 [INFO] [stderr] | [INFO] [stderr] 97 | / match self.categories.get(category) { [INFO] [stderr] 98 | | Some(self_cat) => { [INFO] [stderr] 99 | | for page in self_cat.iter() { [INFO] [stderr] 100 | | match self.pages.get(page) { [INFO] [stderr] ... | [INFO] [stderr] 110 | | _ => {} [INFO] [stderr] 111 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 97 | if let Some(self_cat) = self.categories.get(category) { [INFO] [stderr] 98 | for page in self_cat.iter() { [INFO] [stderr] 99 | match self.pages.get(page) { [INFO] [stderr] 100 | Some(pages) => { [INFO] [stderr] 101 | ranked_pages.entry(page.clone()) [INFO] [stderr] 102 | .or_insert( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/engine.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | / match self.pages.get(page) { [INFO] [stderr] 101 | | Some(pages) => { [INFO] [stderr] 102 | | ranked_pages.entry(page.clone()) [INFO] [stderr] 103 | | .or_insert( [INFO] [stderr] ... | [INFO] [stderr] 106 | | _ => {} [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 100 | if let Some(pages) = self.pages.get(page) { [INFO] [stderr] 101 | ranked_pages.entry(page.clone()) [INFO] [stderr] 102 | .or_insert( [INFO] [stderr] 103 | Recommender::similarity(categories.iter(), pages.iter())); [INFO] [stderr] 104 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/engine.rs:103:30 [INFO] [stderr] | [INFO] [stderr] 103 | .or_insert( [INFO] [stderr] | ______________________________^ [INFO] [stderr] 104 | | Recommender::similarity(categories.iter(), pages.iter())); [INFO] [stderr] | |_________________________________________________________________________________________^ help: try this: `or_insert_with(|| Recommender::similarity(categories.iter(), pages.iter()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/engine.rs:52:41 [INFO] [stderr] | [INFO] [stderr] 52 | let data : Vec<&str> = line.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/engine.rs:68:24 [INFO] [stderr] | [INFO] [stderr] 68 | .or_insert(BTreeSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(BTreeSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/engine.rs:75:20 [INFO] [stderr] | [INFO] [stderr] 75 | .or_insert(BTreeSet::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(BTreeSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/engine.rs:97:7 [INFO] [stderr] | [INFO] [stderr] 97 | / match self.categories.get(category) { [INFO] [stderr] 98 | | Some(self_cat) => { [INFO] [stderr] 99 | | for page in self_cat.iter() { [INFO] [stderr] 100 | | match self.pages.get(page) { [INFO] [stderr] ... | [INFO] [stderr] 110 | | _ => {} [INFO] [stderr] 111 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 97 | if let Some(self_cat) = self.categories.get(category) { [INFO] [stderr] 98 | for page in self_cat.iter() { [INFO] [stderr] 99 | match self.pages.get(page) { [INFO] [stderr] 100 | Some(pages) => { [INFO] [stderr] 101 | ranked_pages.entry(page.clone()) [INFO] [stderr] 102 | .or_insert( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/engine.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | / match self.pages.get(page) { [INFO] [stderr] 101 | | Some(pages) => { [INFO] [stderr] 102 | | ranked_pages.entry(page.clone()) [INFO] [stderr] 103 | | .or_insert( [INFO] [stderr] ... | [INFO] [stderr] 106 | | _ => {} [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 100 | if let Some(pages) = self.pages.get(page) { [INFO] [stderr] 101 | ranked_pages.entry(page.clone()) [INFO] [stderr] 102 | .or_insert( [INFO] [stderr] 103 | Recommender::similarity(categories.iter(), pages.iter())); [INFO] [stderr] 104 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/engine.rs:103:30 [INFO] [stderr] | [INFO] [stderr] 103 | .or_insert( [INFO] [stderr] | ______________________________^ [INFO] [stderr] 104 | | Recommender::similarity(categories.iter(), pages.iter())); [INFO] [stderr] | |_________________________________________________________________________________________^ help: try this: `or_insert_with(|| Recommender::similarity(categories.iter(), pages.iter()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.81s [INFO] running `"docker" "inspect" "8cbad905e3cba69c0fb15f723ae45c10da843303027ea555c2d82038faac3377"` [INFO] running `"docker" "rm" "-f" "8cbad905e3cba69c0fb15f723ae45c10da843303027ea555c2d82038faac3377"` [INFO] [stdout] 8cbad905e3cba69c0fb15f723ae45c10da843303027ea555c2d82038faac3377