[INFO] updating cached repository jimblandy/rbattle [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jimblandy/rbattle [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jimblandy/rbattle" "work/ex/clippy-test-run/sources/stable/gh/jimblandy/rbattle"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jimblandy/rbattle'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jimblandy/rbattle" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jimblandy/rbattle"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jimblandy/rbattle'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 629d1adb222d52e3ba0decb002e72519731395b8 [INFO] sha for GitHub repo jimblandy/rbattle: 629d1adb222d52e3ba0decb002e72519731395b8 [INFO] validating manifest of jimblandy/rbattle on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jimblandy/rbattle on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jimblandy/rbattle [INFO] finished frobbing jimblandy/rbattle [INFO] frobbed toml for jimblandy/rbattle written to work/ex/clippy-test-run/sources/stable/gh/jimblandy/rbattle/Cargo.toml [INFO] started frobbing jimblandy/rbattle [INFO] finished frobbing jimblandy/rbattle [INFO] frobbed toml for jimblandy/rbattle written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jimblandy/rbattle/Cargo.toml [INFO] crate jimblandy/rbattle has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jimblandy/rbattle against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jimblandy/rbattle:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 35fede1a45ebc66e8480d4d84b604d60625c067464ea321101a47c934e0cdfdc [INFO] running `"docker" "start" "-a" "35fede1a45ebc66e8480d4d84b604d60625c067464ea321101a47c934e0cdfdc"` [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking serde_json v1.0.28 [INFO] [stderr] Checking tokio-reactor v0.1.5 [INFO] [stderr] Checking smithay-client-toolkit v0.2.6 [INFO] [stderr] Checking tokio-uds v0.2.1 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking winit v0.16.2 [INFO] [stderr] Compiling glutin v0.17.0 [INFO] [stderr] Compiling glium v0.22.0 [INFO] [stderr] Checking tokio v0.1.8 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking rbattle v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test_utils.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | neighbor: neighbor [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `neighbor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/math.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | lhs[2] + rhs[02]] [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 81 | lhs[2] + rhs[2]] [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 81 | lhs[2] + rhs[0o2]] [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/scheduler.rs:11:27 [INFO] [stderr] | [INFO] [stderr] 11 | const MIN_DELAY_NS: u32 = 016_000_000; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 11 | const MIN_DELAY_NS: u32 = 16_000_000; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 11 | const MIN_DELAY_NS: u32 = 0o16_000_000; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/state.rs:92:33 [INFO] [stderr] | [INFO] [stderr] 92 | const SEED: [u64; 2] = [0xcd9d5eaaf04bc9a7, 0x4602cc7098d01ef9]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xcd9d_5eaa_f04b_c9a7` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/state.rs:92:53 [INFO] [stderr] | [INFO] [stderr] 92 | const SEED: [u64; 2] = [0xcd9d5eaaf04bc9a7, 0x4602cc7098d01ef9]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4602_cc70_98d0_1ef9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/math.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | lhs[2] + rhs[02]] [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 81 | lhs[2] + rhs[2]] [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 81 | lhs[2] + rhs[0o2]] [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/scheduler.rs:11:27 [INFO] [stderr] | [INFO] [stderr] 11 | const MIN_DELAY_NS: u32 = 016_000_000; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 11 | const MIN_DELAY_NS: u32 = 16_000_000; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 11 | const MIN_DELAY_NS: u32 = 0o16_000_000; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/state.rs:92:33 [INFO] [stderr] | [INFO] [stderr] 92 | const SEED: [u64; 2] = [0xcd9d5eaaf04bc9a7, 0x4602cc7098d01ef9]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xcd9d_5eaa_f04b_c9a7` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/state.rs:92:53 [INFO] [stderr] | [INFO] [stderr] 92 | const SEED: [u64; 2] = [0xcd9d5eaaf04bc9a7, 0x4602cc7098d01ef9]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4602_cc70_98d0_1ef9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/xorshift.rs:70:32 [INFO] [stderr] | [INFO] [stderr] 70 | assert_eq!(rng.next_u64(), 0x800049); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0080_0049` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/xorshift.rs:71:32 [INFO] [stderr] | [INFO] [stderr] 71 | assert_eq!(rng.next_u64(), 0x3000186); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0300_0186` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/xorshift.rs:72:32 [INFO] [stderr] | [INFO] [stderr] 72 | assert_eq!(rng.next_u64(), 0x400003001145); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x4000_0300_1145` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/drawer.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | / match state { [INFO] [stderr] 275 | | &Some(ref occupied) => { [INFO] [stderr] 276 | | let GraphPt(start) = map.graph.center(node); [INFO] [stderr] 277 | | for &outflow in &occupied.outflows { [INFO] [stderr] ... | [INFO] [stderr] 285 | | _ => () [INFO] [stderr] 286 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 274 | if let &Some(ref occupied) = state { [INFO] [stderr] 275 | let GraphPt(start) = map.graph.center(node); [INFO] [stderr] 276 | for &outflow in &occupied.outflows { [INFO] [stderr] 277 | let GraphPt(end) = map.graph.center(outflow); [INFO] [stderr] 278 | let mid = midpoint(start, end); [INFO] [stderr] 279 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/drawer.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | / match state { [INFO] [stderr] 275 | | &Some(ref occupied) => { [INFO] [stderr] 276 | | let GraphPt(start) = map.graph.center(node); [INFO] [stderr] 277 | | for &outflow in &occupied.outflows { [INFO] [stderr] ... | [INFO] [stderr] 285 | | _ => () [INFO] [stderr] 286 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 274 | match *state { [INFO] [stderr] 275 | Some(ref occupied) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/drawer.rs:291:12 [INFO] [stderr] | [INFO] [stderr] 291 | if vertices.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vertices.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/drawer.rs:369:22 [INFO] [stderr] | [INFO] [stderr] 369 | let (r, g, b) = ((r >> 4) as u32, (g >> 4) as u32, (b >> 4) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(r >> 4)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/drawer.rs:369:39 [INFO] [stderr] | [INFO] [stderr] 369 | let (r, g, b) = ((r >> 4) as u32, (g >> 4) as u32, (b >> 4) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(g >> 4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/drawer.rs:369:56 [INFO] [stderr] | [INFO] [stderr] 369 | let (r, g, b) = ((r >> 4) as u32, (g >> 4) as u32, (b >> 4) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(b >> 4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `base` [INFO] [stderr] --> src/drawer.rs:431:26 [INFO] [stderr] | [INFO] [stderr] 431 | indices.push((base + 0) as u32); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `base` [INFO] [stderr] --> src/drawer.rs:438:26 [INFO] [stderr] | [INFO] [stderr] 438 | indices.push((base + 0) as u32); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/drawer.rs:463:13 [INFO] [stderr] | [INFO] [stderr] 463 | / match state { [INFO] [stderr] 464 | | &Some(ref occupied) if occupied.goop > 0 => { [INFO] [stderr] 465 | | // Find the center of the circle of this player's color. [INFO] [stderr] 466 | | let center = color_to_circle(map.player_colors[occupied.player.0]); [INFO] [stderr] ... | [INFO] [stderr] 480 | | } [INFO] [stderr] 481 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 463 | match *state { [INFO] [stderr] 464 | Some(ref occupied) if occupied.goop > 0 => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/protocol.rs:175:17 [INFO] [stderr] | [INFO] [stderr] 175 | assert!(params.player_colors.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!params.player_colors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/square.rs:151:19 [INFO] [stderr] | [INFO] [stderr] 151 | line: sw + pt_cols .. sw + pt_cols + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `sw + pt_cols..=sw + pt_cols` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/square.rs:157:19 [INFO] [stderr] | [INFO] [stderr] 157 | line: sw + pt_cols + 1 .. sw + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `sw + pt_cols + 1..=sw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/square.rs:178:18 [INFO] [stderr] | [INFO] [stderr] 178 | for r in 0 .. self.rows + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `0..=self.rows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/square.rs:179:22 [INFO] [stderr] | [INFO] [stderr] 179 | for c in 0 .. self.cols + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `0..=self.cols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/state.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | / if let &Some(ref occupied) = &self.nodes[node] { [INFO] [stderr] 132 | | for &outflow in &occupied.outflows { [INFO] [stderr] 133 | | outflow_list.push((node, outflow)) [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 131 | if let Some(ref occupied) = self.nodes[node] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/state.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | / match &mut self.nodes[source] { [INFO] [stderr] 156 | | &mut None => panic!("source nodes should always be occupied by someone"), [INFO] [stderr] 157 | | &mut Some(Occupied { ref mut goop, .. }) => { [INFO] [stderr] 158 | | if *goop < MAX_GOOP { [INFO] [stderr] ... | [INFO] [stderr] 161 | | } [INFO] [stderr] 162 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 155 | match *(&mut self.nodes[source]) { [INFO] [stderr] 156 | None => panic!("source nodes should always be occupied by someone"), [INFO] [stderr] 157 | Some(Occupied { ref mut goop, .. }) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/state.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | / match action { [INFO] [stderr] 179 | | &Action::ToggleOutflow { player, from, to } => { [INFO] [stderr] 180 | | match &mut self.nodes[from] { [INFO] [stderr] 181 | | // This node is empty. Don't change it. [INFO] [stderr] ... | [INFO] [stderr] 196 | | } [INFO] [stderr] 197 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 178 | match *action { [INFO] [stderr] 179 | Action::ToggleOutflow { player, from, to } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/state.rs:180:17 [INFO] [stderr] | [INFO] [stderr] 180 | / match &mut self.nodes[from] { [INFO] [stderr] 181 | | // This node is empty. Don't change it. [INFO] [stderr] 182 | | &mut None => (), [INFO] [stderr] 183 | | [INFO] [stderr] ... | [INFO] [stderr] 194 | | } [INFO] [stderr] 195 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 180 | match *(&mut self.nodes[from]) { [INFO] [stderr] 181 | // This node is empty. Don't change it. [INFO] [stderr] 182 | None => (), [INFO] [stderr] 183 | [INFO] [stderr] 184 | // Some other player owns this node. Do nothing. [INFO] [stderr] 185 | Some(Occupied { player: p, .. }) if p != player => (), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/state.rs:480:1 [INFO] [stderr] | [INFO] [stderr] 480 | / impl Hash for Occupied { [INFO] [stderr] 481 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 482 | | self.player.hash(state); [INFO] [stderr] 483 | | for outflow in &self.outflows { [INFO] [stderr] ... | [INFO] [stderr] 488 | | } [INFO] [stderr] 489 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/state.rs:50:24 [INFO] [stderr] | [INFO] [stderr] 50 | #[derive(Clone, Debug, PartialEq, Serialize, Deserialize)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/visible_graph.rs:81:24 [INFO] [stderr] | [INFO] [stderr] 81 | fn edge_hit(&self, &GraphPt) -> Option<(Node, Node)>; [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `GraphPt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rbattle`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/drawer.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | / match state { [INFO] [stderr] 275 | | &Some(ref occupied) => { [INFO] [stderr] 276 | | let GraphPt(start) = map.graph.center(node); [INFO] [stderr] 277 | | for &outflow in &occupied.outflows { [INFO] [stderr] ... | [INFO] [stderr] 285 | | _ => () [INFO] [stderr] 286 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 274 | if let &Some(ref occupied) = state { [INFO] [stderr] 275 | let GraphPt(start) = map.graph.center(node); [INFO] [stderr] 276 | for &outflow in &occupied.outflows { [INFO] [stderr] 277 | let GraphPt(end) = map.graph.center(outflow); [INFO] [stderr] 278 | let mid = midpoint(start, end); [INFO] [stderr] 279 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/drawer.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | / match state { [INFO] [stderr] 275 | | &Some(ref occupied) => { [INFO] [stderr] 276 | | let GraphPt(start) = map.graph.center(node); [INFO] [stderr] 277 | | for &outflow in &occupied.outflows { [INFO] [stderr] ... | [INFO] [stderr] 285 | | _ => () [INFO] [stderr] 286 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 274 | match *state { [INFO] [stderr] 275 | Some(ref occupied) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/drawer.rs:291:12 [INFO] [stderr] | [INFO] [stderr] 291 | if vertices.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vertices.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/drawer.rs:369:22 [INFO] [stderr] | [INFO] [stderr] 369 | let (r, g, b) = ((r >> 4) as u32, (g >> 4) as u32, (b >> 4) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(r >> 4)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/drawer.rs:369:39 [INFO] [stderr] | [INFO] [stderr] 369 | let (r, g, b) = ((r >> 4) as u32, (g >> 4) as u32, (b >> 4) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(g >> 4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/drawer.rs:369:56 [INFO] [stderr] | [INFO] [stderr] 369 | let (r, g, b) = ((r >> 4) as u32, (g >> 4) as u32, (b >> 4) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(b >> 4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `base` [INFO] [stderr] --> src/drawer.rs:431:26 [INFO] [stderr] | [INFO] [stderr] 431 | indices.push((base + 0) as u32); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `base` [INFO] [stderr] --> src/drawer.rs:438:26 [INFO] [stderr] | [INFO] [stderr] 438 | indices.push((base + 0) as u32); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/drawer.rs:463:13 [INFO] [stderr] | [INFO] [stderr] 463 | / match state { [INFO] [stderr] 464 | | &Some(ref occupied) if occupied.goop > 0 => { [INFO] [stderr] 465 | | // Find the center of the circle of this player's color. [INFO] [stderr] 466 | | let center = color_to_circle(map.player_colors[occupied.player.0]); [INFO] [stderr] ... | [INFO] [stderr] 480 | | } [INFO] [stderr] 481 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 463 | match *state { [INFO] [stderr] 464 | Some(ref occupied) if occupied.goop > 0 => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/protocol.rs:175:17 [INFO] [stderr] | [INFO] [stderr] 175 | assert!(params.player_colors.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!params.player_colors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/square.rs:151:19 [INFO] [stderr] | [INFO] [stderr] 151 | line: sw + pt_cols .. sw + pt_cols + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `sw + pt_cols..=sw + pt_cols` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/square.rs:157:19 [INFO] [stderr] | [INFO] [stderr] 157 | line: sw + pt_cols + 1 .. sw + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `sw + pt_cols + 1..=sw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/square.rs:178:18 [INFO] [stderr] | [INFO] [stderr] 178 | for r in 0 .. self.rows + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `0..=self.rows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/square.rs:179:22 [INFO] [stderr] | [INFO] [stderr] 179 | for c in 0 .. self.cols + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `0..=self.cols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/square.rs:287:9 [INFO] [stderr] | [INFO] [stderr] 287 | assert_eq!(SquareGrid::new(1, 1).radius(), 0.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/square.rs:287:9 [INFO] [stderr] | [INFO] [stderr] 287 | assert_eq!(SquareGrid::new(1, 1).radius(), 0.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/square.rs:346:5 [INFO] [stderr] | [INFO] [stderr] 346 | / fn boundary_hit() { [INFO] [stderr] 347 | | // These tests are not black-box: they know the general algorithm [INFO] [stderr] 348 | | // `boundary_hit` implements, and the value of TOLERANCE. But they [INFO] [stderr] 349 | | // should mostly be okay with any reasonable hit definition. [INFO] [stderr] ... | [INFO] [stderr] 403 | | assert_eq!(grid.edge_hit(&gp(2.1, 1.6)), Some((6, 5))); [INFO] [stderr] 404 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/state.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | / if let &Some(ref occupied) = &self.nodes[node] { [INFO] [stderr] 132 | | for &outflow in &occupied.outflows { [INFO] [stderr] 133 | | outflow_list.push((node, outflow)) [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 131 | if let Some(ref occupied) = self.nodes[node] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/state.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | / match &mut self.nodes[source] { [INFO] [stderr] 156 | | &mut None => panic!("source nodes should always be occupied by someone"), [INFO] [stderr] 157 | | &mut Some(Occupied { ref mut goop, .. }) => { [INFO] [stderr] 158 | | if *goop < MAX_GOOP { [INFO] [stderr] ... | [INFO] [stderr] 161 | | } [INFO] [stderr] 162 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 155 | match *(&mut self.nodes[source]) { [INFO] [stderr] 156 | None => panic!("source nodes should always be occupied by someone"), [INFO] [stderr] 157 | Some(Occupied { ref mut goop, .. }) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/state.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | / match action { [INFO] [stderr] 179 | | &Action::ToggleOutflow { player, from, to } => { [INFO] [stderr] 180 | | match &mut self.nodes[from] { [INFO] [stderr] 181 | | // This node is empty. Don't change it. [INFO] [stderr] ... | [INFO] [stderr] 196 | | } [INFO] [stderr] 197 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 178 | match *action { [INFO] [stderr] 179 | Action::ToggleOutflow { player, from, to } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/state.rs:180:17 [INFO] [stderr] | [INFO] [stderr] 180 | / match &mut self.nodes[from] { [INFO] [stderr] 181 | | // This node is empty. Don't change it. [INFO] [stderr] 182 | | &mut None => (), [INFO] [stderr] 183 | | [INFO] [stderr] ... | [INFO] [stderr] 194 | | } [INFO] [stderr] 195 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 180 | match *(&mut self.nodes[from]) { [INFO] [stderr] 181 | // This node is empty. Don't change it. [INFO] [stderr] 182 | None => (), [INFO] [stderr] 183 | [INFO] [stderr] 184 | // Some other player owns this node. Do nothing. [INFO] [stderr] 185 | Some(Occupied { player: p, .. }) if p != player => (), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/state.rs:480:1 [INFO] [stderr] | [INFO] [stderr] 480 | / impl Hash for Occupied { [INFO] [stderr] 481 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 482 | | self.player.hash(state); [INFO] [stderr] 483 | | for outflow in &self.outflows { [INFO] [stderr] ... | [INFO] [stderr] 488 | | } [INFO] [stderr] 489 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/state.rs:50:24 [INFO] [stderr] | [INFO] [stderr] 50 | #[derive(Clone, Debug, PartialEq, Serialize, Deserialize)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/visible_graph.rs:81:24 [INFO] [stderr] | [INFO] [stderr] 81 | fn edge_hit(&self, &GraphPt) -> Option<(Node, Node)>; [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `GraphPt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rbattle`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "35fede1a45ebc66e8480d4d84b604d60625c067464ea321101a47c934e0cdfdc"` [INFO] running `"docker" "rm" "-f" "35fede1a45ebc66e8480d4d84b604d60625c067464ea321101a47c934e0cdfdc"` [INFO] [stdout] 35fede1a45ebc66e8480d4d84b604d60625c067464ea321101a47c934e0cdfdc