[INFO] updating cached repository jimblandy/hexes [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jimblandy/hexes [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jimblandy/hexes" "work/ex/clippy-test-run/sources/stable/gh/jimblandy/hexes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jimblandy/hexes'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jimblandy/hexes" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jimblandy/hexes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jimblandy/hexes'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2d6d5a7a5482b8b8475996b2cb851f76885fb3c7 [INFO] sha for GitHub repo jimblandy/hexes: 2d6d5a7a5482b8b8475996b2cb851f76885fb3c7 [INFO] validating manifest of jimblandy/hexes on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jimblandy/hexes on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jimblandy/hexes [INFO] finished frobbing jimblandy/hexes [INFO] frobbed toml for jimblandy/hexes written to work/ex/clippy-test-run/sources/stable/gh/jimblandy/hexes/Cargo.toml [INFO] started frobbing jimblandy/hexes [INFO] finished frobbing jimblandy/hexes [INFO] frobbed toml for jimblandy/hexes written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jimblandy/hexes/Cargo.toml [INFO] crate jimblandy/hexes has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jimblandy/hexes against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jimblandy/hexes:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b7ac361ce9be56307dd304dff5aa3c4a539020a93323c209fe75b5d6b613035d [INFO] running `"docker" "start" "-a" "b7ac361ce9be56307dd304dff5aa3c4a539020a93323c209fe75b5d6b613035d"` [INFO] [stderr] Compiling rand v0.3.15 [INFO] [stderr] Checking shared_library v0.1.5 [INFO] [stderr] Compiling wayland-scanner v0.5.11 [INFO] [stderr] Checking cgmath v0.12.0 [INFO] [stderr] Compiling glutin v0.6.2 [INFO] [stderr] Compiling glium v0.15.0 [INFO] [stderr] Checking x11-dl v2.12.0 [INFO] [stderr] Checking backtrace-sys v0.1.5 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking tempfile v2.1.4 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking memmap v0.2.3 [INFO] [stderr] Compiling phf_generator v0.7.20 [INFO] [stderr] Compiling wayland-client v0.5.12 [INFO] [stderr] Compiling phf_codegen v0.7.20 [INFO] [stderr] Compiling target_build_utils v0.1.2 [INFO] [stderr] Compiling libloading v0.3.1 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.5.11 [INFO] [stderr] Checking wayland-kbd v0.3.6 [INFO] [stderr] Checking wayland-window v0.2.3 [INFO] [stderr] Checking hexes v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/main.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | /// You can think of the vertices of a hex grid as the union of four [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:131:20 [INFO] [stderr] | [INFO] [stderr] 131 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 132 | | if col > -EXTENT { [INFO] [stderr] 133 | | hex_indices.push(grid_to_vertex(row, col)); [INFO] [stderr] 134 | | hex_indices.push(grid_to_vertex(row, col - 1)); [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 131 | } else if col > -EXTENT { [INFO] [stderr] 132 | hex_indices.push(grid_to_vertex(row, col)); [INFO] [stderr] 133 | hex_indices.push(grid_to_vertex(row, col - 1)); [INFO] [stderr] 134 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:104:16 [INFO] [stderr] | [INFO] [stderr] 104 | for row in -EXTENT..EXTENT+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `-EXTENT..=EXTENT` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/main.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | /// You can think of the vertices of a hex grid as the union of four [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:131:20 [INFO] [stderr] | [INFO] [stderr] 131 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 132 | | if col > -EXTENT { [INFO] [stderr] 133 | | hex_indices.push(grid_to_vertex(row, col)); [INFO] [stderr] 134 | | hex_indices.push(grid_to_vertex(row, col - 1)); [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 131 | } else if col > -EXTENT { [INFO] [stderr] 132 | hex_indices.push(grid_to_vertex(row, col)); [INFO] [stderr] 133 | hex_indices.push(grid_to_vertex(row, col - 1)); [INFO] [stderr] 134 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:104:16 [INFO] [stderr] | [INFO] [stderr] 104 | for row in -EXTENT..EXTENT+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `-EXTENT..=EXTENT` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 56.45s [INFO] running `"docker" "inspect" "b7ac361ce9be56307dd304dff5aa3c4a539020a93323c209fe75b5d6b613035d"` [INFO] running `"docker" "rm" "-f" "b7ac361ce9be56307dd304dff5aa3c4a539020a93323c209fe75b5d6b613035d"` [INFO] [stdout] b7ac361ce9be56307dd304dff5aa3c4a539020a93323c209fe75b5d6b613035d