[INFO] updating cached repository jianingy/blockchain-demo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jianingy/blockchain-demo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jianingy/blockchain-demo" "work/ex/clippy-test-run/sources/stable/gh/jianingy/blockchain-demo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jianingy/blockchain-demo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jianingy/blockchain-demo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jianingy/blockchain-demo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jianingy/blockchain-demo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 02cdc0963b86006d965efa772db69455c5164265 [INFO] sha for GitHub repo jianingy/blockchain-demo: 02cdc0963b86006d965efa772db69455c5164265 [INFO] validating manifest of jianingy/blockchain-demo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jianingy/blockchain-demo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jianingy/blockchain-demo [INFO] finished frobbing jianingy/blockchain-demo [INFO] frobbed toml for jianingy/blockchain-demo written to work/ex/clippy-test-run/sources/stable/gh/jianingy/blockchain-demo/Cargo.toml [INFO] started frobbing jianingy/blockchain-demo [INFO] finished frobbing jianingy/blockchain-demo [INFO] frobbed toml for jianingy/blockchain-demo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jianingy/blockchain-demo/Cargo.toml [INFO] crate jianingy/blockchain-demo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jianingy/blockchain-demo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jianingy/blockchain-demo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 47ea099ef50e41ff697ca4046fa42eaee2f756083f97ccea2bf7228313e92477 [INFO] running `"docker" "start" "-a" "47ea099ef50e41ff697ca4046fa42eaee2f756083f97ccea2bf7228313e92477"` [INFO] [stderr] Compiling openssl-sys v0.9.31 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking mustache v0.8.2 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Checking libflate v0.1.14 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.4 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking nickel v0.10.1 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Checking blockchain-demo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | amount: amount, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `amount` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | proof: proof, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proof` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | amount: amount, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `amount` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | proof: proof, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proof` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Serialize`, `Serializer` [INFO] [stderr] --> src/blockchain.rs:4:18 [INFO] [stderr] | [INFO] [stderr] 4 | use serde::ser::{Serialize, Serializer}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return chain; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `chain` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | return proof; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `proof` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | return hash[0..2] == [0, 0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hash[0..2] == [0, 0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | return Ok(flag); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(flag)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Serialize`, `Serializer` [INFO] [stderr] --> src/blockchain.rs:4:18 [INFO] [stderr] | [INFO] [stderr] 4 | use serde::ser::{Serialize, Serializer}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return chain; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `chain` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | return proof; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `proof` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | return hash[0..2] == [0, 0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hash[0..2] == [0, 0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | return Ok(flag); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(flag)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/blockchain.rs:155:38 [INFO] [stderr] | [INFO] [stderr] 155 | pub fn valid_chain(&self, chain: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Block]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/blockchain.rs:155:38 [INFO] [stderr] | [INFO] [stderr] 155 | pub fn valid_chain(&self, chain: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Block]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 32.82s [INFO] running `"docker" "inspect" "47ea099ef50e41ff697ca4046fa42eaee2f756083f97ccea2bf7228313e92477"` [INFO] running `"docker" "rm" "-f" "47ea099ef50e41ff697ca4046fa42eaee2f756083f97ccea2bf7228313e92477"` [INFO] [stdout] 47ea099ef50e41ff697ca4046fa42eaee2f756083f97ccea2bf7228313e92477