[INFO] updating cached repository jhoudan/monkey-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jhoudan/monkey-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jhoudan/monkey-rs" "work/ex/clippy-test-run/sources/stable/gh/jhoudan/monkey-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jhoudan/monkey-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jhoudan/monkey-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jhoudan/monkey-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jhoudan/monkey-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5972dc7ac9f94f5123591c2b5ad6978d21bd1cb7 [INFO] sha for GitHub repo jhoudan/monkey-rs: 5972dc7ac9f94f5123591c2b5ad6978d21bd1cb7 [INFO] validating manifest of jhoudan/monkey-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jhoudan/monkey-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jhoudan/monkey-rs [INFO] finished frobbing jhoudan/monkey-rs [INFO] frobbed toml for jhoudan/monkey-rs written to work/ex/clippy-test-run/sources/stable/gh/jhoudan/monkey-rs/Cargo.toml [INFO] started frobbing jhoudan/monkey-rs [INFO] finished frobbing jhoudan/monkey-rs [INFO] frobbed toml for jhoudan/monkey-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jhoudan/monkey-rs/Cargo.toml [INFO] crate jhoudan/monkey-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jhoudan/monkey-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jhoudan/monkey-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6790188be5913796f7702ff7c6d160b81307047fa8707681367b194791ca60cf [INFO] running `"docker" "start" "-a" "6790188be5913796f7702ff7c6d160b81307047fa8707681367b194791ca60cf"` [INFO] [stderr] Checking monkey v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | lexer: lexer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lexer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | cur_token: cur_token, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cur_token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | next_token: next_token, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next_token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | lexer: lexer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lexer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | cur_token: cur_token, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cur_token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | next_token: next_token, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next_token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `token::Token` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use token::Token; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `token::Token` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use token::Token; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Program` [INFO] [stderr] --> src/ast.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub struct Program { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/ast.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn new() -> Program { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `token_literal` [INFO] [stderr] --> src/ast.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | fn token_literal(&self) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Statement` [INFO] [stderr] --> src/ast.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | pub struct Statement { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `token_literal` [INFO] [stderr] --> src/ast.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | fn token_literal(&self) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Expression` [INFO] [stderr] --> src/ast.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | struct Expression; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Parser` [INFO] [stderr] --> src/parser.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub struct Parser<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/parser.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | fn new(mut lexer: Lexer) -> Parser { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `next_token` [INFO] [stderr] --> src/parser.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | fn next_token(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `take_current_token` [INFO] [stderr] --> src/parser.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | fn take_current_token(&mut self) -> Token { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `parse_program` [INFO] [stderr] --> src/parser.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | fn parse_program(&mut self) -> Program { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `parse_statement` [INFO] [stderr] --> src/parser.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | fn parse_statement(&mut self) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `parse_let_statement` [INFO] [stderr] --> src/parser.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | fn parse_let_statement(&mut self) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the `e @ _` pattern can be written as just `e` [INFO] [stderr] --> src/lexer.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | e @ _ => Some(e), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: unused variable: `lexer` [INFO] [stderr] --> src/lexer.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | let mut lexer = Lexer::new(input); [INFO] [stderr] | ^^^^^ help: consider using `_lexer` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/ast.rs:19:14 [INFO] [stderr] | [INFO] [stderr] 19 | .unwrap_or("".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:24:33 [INFO] [stderr] | [INFO] [stderr] 24 | while let Some(token) = lexer.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for token in lexer { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lexer.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | let mut lexer = Lexer::new(input); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `token_literal` [INFO] [stderr] --> src/ast.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | fn token_literal(&self) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `token_literal` [INFO] [stderr] --> src/ast.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | fn token_literal(&self) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Expression` [INFO] [stderr] --> src/ast.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | struct Expression; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the `e @ _` pattern can be written as just `e` [INFO] [stderr] --> src/lexer.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | e @ _ => Some(e), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/ast.rs:19:14 [INFO] [stderr] | [INFO] [stderr] 19 | .unwrap_or("".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:24:33 [INFO] [stderr] | [INFO] [stderr] 24 | while let Some(token) = lexer.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for token in lexer { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.87s [INFO] running `"docker" "inspect" "6790188be5913796f7702ff7c6d160b81307047fa8707681367b194791ca60cf"` [INFO] running `"docker" "rm" "-f" "6790188be5913796f7702ff7c6d160b81307047fa8707681367b194791ca60cf"` [INFO] [stdout] 6790188be5913796f7702ff7c6d160b81307047fa8707681367b194791ca60cf