[INFO] updating cached repository jhjaggars/tl
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jhjaggars/tl
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jhjaggars/tl" "work/ex/clippy-test-run/sources/stable/gh/jhjaggars/tl"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jhjaggars/tl'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jhjaggars/tl" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jhjaggars/tl"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jhjaggars/tl'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 6d8535328ffd0b6018bcbbd3efe7117471c41cf7
[INFO] sha for GitHub repo jhjaggars/tl: 6d8535328ffd0b6018bcbbd3efe7117471c41cf7
[INFO] validating manifest of jhjaggars/tl on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jhjaggars/tl on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jhjaggars/tl
[INFO] finished frobbing jhjaggars/tl
[INFO] frobbed toml for jhjaggars/tl written to work/ex/clippy-test-run/sources/stable/gh/jhjaggars/tl/Cargo.toml
[INFO] started frobbing jhjaggars/tl
[INFO] finished frobbing jhjaggars/tl
[INFO] frobbed toml for jhjaggars/tl written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jhjaggars/tl/Cargo.toml
[INFO] crate jhjaggars/tl has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jhjaggars/tl against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jhjaggars/tl:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a8f1d447e54b2bc257f749daf163a9c12c6dba3d9dab80874fd2883201912bab
[INFO] running `"docker" "start" "-a" "a8f1d447e54b2bc257f749daf163a9c12c6dba3d9dab80874fd2883201912bab"`
[INFO] [stderr]     Checking dirs v1.0.2
[INFO] [stderr]     Checking chrono v0.4.5
[INFO] [stderr]     Checking docopt v1.0.0
[INFO] [stderr]     Checking chrono-humanize v0.0.11
[INFO] [stderr]     Checking tl v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/todo.rs:135:13
[INFO] [stderr]     |
[INFO] [stderr] 135 |             index: index,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `index`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/todo.rs:135:13
[INFO] [stderr]     |
[INFO] [stderr] 135 |             index: index,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `index`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/todo.rs:81:9
[INFO] [stderr]    |
[INFO] [stderr] 81 |         return Ok(choice);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(choice)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:15:15
[INFO] [stderr]    |
[INFO] [stderr] 15 | const USAGE: &'static str = "
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/todo.rs:81:9
[INFO] [stderr]    |
[INFO] [stderr] 81 |         return Ok(choice);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(choice)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:15:15
[INFO] [stderr]    |
[INFO] [stderr] 15 | const USAGE: &'static str = "
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/todo.rs:45:39
[INFO] [stderr]    |
[INFO] [stderr] 45 |     pub fn add_many(&mut self, items: &Vec<String>) {
[INFO] [stderr]    |                                       ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/todo.rs:74:12
[INFO] [stderr]    |
[INFO] [stderr] 74 |         if choices.len() < 1 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `choices.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/todo.rs:45:39
[INFO] [stderr]    |
[INFO] [stderr] 45 |     pub fn add_many(&mut self, items: &Vec<String>) {
[INFO] [stderr]    |                                       ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/todo.rs:154:9
[INFO] [stderr]     |
[INFO] [stderr] 154 | /         match self.done {
[INFO] [stderr] 155 | |             true => "\u{2713}".green().bold(),
[INFO] [stderr] 156 | |             false => {
[INFO] [stderr] 157 | |                 let now = Utc::now();
[INFO] [stderr] ...   |
[INFO] [stderr] 167 | |             }
[INFO] [stderr] 168 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 154 |         if self.done { "\u{2713}".green().bold() } else {
[INFO] [stderr] 155 |     let now = Utc::now();
[INFO] [stderr] 156 |     let elapsed = now.signed_duration_since(self.created);
[INFO] [stderr] 157 |     let glyph = "\u{25cf}";
[INFO] [stderr] 158 |     if elapsed.num_days() > 1 {
[INFO] [stderr] 159 |         glyph.red()
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/todo.rs:74:12
[INFO] [stderr]    |
[INFO] [stderr] 74 |         if choices.len() < 1 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `choices.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/todo.rs:154:9
[INFO] [stderr]     |
[INFO] [stderr] 154 | /         match self.done {
[INFO] [stderr] 155 | |             true => "\u{2713}".green().bold(),
[INFO] [stderr] 156 | |             false => {
[INFO] [stderr] 157 | |                 let now = Utc::now();
[INFO] [stderr] ...   |
[INFO] [stderr] 167 | |             }
[INFO] [stderr] 168 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 154 |         if self.done { "\u{2713}".green().bold() } else {
[INFO] [stderr] 155 |     let now = Utc::now();
[INFO] [stderr] 156 |     let elapsed = now.signed_duration_since(self.created);
[INFO] [stderr] 157 |     let glyph = "\u{25cf}";
[INFO] [stderr] 158 |     if elapsed.num_days() > 1 {
[INFO] [stderr] 159 |         glyph.red()
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 9.23s
[INFO] running `"docker" "inspect" "a8f1d447e54b2bc257f749daf163a9c12c6dba3d9dab80874fd2883201912bab"`
[INFO] running `"docker" "rm" "-f" "a8f1d447e54b2bc257f749daf163a9c12c6dba3d9dab80874fd2883201912bab"`
[INFO] [stdout] a8f1d447e54b2bc257f749daf163a9c12c6dba3d9dab80874fd2883201912bab