[INFO] updating cached repository jhasse/rust-opengl-test [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jhasse/rust-opengl-test [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jhasse/rust-opengl-test" "work/ex/clippy-test-run/sources/stable/gh/jhasse/rust-opengl-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jhasse/rust-opengl-test'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jhasse/rust-opengl-test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jhasse/rust-opengl-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jhasse/rust-opengl-test'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] aa8b78bac4ae864d92c54d729aadd9045bde7419 [INFO] sha for GitHub repo jhasse/rust-opengl-test: aa8b78bac4ae864d92c54d729aadd9045bde7419 [INFO] validating manifest of jhasse/rust-opengl-test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jhasse/rust-opengl-test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jhasse/rust-opengl-test [INFO] finished frobbing jhasse/rust-opengl-test [INFO] frobbed toml for jhasse/rust-opengl-test written to work/ex/clippy-test-run/sources/stable/gh/jhasse/rust-opengl-test/Cargo.toml [INFO] started frobbing jhasse/rust-opengl-test [INFO] finished frobbing jhasse/rust-opengl-test [INFO] frobbed toml for jhasse/rust-opengl-test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jhasse/rust-opengl-test/Cargo.toml [INFO] crate jhasse/rust-opengl-test has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jhasse/rust-opengl-test against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jhasse/rust-opengl-test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5cfd0ba08fb55be8341c6c9ba03275cbf5f28e30355170225285c9500b9e16c1 [INFO] running `"docker" "start" "-a" "5cfd0ba08fb55be8341c6c9ba03275cbf5f28e30355170225285c9500b9e16c1"` [INFO] [stderr] Compiling libc v0.2.18 [INFO] [stderr] Compiling phf_shared v0.7.20 [INFO] [stderr] Compiling serde v0.8.19 [INFO] [stderr] Compiling gcc v0.3.39 [INFO] [stderr] Compiling x11-dl v2.11.0 [INFO] [stderr] Compiling freetype-sys v0.4.0 [INFO] [stderr] Checking shared_library v0.1.5 [INFO] [stderr] Checking num-complex v0.1.35 [INFO] [stderr] Compiling tempfile v2.1.4 [INFO] [stderr] Checking num-bigint v0.1.35 [INFO] [stderr] Compiling phf v0.7.20 [INFO] [stderr] Compiling glutin v0.7.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Compiling rand v0.3.15 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Compiling libz-sys v1.0.7 [INFO] [stderr] Checking num-rational v0.1.35 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking num v0.1.36 [INFO] [stderr] Checking nalgebra v0.10.1 [INFO] [stderr] Compiling phf_generator v0.7.20 [INFO] [stderr] Checking freetype-rs v0.11.0 [INFO] [stderr] Compiling phf_codegen v0.7.20 [INFO] [stderr] Compiling target_build_utils v0.1.2 [INFO] [stderr] Compiling serde_json v0.8.3 [INFO] [stderr] Compiling libloading v0.3.1 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.6 [INFO] [stderr] Checking wayland-client v0.7.6 [INFO] [stderr] Checking wayland-kbd v0.6.2 [INFO] [stderr] Checking wayland-window v0.4.2 [INFO] [stderr] Checking winit v0.5.6 [INFO] [stderr] Checking rust-opengl-test v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/texture.rs:65:31 [INFO] [stderr] | [INFO] [stderr] 65 | Texture{ id: texture, vao: vao } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vao` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader_program.rs:38:43 [INFO] [stderr] | [INFO] [stderr] 38 | let mut this = ShaderProgram{ id: id, projection_uniform: -1, modelview_uniform: -1 }; [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/font/text.rs:16:15 [INFO] [stderr] | [INFO] [stderr] 16 | Text{ characters: characters } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `characters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/window.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | shader_programs: shader_programs, buffer: buffer, fbo: fbo, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shader_programs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/window.rs:66:47 [INFO] [stderr] | [INFO] [stderr] 66 | shader_programs: shader_programs, buffer: buffer, fbo: fbo, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/window.rs:66:63 [INFO] [stderr] | [INFO] [stderr] 66 | shader_programs: shader_programs, buffer: buffer, fbo: fbo, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fbo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/window.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | vao: vao, texture: 0, shader_program: shader_program, width: width, height: height, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vao` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/window.rs:67:35 [INFO] [stderr] | [INFO] [stderr] 67 | vao: vao, texture: 0, shader_program: shader_program, width: width, height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shader_program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/window.rs:67:67 [INFO] [stderr] | [INFO] [stderr] 67 | vao: vao, texture: 0, shader_program: shader_program, width: width, height: height, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/window.rs:67:81 [INFO] [stderr] | [INFO] [stderr] 67 | vao: vao, texture: 0, shader_program: shader_program, width: width, height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/window.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | work: work, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `work` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/window.rs:296:18 [INFO] [stderr] | [INFO] [stderr] 296 | Triangle{vao: vao} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vao` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rectangle.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | vao: vao [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vao` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/texture.rs:65:31 [INFO] [stderr] | [INFO] [stderr] 65 | Texture{ id: texture, vao: vao } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vao` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader_program.rs:38:43 [INFO] [stderr] | [INFO] [stderr] 38 | let mut this = ShaderProgram{ id: id, projection_uniform: -1, modelview_uniform: -1 }; [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/font/text.rs:16:15 [INFO] [stderr] | [INFO] [stderr] 16 | Text{ characters: characters } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `characters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/window.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | shader_programs: shader_programs, buffer: buffer, fbo: fbo, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shader_programs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/window.rs:66:47 [INFO] [stderr] | [INFO] [stderr] 66 | shader_programs: shader_programs, buffer: buffer, fbo: fbo, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/window.rs:66:63 [INFO] [stderr] | [INFO] [stderr] 66 | shader_programs: shader_programs, buffer: buffer, fbo: fbo, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fbo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/window.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | vao: vao, texture: 0, shader_program: shader_program, width: width, height: height, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vao` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/window.rs:67:35 [INFO] [stderr] | [INFO] [stderr] 67 | vao: vao, texture: 0, shader_program: shader_program, width: width, height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shader_program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/window.rs:67:67 [INFO] [stderr] | [INFO] [stderr] 67 | vao: vao, texture: 0, shader_program: shader_program, width: width, height: height, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/window.rs:67:81 [INFO] [stderr] | [INFO] [stderr] 67 | vao: vao, texture: 0, shader_program: shader_program, width: width, height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/window.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | work: work, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `work` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/window.rs:296:18 [INFO] [stderr] | [INFO] [stderr] 296 | Triangle{vao: vao} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vao` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rectangle.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | vao: vao [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vao` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/paths.rs:19:3 [INFO] [stderr] | [INFO] [stderr] 19 | return Paths{ prefix: tmp }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Paths{ prefix: tmp }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/font/face.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return Face{ ft_face: face }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Face{ ft_face: face }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/texture.rs:23:47 [INFO] [stderr] | [INFO] [stderr] 23 | gl::UNSIGNED_BYTE, mem::transmute(&data[0])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&data[0] as *const u8 as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/texture.rs:49:28 [INFO] [stderr] | [INFO] [stderr] 49 | mem::transmute(&vertexes[0]), gl::STATIC_DRAW); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&vertexes[0] as *const f32 as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from an integer to a pointer [INFO] [stderr] --> src/texture.rs:55:37 [INFO] [stderr] | [INFO] [stderr] 55 | mem::transmute(8 * std::mem::size_of::())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(8 * std::mem::size_of::()) as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/shader.rs:32:50 [INFO] [stderr] | [INFO] [stderr] 32 | gl::ShaderSource(shader, 1, &CString::new(src.as_bytes()).unwrap().as_ptr(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/shader.rs:32:50 [INFO] [stderr] | [INFO] [stderr] 32 | gl::ShaderSource(shader, 1, &CString::new(src.as_bytes()).unwrap().as_ptr(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader.rs:35:45 [INFO] [stderr] | [INFO] [stderr] 35 | let mut status: GLint = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader.rs:37:34 [INFO] [stderr] | [INFO] [stderr] 37 | if status != gl::TRUE as GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/shader.rs:44:37 [INFO] [stderr] | [INFO] [stderr] 44 | std::mem::transmute(&buffer) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&buffer as *const [u8; 512] as *const i8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/shader_program.rs:53:44 [INFO] [stderr] | [INFO] [stderr] 53 | gl::GetAttribLocation(self.id, CString::new(name.as_bytes()).unwrap().as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/shader_program.rs:53:44 [INFO] [stderr] | [INFO] [stderr] 53 | gl::GetAttribLocation(self.id, CString::new(name.as_bytes()).unwrap().as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/shader_program.rs:60:45 [INFO] [stderr] | [INFO] [stderr] 60 | gl::GetUniformLocation(self.id, CString::new(name.as_bytes()).unwrap().as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/shader_program.rs:60:45 [INFO] [stderr] | [INFO] [stderr] 60 | gl::GetUniformLocation(self.id, CString::new(name.as_bytes()).unwrap().as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/shader_program.rs:69:34 [INFO] [stderr] | [INFO] [stderr] 69 | mem::transmute(matrix.as_ref())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `matrix.as_ref() as *const [[f32; 4]; 4] as *const f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/shader_program.rs:76:34 [INFO] [stderr] | [INFO] [stderr] 76 | mem::transmute(matrix.as_ref())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `matrix.as_ref() as *const [[f32; 4]; 4] as *const f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/font/text.rs:14:61 [INFO] [stderr] | [INFO] [stderr] 14 | characters.push(Character::new(shader_programs, &mut face.ft_face, ch)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/font/character.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | let ref glyph = face.glyph(); [INFO] [stderr] | ----^^^^^^^^^---------------- help: try: `let glyph = &face.glyph();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/font/character.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | let ref bitmap = glyph.bitmap(); [INFO] [stderr] | ----^^^^^^^^^^------------------ help: try: `let bitmap = &glyph.bitmap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/font/character.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match self.texture { [INFO] [stderr] 42 | | Some(ref t) => { [INFO] [stderr] 43 | | let mut tmp = shader_programs.modelview.clone(); [INFO] [stderr] 44 | | tmp.translate(self.left, self.top); [INFO] [stderr] ... | [INFO] [stderr] 48 | | _ => () [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | if let Some(ref t) = self.texture { [INFO] [stderr] 42 | let mut tmp = shader_programs.modelview.clone(); [INFO] [stderr] 43 | tmp.translate(self.left, self.top); [INFO] [stderr] 44 | shader_programs.set_uniform(&tmp); [INFO] [stderr] 45 | t.draw(); [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/modelview.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / self.matrix = self.matrix * Matrix4::new(1f32, 0f32, 0f32, x, [INFO] [stderr] 15 | | 0f32, 1f32, 0f32, y, [INFO] [stderr] 16 | | 0f32, 0f32, 1f32, 0f32, [INFO] [stderr] 17 | | 0f32, 0f32, 0f32, 1f32); [INFO] [stderr] | |________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 14 | self.matrix *= Matrix4::new(1f32, 0f32, 0f32, x, [INFO] [stderr] 15 | 0f32, 1f32, 0f32, y, [INFO] [stderr] 16 | 0f32, 0f32, 1f32, 0f32, [INFO] [stderr] 17 | 0f32, 0f32, 0f32, 1f32); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/window.rs:102:28 [INFO] [stderr] | [INFO] [stderr] 102 | std::mem::transmute(&vertexes[0]), gl::STATIC_DRAW); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&vertexes[0] as *const f32 as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/window.rs:114:52 [INFO] [stderr] | [INFO] [stderr] 114 | CString::new("position").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/window.rs:114:52 [INFO] [stderr] | [INFO] [stderr] 114 | CString::new("position").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from an integer to a pointer [INFO] [stderr] --> src/window.rs:117:37 [INFO] [stderr] | [INFO] [stderr] 117 | std::mem::transmute(8 * std::mem::size_of::())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(8 * std::mem::size_of::()) as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/window.rs:121:52 [INFO] [stderr] | [INFO] [stderr] 121 | CString::new("texcoord").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/window.rs:121:52 [INFO] [stderr] | [INFO] [stderr] 121 | CString::new("texcoord").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: The function/method `gl::DeleteTextures` doesn't need a mutable reference [INFO] [stderr] --> src/window.rs:139:39 [INFO] [stderr] | [INFO] [stderr] 139 | gl::DeleteTextures(1, &mut self.texture) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/window.rs:285:24 [INFO] [stderr] | [INFO] [stderr] 285 | std::mem::transmute(&VERTICES[0]), gl::STATIC_DRAW); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&VERTICES[0] as *const f32 as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/rectangle.rs:29:28 [INFO] [stderr] | [INFO] [stderr] 29 | std::mem::transmute(&VERTICES[0]), gl::STATIC_DRAW); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&VERTICES[0] as *const f32 as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/paths.rs:19:3 [INFO] [stderr] | [INFO] [stderr] 19 | return Paths{ prefix: tmp }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Paths{ prefix: tmp }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/font/face.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return Face{ ft_face: face }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Face{ ft_face: face }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-opengl-test`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/texture.rs:23:47 [INFO] [stderr] | [INFO] [stderr] 23 | gl::UNSIGNED_BYTE, mem::transmute(&data[0])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&data[0] as *const u8 as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/texture.rs:49:28 [INFO] [stderr] | [INFO] [stderr] 49 | mem::transmute(&vertexes[0]), gl::STATIC_DRAW); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&vertexes[0] as *const f32 as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from an integer to a pointer [INFO] [stderr] --> src/texture.rs:55:37 [INFO] [stderr] | [INFO] [stderr] 55 | mem::transmute(8 * std::mem::size_of::())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(8 * std::mem::size_of::()) as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/shader.rs:32:50 [INFO] [stderr] | [INFO] [stderr] 32 | gl::ShaderSource(shader, 1, &CString::new(src.as_bytes()).unwrap().as_ptr(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/shader.rs:32:50 [INFO] [stderr] | [INFO] [stderr] 32 | gl::ShaderSource(shader, 1, &CString::new(src.as_bytes()).unwrap().as_ptr(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader.rs:35:45 [INFO] [stderr] | [INFO] [stderr] 35 | let mut status: GLint = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader.rs:37:34 [INFO] [stderr] | [INFO] [stderr] 37 | if status != gl::TRUE as GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/shader.rs:44:37 [INFO] [stderr] | [INFO] [stderr] 44 | std::mem::transmute(&buffer) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&buffer as *const [u8; 512] as *const i8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/shader_program.rs:53:44 [INFO] [stderr] | [INFO] [stderr] 53 | gl::GetAttribLocation(self.id, CString::new(name.as_bytes()).unwrap().as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/shader_program.rs:53:44 [INFO] [stderr] | [INFO] [stderr] 53 | gl::GetAttribLocation(self.id, CString::new(name.as_bytes()).unwrap().as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/shader_program.rs:60:45 [INFO] [stderr] | [INFO] [stderr] 60 | gl::GetUniformLocation(self.id, CString::new(name.as_bytes()).unwrap().as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/shader_program.rs:60:45 [INFO] [stderr] | [INFO] [stderr] 60 | gl::GetUniformLocation(self.id, CString::new(name.as_bytes()).unwrap().as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/shader_program.rs:69:34 [INFO] [stderr] | [INFO] [stderr] 69 | mem::transmute(matrix.as_ref())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `matrix.as_ref() as *const [[f32; 4]; 4] as *const f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/shader_program.rs:76:34 [INFO] [stderr] | [INFO] [stderr] 76 | mem::transmute(matrix.as_ref())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `matrix.as_ref() as *const [[f32; 4]; 4] as *const f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/font/text.rs:14:61 [INFO] [stderr] | [INFO] [stderr] 14 | characters.push(Character::new(shader_programs, &mut face.ft_face, ch)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/font/character.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | let ref glyph = face.glyph(); [INFO] [stderr] | ----^^^^^^^^^---------------- help: try: `let glyph = &face.glyph();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/font/character.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | let ref bitmap = glyph.bitmap(); [INFO] [stderr] | ----^^^^^^^^^^------------------ help: try: `let bitmap = &glyph.bitmap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/font/character.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match self.texture { [INFO] [stderr] 42 | | Some(ref t) => { [INFO] [stderr] 43 | | let mut tmp = shader_programs.modelview.clone(); [INFO] [stderr] 44 | | tmp.translate(self.left, self.top); [INFO] [stderr] ... | [INFO] [stderr] 48 | | _ => () [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | if let Some(ref t) = self.texture { [INFO] [stderr] 42 | let mut tmp = shader_programs.modelview.clone(); [INFO] [stderr] 43 | tmp.translate(self.left, self.top); [INFO] [stderr] 44 | shader_programs.set_uniform(&tmp); [INFO] [stderr] 45 | t.draw(); [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/modelview.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / self.matrix = self.matrix * Matrix4::new(1f32, 0f32, 0f32, x, [INFO] [stderr] 15 | | 0f32, 1f32, 0f32, y, [INFO] [stderr] 16 | | 0f32, 0f32, 1f32, 0f32, [INFO] [stderr] 17 | | 0f32, 0f32, 0f32, 1f32); [INFO] [stderr] | |________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 14 | self.matrix *= Matrix4::new(1f32, 0f32, 0f32, x, [INFO] [stderr] 15 | 0f32, 1f32, 0f32, y, [INFO] [stderr] 16 | 0f32, 0f32, 1f32, 0f32, [INFO] [stderr] 17 | 0f32, 0f32, 0f32, 1f32); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/window.rs:102:28 [INFO] [stderr] | [INFO] [stderr] 102 | std::mem::transmute(&vertexes[0]), gl::STATIC_DRAW); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&vertexes[0] as *const f32 as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/window.rs:114:52 [INFO] [stderr] | [INFO] [stderr] 114 | CString::new("position").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/window.rs:114:52 [INFO] [stderr] | [INFO] [stderr] 114 | CString::new("position").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from an integer to a pointer [INFO] [stderr] --> src/window.rs:117:37 [INFO] [stderr] | [INFO] [stderr] 117 | std::mem::transmute(8 * std::mem::size_of::())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(8 * std::mem::size_of::()) as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/window.rs:121:52 [INFO] [stderr] | [INFO] [stderr] 121 | CString::new("texcoord").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/window.rs:121:52 [INFO] [stderr] | [INFO] [stderr] 121 | CString::new("texcoord").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: The function/method `gl::DeleteTextures` doesn't need a mutable reference [INFO] [stderr] --> src/window.rs:139:39 [INFO] [stderr] | [INFO] [stderr] 139 | gl::DeleteTextures(1, &mut self.texture) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/window.rs:285:24 [INFO] [stderr] | [INFO] [stderr] 285 | std::mem::transmute(&VERTICES[0]), gl::STATIC_DRAW); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&VERTICES[0] as *const f32 as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/rectangle.rs:29:28 [INFO] [stderr] | [INFO] [stderr] 29 | std::mem::transmute(&VERTICES[0]), gl::STATIC_DRAW); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&VERTICES[0] as *const f32 as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-opengl-test`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5cfd0ba08fb55be8341c6c9ba03275cbf5f28e30355170225285c9500b9e16c1"` [INFO] running `"docker" "rm" "-f" "5cfd0ba08fb55be8341c6c9ba03275cbf5f28e30355170225285c9500b9e16c1"` [INFO] [stdout] 5cfd0ba08fb55be8341c6c9ba03275cbf5f28e30355170225285c9500b9e16c1