[INFO] updating cached repository jfro/AoC2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jfro/AoC2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jfro/AoC2018" "work/ex/clippy-test-run/sources/stable/gh/jfro/AoC2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jfro/AoC2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jfro/AoC2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jfro/AoC2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jfro/AoC2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cdc44137117b5048ff77afc811cf1a422e6e813c [INFO] sha for GitHub repo jfro/AoC2018: cdc44137117b5048ff77afc811cf1a422e6e813c [INFO] validating manifest of jfro/AoC2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jfro/AoC2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jfro/AoC2018 [INFO] finished frobbing jfro/AoC2018 [INFO] frobbed toml for jfro/AoC2018 written to work/ex/clippy-test-run/sources/stable/gh/jfro/AoC2018/Cargo.toml [INFO] started frobbing jfro/AoC2018 [INFO] finished frobbing jfro/AoC2018 [INFO] frobbed toml for jfro/AoC2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jfro/AoC2018/Cargo.toml [INFO] crate jfro/AoC2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jfro/AoC2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jfro/AoC2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 122f29006e761cfb73ceaa40b7ea8db771692feae321258729b372fcb27f8bab [INFO] running `"docker" "start" "-a" "122f29006e761cfb73ceaa40b7ea8db771692feae321258729b372fcb27f8bab"` [INFO] [stderr] Checking criterion-plot v0.2.5 [INFO] [stderr] Checking itertools-num v0.1.3 [INFO] [stderr] Checking criterion-stats v0.2.5 [INFO] [stderr] Checking simplelog v0.5.3 [INFO] [stderr] Checking handlebars v0.32.4 [INFO] [stderr] Checking aoc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/days/day4.rs:86:23 [INFO] [stderr] | [INFO] [stderr] 86 | Some(GuardEvent { date: date, time: time, id: final_guard_id.unwrap(), state: final_status }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/days/day4.rs:86:35 [INFO] [stderr] | [INFO] [stderr] 86 | Some(GuardEvent { date: date, time: time, id: final_guard_id.unwrap(), state: final_status }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/days/day1.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | return part1(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `part1()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/days/day5.rs:20:18 [INFO] [stderr] | [INFO] [stderr] 20 | else if second > first { [INFO] [stderr] | __________________^ [INFO] [stderr] 21 | | if second - first == 32 { [INFO] [stderr] 22 | | // print!("{}{} ", c, next_c); [INFO] [stderr] 23 | | replace_indices.push(i); [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 20 | else if second > first && second - first == 32 { [INFO] [stderr] 21 | // print!("{}{} ", c, next_c); [INFO] [stderr] 22 | replace_indices.push(i); [INFO] [stderr] 23 | iter.next(); [INFO] [stderr] 24 | // let r = i..(i+2); [INFO] [stderr] 25 | // string.replace_range(r, ""); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/days/day1.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / if previous.contains_key(&frequency) { [INFO] [stderr] 25 | | return (frequency, Some(frequency)); [INFO] [stderr] 26 | | } else { [INFO] [stderr] 27 | | previous.insert(frequency, 1); [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________^ help: consider using: `previous.entry(frequency)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/days/day3.rs:55:26 [INFO] [stderr] | [INFO] [stderr] 55 | fn generate_grid(claims: &Vec) -> (Vec>>, HashSet) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Claim]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/days/day4.rs:128:29 [INFO] [stderr] | [INFO] [stderr] 128 | format!("{}", best_id * best_min as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(best_min)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/days/day4.rs:198:23 [INFO] [stderr] | [INFO] [stderr] 198 | format!("{}", best_min as u32 * guard_id) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(best_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/days/day5.rs:34:24 [INFO] [stderr] | [INFO] [stderr] 34 | let will_replace = replace_indices.len() > 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!replace_indices.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/days/day5.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | offset = offset + 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset += 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/days/day5.rs:58:20 [INFO] [stderr] | [INFO] [stderr] 58 | let alphabet = ('a' as u8)..('z' as u8); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/days/day5.rs:58:33 [INFO] [stderr] | [INFO] [stderr] 58 | let alphabet = ('a' as u8)..('z' as u8); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'z' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] Checking criterion v0.2.5 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/days/day4.rs:86:23 [INFO] [stderr] | [INFO] [stderr] 86 | Some(GuardEvent { date: date, time: time, id: final_guard_id.unwrap(), state: final_status }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/days/day4.rs:86:35 [INFO] [stderr] | [INFO] [stderr] 86 | Some(GuardEvent { date: date, time: time, id: final_guard_id.unwrap(), state: final_status }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/days/day1.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | return part1(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `part1()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/days/day5.rs:20:18 [INFO] [stderr] | [INFO] [stderr] 20 | else if second > first { [INFO] [stderr] | __________________^ [INFO] [stderr] 21 | | if second - first == 32 { [INFO] [stderr] 22 | | // print!("{}{} ", c, next_c); [INFO] [stderr] 23 | | replace_indices.push(i); [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 20 | else if second > first && second - first == 32 { [INFO] [stderr] 21 | // print!("{}{} ", c, next_c); [INFO] [stderr] 22 | replace_indices.push(i); [INFO] [stderr] 23 | iter.next(); [INFO] [stderr] 24 | // let r = i..(i+2); [INFO] [stderr] 25 | // string.replace_range(r, ""); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/days/day1.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / if previous.contains_key(&frequency) { [INFO] [stderr] 25 | | return (frequency, Some(frequency)); [INFO] [stderr] 26 | | } else { [INFO] [stderr] 27 | | previous.insert(frequency, 1); [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________^ help: consider using: `previous.entry(frequency)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/days/day3.rs:55:26 [INFO] [stderr] | [INFO] [stderr] 55 | fn generate_grid(claims: &Vec) -> (Vec>>, HashSet) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Claim]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/days/day4.rs:128:29 [INFO] [stderr] | [INFO] [stderr] 128 | format!("{}", best_id * best_min as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(best_min)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/days/day4.rs:198:23 [INFO] [stderr] | [INFO] [stderr] 198 | format!("{}", best_min as u32 * guard_id) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(best_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/days/day4.rs:208:31 [INFO] [stderr] | [INFO] [stderr] 208 | assert_eq!(guard_id * best_min as u32, 50558); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(best_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/days/day5.rs:34:24 [INFO] [stderr] | [INFO] [stderr] 34 | let will_replace = replace_indices.len() > 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!replace_indices.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/days/day5.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | offset = offset + 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset += 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/days/day5.rs:58:20 [INFO] [stderr] | [INFO] [stderr] 58 | let alphabet = ('a' as u8)..('z' as u8); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/days/day5.rs:58:33 [INFO] [stderr] | [INFO] [stderr] 58 | let alphabet = ('a' as u8)..('z' as u8); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'z' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.59s [INFO] running `"docker" "inspect" "122f29006e761cfb73ceaa40b7ea8db771692feae321258729b372fcb27f8bab"` [INFO] running `"docker" "rm" "-f" "122f29006e761cfb73ceaa40b7ea8db771692feae321258729b372fcb27f8bab"` [INFO] [stdout] 122f29006e761cfb73ceaa40b7ea8db771692feae321258729b372fcb27f8bab