[INFO] updating cached repository jflewis/interesting-hacker
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jflewis/interesting-hacker
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jflewis/interesting-hacker" "work/ex/clippy-test-run/sources/stable/gh/jflewis/interesting-hacker"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jflewis/interesting-hacker'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jflewis/interesting-hacker" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jflewis/interesting-hacker"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jflewis/interesting-hacker'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 9fb43b513741744be6be86e31da51d4cfd71dd87
[INFO] sha for GitHub repo jflewis/interesting-hacker: 9fb43b513741744be6be86e31da51d4cfd71dd87
[INFO] validating manifest of jflewis/interesting-hacker on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jflewis/interesting-hacker on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jflewis/interesting-hacker
[INFO] finished frobbing jflewis/interesting-hacker
[INFO] frobbed toml for jflewis/interesting-hacker written to work/ex/clippy-test-run/sources/stable/gh/jflewis/interesting-hacker/Cargo.toml
[INFO] started frobbing jflewis/interesting-hacker
[INFO] finished frobbing jflewis/interesting-hacker
[INFO] frobbed toml for jflewis/interesting-hacker written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jflewis/interesting-hacker/Cargo.toml
[INFO] crate jflewis/interesting-hacker has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jflewis/interesting-hacker against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jflewis/interesting-hacker:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 919a157739b33cd250ff4e7bdfe38fd41a8cb3d81c44b806acbe04487910dd68
[INFO] running `"docker" "start" "-a" "919a157739b33cd250ff4e7bdfe38fd41a8cb3d81c44b806acbe04487910dd68"`
[INFO] [stderr]    Compiling openssl-sys v0.9.28
[INFO] [stderr]    Compiling crc v1.7.0
[INFO] [stderr]     Checking toml v0.4.6
[INFO] [stderr]     Checking serde_json v1.0.13
[INFO] [stderr]     Checking serde_urlencoded v0.5.1
[INFO] [stderr]     Checking tokio-proto v0.1.1
[INFO] [stderr]     Checking libflate v0.1.14
[INFO] [stderr]    Compiling openssl v0.9.24
[INFO] [stderr]     Checking hyper v0.11.25
[INFO] [stderr]     Checking native-tls v0.1.5
[INFO] [stderr]     Checking tokio-tls v0.1.4
[INFO] [stderr]     Checking hyper-tls v0.1.3
[INFO] [stderr]     Checking reqwest v0.8.5
[INFO] [stderr]     Checking interesting-hacker v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:39:12
[INFO] [stderr]    |
[INFO] [stderr] 39 |            default_file
[INFO] [stderr]    |            ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:31:32
[INFO] [stderr]    |
[INFO] [stderr] 31 |               let default_file = if default_keyword_location.exists() {
[INFO] [stderr]    |  ________________________________^
[INFO] [stderr] 32 | |                 File::open(default_keyword_location)
[INFO] [stderr] 33 | |             } else {
[INFO] [stderr] 34 | |                 let mut new_file = File::create(".interestingHacker")?;
[INFO] [stderr] 35 | |                 new_file.write_all(b"*").expect("Unable to write to new file");
[INFO] [stderr] 36 | |                 Ok(new_file)
[INFO] [stderr] 37 | |             };
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:39:12
[INFO] [stderr]    |
[INFO] [stderr] 39 |            default_file
[INFO] [stderr]    |            ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:31:32
[INFO] [stderr]    |
[INFO] [stderr] 31 |               let default_file = if default_keyword_location.exists() {
[INFO] [stderr]    |  ________________________________^
[INFO] [stderr] 32 | |                 File::open(default_keyword_location)
[INFO] [stderr] 33 | |             } else {
[INFO] [stderr] 34 | |                 let mut new_file = File::create(".interestingHacker")?;
[INFO] [stderr] 35 | |                 new_file.write_all(b"*").expect("Unable to write to new file");
[INFO] [stderr] 36 | |                 Ok(new_file)
[INFO] [stderr] 37 | |             };
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:28:48
[INFO] [stderr]    |
[INFO] [stderr] 28 |             let mut default_keyword_location = std::env::home_dir().expect("Unable to open home dir path");
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:28:48
[INFO] [stderr]    |
[INFO] [stderr] 28 |             let mut default_keyword_location = std::env::home_dir().expect("Unable to open home dir path");
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 26.82s
[INFO] running `"docker" "inspect" "919a157739b33cd250ff4e7bdfe38fd41a8cb3d81c44b806acbe04487910dd68"`
[INFO] running `"docker" "rm" "-f" "919a157739b33cd250ff4e7bdfe38fd41a8cb3d81c44b806acbe04487910dd68"`
[INFO] [stdout] 919a157739b33cd250ff4e7bdfe38fd41a8cb3d81c44b806acbe04487910dd68