[INFO] updating cached repository jflc/rug
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jflc/rug
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jflc/rug" "work/ex/clippy-test-run/sources/stable/gh/jflc/rug"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jflc/rug'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jflc/rug" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jflc/rug"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jflc/rug'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 43c1a12f9a5720fcea38d897682a9999735fe243
[INFO] sha for GitHub repo jflc/rug: 43c1a12f9a5720fcea38d897682a9999735fe243
[INFO] validating manifest of jflc/rug on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jflc/rug on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jflc/rug
[INFO] finished frobbing jflc/rug
[INFO] frobbed toml for jflc/rug written to work/ex/clippy-test-run/sources/stable/gh/jflc/rug/Cargo.toml
[INFO] started frobbing jflc/rug
[INFO] finished frobbing jflc/rug
[INFO] frobbed toml for jflc/rug written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jflc/rug/Cargo.toml
[INFO] crate jflc/rug has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jflc/rug against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jflc/rug:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6074c5d1dec8a380e5f856127f1d67e27236d398261ebb49974f04e2564e337a
[INFO] running `"docker" "start" "-a" "6074c5d1dec8a380e5f856127f1d67e27236d398261ebb49974f04e2564e337a"`
[INFO] [stderr]     Checking clap v2.32.0
[INFO] [stderr]     Checking rand v0.6.1
[INFO] [stderr]     Checking rug v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/generator/mod.rs:157:31
[INFO] [stderr]     |
[INFO] [stderr] 157 |         let iterations: u32 = 100000;
[INFO] [stderr]     |                               ^^^^^^ help: consider: `100_000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/generator/range_generator.rs:30:36
[INFO] [stderr]    |
[INFO] [stderr] 30 |         let mut sample: Vec<i32> = (config.min..config.max+1).collect();
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(config.min..=config.max)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/generator/choose_generator.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 |         (config.min..config.max+1).choose_multiple(&mut self.rng, config.num)
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(config.min..=config.max)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/generator/shuffle_generator.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         (config.min..config.max+1).collect::<Vec<i32>>()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(config.min..=config.max)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/generator/swap_generator.rs:29:36
[INFO] [stderr]    |
[INFO] [stderr] 29 |         let mut result: Vec<i32> = (config.min..config.max+1).collect();
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(config.min..=config.max)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/generator/range_generator.rs:30:36
[INFO] [stderr]    |
[INFO] [stderr] 30 |         let mut sample: Vec<i32> = (config.min..config.max+1).collect();
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(config.min..=config.max)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/generator/choose_generator.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 |         (config.min..config.max+1).choose_multiple(&mut self.rng, config.num)
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(config.min..=config.max)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/generator/shuffle_generator.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         (config.min..config.max+1).collect::<Vec<i32>>()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(config.min..=config.max)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/generator/swap_generator.rs:29:36
[INFO] [stderr]    |
[INFO] [stderr] 29 |         let mut result: Vec<i32> = (config.min..config.max+1).collect();
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(config.min..=config.max)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/generator/mod.rs:173:19
[INFO] [stderr]     |
[INFO] [stderr] 173 |         let min = *values.values().min().unwrap() as f64 / (iterations as f64 / 100.0);
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(*values.values().min().unwrap())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/generator/mod.rs:173:61
[INFO] [stderr]     |
[INFO] [stderr] 173 |         let min = *values.values().min().unwrap() as f64 / (iterations as f64 / 100.0);
[INFO] [stderr]     |                                                             ^^^^^^^^^^^^^^^^^ help: try: `f64::from(iterations)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/generator/mod.rs:174:19
[INFO] [stderr]     |
[INFO] [stderr] 174 |         let max = *values.values().max().unwrap() as f64 / (iterations as f64 / 100.0);
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(*values.values().max().unwrap())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/generator/mod.rs:174:61
[INFO] [stderr]     |
[INFO] [stderr] 174 |         let max = *values.values().max().unwrap() as f64 / (iterations as f64 / 100.0);
[INFO] [stderr]     |                                                             ^^^^^^^^^^^^^^^^^ help: try: `f64::from(iterations)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 10.58s
[INFO] running `"docker" "inspect" "6074c5d1dec8a380e5f856127f1d67e27236d398261ebb49974f04e2564e337a"`
[INFO] running `"docker" "rm" "-f" "6074c5d1dec8a380e5f856127f1d67e27236d398261ebb49974f04e2564e337a"`
[INFO] [stdout] 6074c5d1dec8a380e5f856127f1d67e27236d398261ebb49974f04e2564e337a